Commit 519a2861 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds

ocfs2: fix an off-by-one BUG_ON() statement

The ->si_slots[] array is allocated in ocfs2_init_slot_info() it has
"->max_slots" number of elements so this test should be >= instead of >.

Static checker work.  Compile tested only.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f08736bd
...@@ -306,7 +306,7 @@ int ocfs2_slot_to_node_num_locked(struct ocfs2_super *osb, int slot_num, ...@@ -306,7 +306,7 @@ int ocfs2_slot_to_node_num_locked(struct ocfs2_super *osb, int slot_num,
assert_spin_locked(&osb->osb_lock); assert_spin_locked(&osb->osb_lock);
BUG_ON(slot_num < 0); BUG_ON(slot_num < 0);
BUG_ON(slot_num > osb->max_slots); BUG_ON(slot_num >= osb->max_slots);
if (!si->si_slots[slot_num].sl_valid) if (!si->si_slots[slot_num].sl_valid)
return -ENOENT; return -ENOENT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment