Commit 51b8e79c authored by andy.shevchenko@gmail.com's avatar andy.shevchenko@gmail.com Committed by Mark Brown

spi: fsl-dspi: Unify error messaging in dspi_request_dma()

Use dev_err_probe() for all messages in dspi_request_dma() for the sake of
making them uniform. While at it, fix indentation issue reported by Vladimir
Oltean.
Signed-off-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240204203127.1186621-3-andy.shevchenko@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent f156743c
...@@ -502,15 +502,12 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ...@@ -502,15 +502,12 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
return -ENOMEM; return -ENOMEM;
dma->chan_rx = dma_request_chan(dev, "rx"); dma->chan_rx = dma_request_chan(dev, "rx");
if (IS_ERR(dma->chan_rx)) { if (IS_ERR(dma->chan_rx))
return dev_err_probe(dev, PTR_ERR(dma->chan_rx), return dev_err_probe(dev, PTR_ERR(dma->chan_rx), "rx dma channel not available\n");
"rx dma channel not available\n");
}
dma->chan_tx = dma_request_chan(dev, "tx"); dma->chan_tx = dma_request_chan(dev, "tx");
if (IS_ERR(dma->chan_tx)) { if (IS_ERR(dma->chan_tx)) {
ret = PTR_ERR(dma->chan_tx); ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx), "tx dma channel not available\n");
dev_err_probe(dev, ret, "tx dma channel not available\n");
goto err_tx_channel; goto err_tx_channel;
} }
...@@ -541,14 +538,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr) ...@@ -541,14 +538,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
cfg.direction = DMA_DEV_TO_MEM; cfg.direction = DMA_DEV_TO_MEM;
ret = dmaengine_slave_config(dma->chan_rx, &cfg); ret = dmaengine_slave_config(dma->chan_rx, &cfg);
if (ret) { if (ret) {
dev_err(dev, "can't configure rx dma channel\n"); dev_err_probe(dev, ret, "can't configure rx dma channel\n");
goto err_slave_config; goto err_slave_config;
} }
cfg.direction = DMA_MEM_TO_DEV; cfg.direction = DMA_MEM_TO_DEV;
ret = dmaengine_slave_config(dma->chan_tx, &cfg); ret = dmaengine_slave_config(dma->chan_tx, &cfg);
if (ret) { if (ret) {
dev_err(dev, "can't configure tx dma channel\n"); dev_err_probe(dev, ret, "can't configure tx dma channel\n");
goto err_slave_config; goto err_slave_config;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment