Commit 51d96dc2 authored by Helge Deller's avatar Helge Deller Committed by Linus Torvalds

random: fix warning message on ia64 and parisc

Fix the warning message on the parisc and IA64 architectures to show the
correct function name of the caller by using %pS instead of %pF. The
message is printed with the value of _RET_IP_ which calls
__builtin_return_address(0) and as such returns the IP address caller
instead of pointer to a function descriptor of the caller.

The effect of this patch is visible on the parisc and ia64 architectures
only since those are the ones which use function descriptors while on
all others %pS and %pF will behave the same.

Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
Fixes: eecabf56 ("random: suppress spammy warnings about unseeded randomness")
Fixes: d06bfd19 ("random: warn when kernel uses unseeded randomness")
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 623ce345
...@@ -1492,7 +1492,7 @@ static void _warn_unseeded_randomness(const char *func_name, void *caller, ...@@ -1492,7 +1492,7 @@ static void _warn_unseeded_randomness(const char *func_name, void *caller,
#ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM #ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM
print_once = true; print_once = true;
#endif #endif
pr_notice("random: %s called from %pF with crng_init=%d\n", pr_notice("random: %s called from %pS with crng_init=%d\n",
func_name, caller, crng_init); func_name, caller, crng_init);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment