Commit 5246741a authored by Mario Limonciello's avatar Mario Limonciello Committed by Darren Hart (VMware)

platform/x86: dell-laptop: Allocate buffer before rfkill use

On machines using rfkill interface the buffer needs to have been
allocated before the initial use (memset) of it.
Reported-by: default avatarValdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@dell.com>
Tested-by: default avatarValdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 868b8d33
...@@ -2073,6 +2073,11 @@ static int __init dell_init(void) ...@@ -2073,6 +2073,11 @@ static int __init dell_init(void)
if (ret) if (ret)
goto fail_platform_device2; goto fail_platform_device2;
buffer = kzalloc(sizeof(struct calling_interface_buffer), GFP_KERNEL);
if (!buffer)
goto fail_buffer;
ret = dell_setup_rfkill(); ret = dell_setup_rfkill();
if (ret) { if (ret) {
...@@ -2080,10 +2085,6 @@ static int __init dell_init(void) ...@@ -2080,10 +2085,6 @@ static int __init dell_init(void)
goto fail_rfkill; goto fail_rfkill;
} }
buffer = kzalloc(sizeof(struct calling_interface_buffer), GFP_KERNEL);
if (!buffer)
goto fail_buffer;
if (quirks && quirks->touchpad_led) if (quirks && quirks->touchpad_led)
touchpad_led_init(&platform_device->dev); touchpad_led_init(&platform_device->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment