Commit 52acf73b authored by Dexuan Cui's avatar Dexuan Cui Committed by David S. Miller

hv_netvsc: Fix a network regression after ifdown/ifup

Recently people reported the NIC stops working after
"ifdown eth0; ifup eth0". It turns out in this case the TX queues are not
enabled, after the refactoring of the common detach logic: when the NIC
has sub-channels, usually we enable all the TX queues after all
sub-channels are set up: see rndis_set_subchannel() ->
netif_device_attach(), but in the case of "ifdown eth0; ifup eth0" where
the number of channels doesn't change, we also must make sure the TX queues
are enabled. The patch fixes the regression.

Fixes: 7b2ee50c ("hv_netvsc: common detach logic")
Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd3a8862
...@@ -127,8 +127,10 @@ static int netvsc_open(struct net_device *net) ...@@ -127,8 +127,10 @@ static int netvsc_open(struct net_device *net)
} }
rdev = nvdev->extension; rdev = nvdev->extension;
if (!rdev->link_state) if (!rdev->link_state) {
netif_carrier_on(net); netif_carrier_on(net);
netif_tx_wake_all_queues(net);
}
if (vf_netdev) { if (vf_netdev) {
/* Setting synthetic device up transparently sets /* Setting synthetic device up transparently sets
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment