Commit 52fa0191 authored by Marek Puzyniak's avatar Marek Puzyniak Committed by Kalle Valo

ath10k: make monitor vdev down before stoping it

Following sequence causes FW crash:
-monitor vdev up,
-monitor vdev stop,
-monitor vdev delete.
Making monitor vdev down before stoping it works ok:
-monitor vdev up,
-monitor vdev down,
-monitor vdev stop,
-monitor vdev delete.
Signed-off-by: default avatarMarek Puzyniak <marek.puzyniak@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 6e712d42
...@@ -562,12 +562,9 @@ static int ath10k_monitor_stop(struct ath10k *ar) ...@@ -562,12 +562,9 @@ static int ath10k_monitor_stop(struct ath10k *ar)
lockdep_assert_held(&ar->conf_mutex); lockdep_assert_held(&ar->conf_mutex);
/* For some reasons, ath10k_wmi_vdev_down() here couse ret = ath10k_wmi_vdev_down(ar, ar->monitor_vdev_id);
* often ath10k_wmi_vdev_stop() to fail. Next we could if (ret)
* not run monitor vdev and driver reload ath10k_warn("Monitor vdev down failed: %d\n", ret);
* required. Don't see such problems we skip
* ath10k_wmi_vdev_down() here.
*/
ret = ath10k_wmi_vdev_stop(ar, ar->monitor_vdev_id); ret = ath10k_wmi_vdev_stop(ar, ar->monitor_vdev_id);
if (ret) if (ret)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment