Commit 53eb47b4 authored by Qing Wang's avatar Qing Wang Committed by Darrick J. Wong

xfs: replace snprintf in show functions with sysfs_emit

coccicheck complains about the use of snprintf() in sysfs show functions.

Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
parent 11a83f4c
...@@ -105,7 +105,7 @@ bug_on_assert_show( ...@@ -105,7 +105,7 @@ bug_on_assert_show(
struct kobject *kobject, struct kobject *kobject,
char *buf) char *buf)
{ {
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.bug_on_assert ? 1 : 0); return sysfs_emit(buf, "%d\n", xfs_globals.bug_on_assert);
} }
XFS_SYSFS_ATTR_RW(bug_on_assert); XFS_SYSFS_ATTR_RW(bug_on_assert);
...@@ -135,7 +135,7 @@ log_recovery_delay_show( ...@@ -135,7 +135,7 @@ log_recovery_delay_show(
struct kobject *kobject, struct kobject *kobject,
char *buf) char *buf)
{ {
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.log_recovery_delay); return sysfs_emit(buf, "%d\n", xfs_globals.log_recovery_delay);
} }
XFS_SYSFS_ATTR_RW(log_recovery_delay); XFS_SYSFS_ATTR_RW(log_recovery_delay);
...@@ -165,7 +165,7 @@ mount_delay_show( ...@@ -165,7 +165,7 @@ mount_delay_show(
struct kobject *kobject, struct kobject *kobject,
char *buf) char *buf)
{ {
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.mount_delay); return sysfs_emit(buf, "%d\n", xfs_globals.mount_delay);
} }
XFS_SYSFS_ATTR_RW(mount_delay); XFS_SYSFS_ATTR_RW(mount_delay);
...@@ -188,7 +188,7 @@ always_cow_show( ...@@ -188,7 +188,7 @@ always_cow_show(
struct kobject *kobject, struct kobject *kobject,
char *buf) char *buf)
{ {
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.always_cow); return sysfs_emit(buf, "%d\n", xfs_globals.always_cow);
} }
XFS_SYSFS_ATTR_RW(always_cow); XFS_SYSFS_ATTR_RW(always_cow);
...@@ -224,7 +224,7 @@ pwork_threads_show( ...@@ -224,7 +224,7 @@ pwork_threads_show(
struct kobject *kobject, struct kobject *kobject,
char *buf) char *buf)
{ {
return snprintf(buf, PAGE_SIZE, "%d\n", xfs_globals.pwork_threads); return sysfs_emit(buf, "%d\n", xfs_globals.pwork_threads);
} }
XFS_SYSFS_ATTR_RW(pwork_threads); XFS_SYSFS_ATTR_RW(pwork_threads);
#endif /* DEBUG */ #endif /* DEBUG */
...@@ -327,7 +327,7 @@ log_head_lsn_show( ...@@ -327,7 +327,7 @@ log_head_lsn_show(
block = log->l_curr_block; block = log->l_curr_block;
spin_unlock(&log->l_icloglock); spin_unlock(&log->l_icloglock);
return snprintf(buf, PAGE_SIZE, "%d:%d\n", cycle, block); return sysfs_emit(buf, "%d:%d\n", cycle, block);
} }
XFS_SYSFS_ATTR_RO(log_head_lsn); XFS_SYSFS_ATTR_RO(log_head_lsn);
...@@ -341,7 +341,7 @@ log_tail_lsn_show( ...@@ -341,7 +341,7 @@ log_tail_lsn_show(
struct xlog *log = to_xlog(kobject); struct xlog *log = to_xlog(kobject);
xlog_crack_atomic_lsn(&log->l_tail_lsn, &cycle, &block); xlog_crack_atomic_lsn(&log->l_tail_lsn, &cycle, &block);
return snprintf(buf, PAGE_SIZE, "%d:%d\n", cycle, block); return sysfs_emit(buf, "%d:%d\n", cycle, block);
} }
XFS_SYSFS_ATTR_RO(log_tail_lsn); XFS_SYSFS_ATTR_RO(log_tail_lsn);
...@@ -356,7 +356,7 @@ reserve_grant_head_show( ...@@ -356,7 +356,7 @@ reserve_grant_head_show(
struct xlog *log = to_xlog(kobject); struct xlog *log = to_xlog(kobject);
xlog_crack_grant_head(&log->l_reserve_head.grant, &cycle, &bytes); xlog_crack_grant_head(&log->l_reserve_head.grant, &cycle, &bytes);
return snprintf(buf, PAGE_SIZE, "%d:%d\n", cycle, bytes); return sysfs_emit(buf, "%d:%d\n", cycle, bytes);
} }
XFS_SYSFS_ATTR_RO(reserve_grant_head); XFS_SYSFS_ATTR_RO(reserve_grant_head);
...@@ -370,7 +370,7 @@ write_grant_head_show( ...@@ -370,7 +370,7 @@ write_grant_head_show(
struct xlog *log = to_xlog(kobject); struct xlog *log = to_xlog(kobject);
xlog_crack_grant_head(&log->l_write_head.grant, &cycle, &bytes); xlog_crack_grant_head(&log->l_write_head.grant, &cycle, &bytes);
return snprintf(buf, PAGE_SIZE, "%d:%d\n", cycle, bytes); return sysfs_emit(buf, "%d:%d\n", cycle, bytes);
} }
XFS_SYSFS_ATTR_RO(write_grant_head); XFS_SYSFS_ATTR_RO(write_grant_head);
...@@ -425,7 +425,7 @@ max_retries_show( ...@@ -425,7 +425,7 @@ max_retries_show(
else else
retries = cfg->max_retries; retries = cfg->max_retries;
return snprintf(buf, PAGE_SIZE, "%d\n", retries); return sysfs_emit(buf, "%d\n", retries);
} }
static ssize_t static ssize_t
...@@ -466,7 +466,7 @@ retry_timeout_seconds_show( ...@@ -466,7 +466,7 @@ retry_timeout_seconds_show(
else else
timeout = jiffies_to_msecs(cfg->retry_timeout) / MSEC_PER_SEC; timeout = jiffies_to_msecs(cfg->retry_timeout) / MSEC_PER_SEC;
return snprintf(buf, PAGE_SIZE, "%d\n", timeout); return sysfs_emit(buf, "%d\n", timeout);
} }
static ssize_t static ssize_t
...@@ -504,7 +504,7 @@ fail_at_unmount_show( ...@@ -504,7 +504,7 @@ fail_at_unmount_show(
{ {
struct xfs_mount *mp = err_to_mp(kobject); struct xfs_mount *mp = err_to_mp(kobject);
return snprintf(buf, PAGE_SIZE, "%d\n", mp->m_fail_unmount); return sysfs_emit(buf, "%d\n", mp->m_fail_unmount);
} }
static ssize_t static ssize_t
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment