Commit 542808f5 authored by Philippe Reynes's avatar Philippe Reynes Committed by David S. Miller

net: ethernet: r6040: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure
net_device already contain such pointer. So we can remove the pointer
phydev in the private structure, and update the driver to use the
one contained in struct net_device.
Signed-off-by: default avatarPhilippe Reynes <tremyfr@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 802fe79e
...@@ -200,7 +200,6 @@ struct r6040_private { ...@@ -200,7 +200,6 @@ struct r6040_private {
struct mii_bus *mii_bus; struct mii_bus *mii_bus;
struct napi_struct napi; struct napi_struct napi;
void __iomem *base; void __iomem *base;
struct phy_device *phydev;
int old_link; int old_link;
int old_duplex; int old_duplex;
}; };
...@@ -474,7 +473,7 @@ static void r6040_down(struct net_device *dev) ...@@ -474,7 +473,7 @@ static void r6040_down(struct net_device *dev)
iowrite16(adrp[1], ioaddr + MID_0M); iowrite16(adrp[1], ioaddr + MID_0M);
iowrite16(adrp[2], ioaddr + MID_0H); iowrite16(adrp[2], ioaddr + MID_0H);
phy_stop(lp->phydev); phy_stop(dev->phydev);
} }
static int r6040_close(struct net_device *dev) static int r6040_close(struct net_device *dev)
...@@ -515,12 +514,10 @@ static int r6040_close(struct net_device *dev) ...@@ -515,12 +514,10 @@ static int r6040_close(struct net_device *dev)
static int r6040_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) static int r6040_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{ {
struct r6040_private *lp = netdev_priv(dev); if (!dev->phydev)
if (!lp->phydev)
return -EINVAL; return -EINVAL;
return phy_mii_ioctl(lp->phydev, rq, cmd); return phy_mii_ioctl(dev->phydev, rq, cmd);
} }
static int r6040_rx(struct net_device *dev, int limit) static int r6040_rx(struct net_device *dev, int limit)
...@@ -732,7 +729,7 @@ static int r6040_up(struct net_device *dev) ...@@ -732,7 +729,7 @@ static int r6040_up(struct net_device *dev)
/* Initialize all MAC registers */ /* Initialize all MAC registers */
r6040_init_mac_regs(dev); r6040_init_mac_regs(dev);
phy_start(lp->phydev); phy_start(dev->phydev);
return 0; return 0;
} }
...@@ -959,16 +956,12 @@ static void netdev_get_drvinfo(struct net_device *dev, ...@@ -959,16 +956,12 @@ static void netdev_get_drvinfo(struct net_device *dev,
static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{ {
struct r6040_private *rp = netdev_priv(dev); return phy_ethtool_gset(dev->phydev, cmd);
return phy_ethtool_gset(rp->phydev, cmd);
} }
static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) static int netdev_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{ {
struct r6040_private *rp = netdev_priv(dev); return phy_ethtool_sset(dev->phydev, cmd);
return phy_ethtool_sset(rp->phydev, cmd);
} }
static const struct ethtool_ops netdev_ethtool_ops = { static const struct ethtool_ops netdev_ethtool_ops = {
...@@ -998,7 +991,7 @@ static const struct net_device_ops r6040_netdev_ops = { ...@@ -998,7 +991,7 @@ static const struct net_device_ops r6040_netdev_ops = {
static void r6040_adjust_link(struct net_device *dev) static void r6040_adjust_link(struct net_device *dev)
{ {
struct r6040_private *lp = netdev_priv(dev); struct r6040_private *lp = netdev_priv(dev);
struct phy_device *phydev = lp->phydev; struct phy_device *phydev = dev->phydev;
int status_changed = 0; int status_changed = 0;
void __iomem *ioaddr = lp->base; void __iomem *ioaddr = lp->base;
...@@ -1057,7 +1050,6 @@ static int r6040_mii_probe(struct net_device *dev) ...@@ -1057,7 +1050,6 @@ static int r6040_mii_probe(struct net_device *dev)
| SUPPORTED_TP); | SUPPORTED_TP);
phydev->advertising = phydev->supported; phydev->advertising = phydev->supported;
lp->phydev = phydev;
lp->old_link = 0; lp->old_link = 0;
lp->old_duplex = -1; lp->old_duplex = -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment