Commit 553fdff6 authored by David Gibson's avatar David Gibson Committed by Paul Mackerras

[POWERPC] Improve robustness of the UIC cascade handler

At present the cascade interrupt handler for the UIC (interrupt
controller on 4xx embedded chips) will misbehave badly if it is called
spuriously - that is if the handler is invoked when no interrupts are
asserted in the child UIC.

Although spurious interrupts shouldn't happen, it's good to behave
robustly if they do.  This patch does so by checking for and ignoring
spurious interrupts.
Signed-off-by: default avatarValentine Barshak <vbarshak@ru.mvista.com>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
Acked-by: default avatarJosh Boyer <jwboyer@linux.vnet.ibm.com>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 868afce2
...@@ -266,6 +266,9 @@ irqreturn_t uic_cascade(int virq, void *data) ...@@ -266,6 +266,9 @@ irqreturn_t uic_cascade(int virq, void *data)
int subvirq; int subvirq;
msr = mfdcr(uic->dcrbase + UIC_MSR); msr = mfdcr(uic->dcrbase + UIC_MSR);
if (!msr) /* spurious interrupt */
return IRQ_HANDLED;
src = 32 - ffs(msr); src = 32 - ffs(msr);
subvirq = irq_linear_revmap(uic->irqhost, src); subvirq = irq_linear_revmap(uic->irqhost, src);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment