Commit 5601cda8 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Trond Myklebust

nfs: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent f5fdf124
...@@ -141,7 +141,7 @@ struct nfs_cache_array { ...@@ -141,7 +141,7 @@ struct nfs_cache_array {
int size; int size;
int eof_index; int eof_index;
u64 last_cookie; u64 last_cookie;
struct nfs_cache_array_entry array[0]; struct nfs_cache_array_entry array[];
}; };
typedef struct { typedef struct {
......
...@@ -5550,7 +5550,7 @@ static int buf_to_pages_noslab(const void *buf, size_t buflen, ...@@ -5550,7 +5550,7 @@ static int buf_to_pages_noslab(const void *buf, size_t buflen,
struct nfs4_cached_acl { struct nfs4_cached_acl {
int cached; int cached;
size_t len; size_t len;
char data[0]; char data[];
}; };
static void nfs4_set_cached_acl(struct inode *inode, struct nfs4_cached_acl *acl) static void nfs4_set_cached_acl(struct inode *inode, struct nfs4_cached_acl *acl)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment