Commit 562bf770 authored by Jules Irenge's avatar Jules Irenge Committed by Corey Minyard

ipmi: Add missing annotation for ipmi_ssif_lock_cond() and ipmi_ssif_unlock_cond()

Sparse reports a warning at ipmi_ssif_unlock_cond()
	and ipmi_ssif_lock_cond()

warning: context imbalance in ipmi_ssif_lock_cond()
	- wrong count at exit
 warning: context imbalance in ipmi_ssif_unlock_cond()
	- unexpected unlock

The root cause is the missing annotation at ipmi_ssif_unlock_cond()
	and ipmi_ssif_lock_cond()

Add the missing __acquires(&ata_scsi_rbuf_lock)
Add the missing __releases(&ata_scsi_rbuf_lock)
Signed-off-by: default avatarJules Irenge <jbi.octave@gmail.com>
Message-Id: <20200403160505.2832-6-jbi.octave@gmail.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 09f5f680
...@@ -313,6 +313,7 @@ static int start_send(struct ssif_info *ssif_info, ...@@ -313,6 +313,7 @@ static int start_send(struct ssif_info *ssif_info,
static unsigned long *ipmi_ssif_lock_cond(struct ssif_info *ssif_info, static unsigned long *ipmi_ssif_lock_cond(struct ssif_info *ssif_info,
unsigned long *flags) unsigned long *flags)
__acquires(&ssif_info->lock)
{ {
spin_lock_irqsave(&ssif_info->lock, *flags); spin_lock_irqsave(&ssif_info->lock, *flags);
return flags; return flags;
...@@ -320,6 +321,7 @@ static unsigned long *ipmi_ssif_lock_cond(struct ssif_info *ssif_info, ...@@ -320,6 +321,7 @@ static unsigned long *ipmi_ssif_lock_cond(struct ssif_info *ssif_info,
static void ipmi_ssif_unlock_cond(struct ssif_info *ssif_info, static void ipmi_ssif_unlock_cond(struct ssif_info *ssif_info,
unsigned long *flags) unsigned long *flags)
__releases(&ssif_info->lock)
{ {
spin_unlock_irqrestore(&ssif_info->lock, *flags); spin_unlock_irqrestore(&ssif_info->lock, *flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment