Commit 571f2c11 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

qlcnic: constify qlcnic_mbx_ops structure

The only instance of a qlcnic_mbx_ops structure is never modified.  Thus
the declaration of the structure and all references to the structure type
can be made const.

In the definition of the qlcnic_mailbox structure, the ops field is no
longer lined up with the other fields.  This was left as is, to avoid a lot
of trivial changes on the other lines.

Done with the help of Coccinelle.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarSony Chacko <sony.chacko@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6623c60d
...@@ -1092,7 +1092,7 @@ struct qlcnic_filter_hash { ...@@ -1092,7 +1092,7 @@ struct qlcnic_filter_hash {
struct qlcnic_mailbox { struct qlcnic_mailbox {
struct workqueue_struct *work_q; struct workqueue_struct *work_q;
struct qlcnic_adapter *adapter; struct qlcnic_adapter *adapter;
struct qlcnic_mbx_ops *ops; const struct qlcnic_mbx_ops *ops;
struct work_struct work; struct work_struct work;
struct completion completion; struct completion completion;
struct list_head cmd_q; struct list_head cmd_q;
......
...@@ -4048,7 +4048,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work) ...@@ -4048,7 +4048,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work)
struct qlcnic_mailbox *mbx = container_of(work, struct qlcnic_mailbox, struct qlcnic_mailbox *mbx = container_of(work, struct qlcnic_mailbox,
work); work);
struct qlcnic_adapter *adapter = mbx->adapter; struct qlcnic_adapter *adapter = mbx->adapter;
struct qlcnic_mbx_ops *mbx_ops = mbx->ops; const struct qlcnic_mbx_ops *mbx_ops = mbx->ops;
struct device *dev = &adapter->pdev->dev; struct device *dev = &adapter->pdev->dev;
atomic_t *rsp_status = &mbx->rsp_status; atomic_t *rsp_status = &mbx->rsp_status;
struct list_head *head = &mbx->cmd_q; struct list_head *head = &mbx->cmd_q;
...@@ -4098,7 +4098,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work) ...@@ -4098,7 +4098,7 @@ static void qlcnic_83xx_mailbox_worker(struct work_struct *work)
} }
} }
static struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = { static const struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = {
.enqueue_cmd = qlcnic_83xx_enqueue_mbx_cmd, .enqueue_cmd = qlcnic_83xx_enqueue_mbx_cmd,
.dequeue_cmd = qlcnic_83xx_dequeue_mbx_cmd, .dequeue_cmd = qlcnic_83xx_dequeue_mbx_cmd,
.decode_resp = qlcnic_83xx_decode_mbx_rsp, .decode_resp = qlcnic_83xx_decode_mbx_rsp,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment