Commit 575dd7ec authored by Frank Li's avatar Frank Li Committed by Peter Chen

usb: cdns3: fix static checker warning.

The patch c450e48eb570: "usb: cdns3: add power lost support for
system resume" from Feb 18, 2021, leads to the following static
checker warning:

        drivers/usb/cdns3/core.c:551 cdns_resume()
        error: uninitialized symbol 'ret'.

drivers/usb/cdns3/core.c
544
545     if (!role_changed) {
546            if (cdns->role == USB_ROLE_HOST)
547                  ret = cdns_drd_host_on(cdns);
548     else if (cdns->role == USB_ROLE_DEVICE)
549            ret = cdns_drd_gadget_on(cdns);

"ret" is uninitialized at else branch.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarFrank Li <frank.li@nxp.com>
Signed-off-by: default avatarPeter Chen <peter.chen@kernel.org>
parent ef32e051
......@@ -527,7 +527,7 @@ int cdns_resume(struct cdns *cdns, u8 set_active)
struct device *dev = cdns->dev;
enum usb_role real_role;
bool role_changed = false;
int ret;
int ret = 0;
if (cdns_power_is_lost(cdns)) {
if (cdns->role_sw) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment