Commit 57c0e136 authored by Siddharth Vadapalli's avatar Siddharth Vadapalli Committed by Vinod Koul

phy: ti: j721e-wiz: Fix unreachable code in wiz_mode_select()

In the wiz_mode_select() function, the configuration performed for
PHY_TYPE_USXGMII is unreachable. Fix it.

Fixes: b64a85fb ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver")
Signed-off-by: default avatarSiddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Link: https://lore.kernel.org/r/20230403094552.929108-1-s-vadapalli@ti.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 0cfa43ab
...@@ -443,18 +443,17 @@ static int wiz_mode_select(struct wiz *wiz) ...@@ -443,18 +443,17 @@ static int wiz_mode_select(struct wiz *wiz)
int i; int i;
for (i = 0; i < num_lanes; i++) { for (i = 0; i < num_lanes; i++) {
if (wiz->lane_phy_type[i] == PHY_TYPE_DP) if (wiz->lane_phy_type[i] == PHY_TYPE_DP) {
mode = LANE_MODE_GEN1; mode = LANE_MODE_GEN1;
else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) } else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII) {
mode = LANE_MODE_GEN2; mode = LANE_MODE_GEN2;
else } else if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) {
continue;
if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) {
ret = regmap_field_write(wiz->p0_mac_src_sel[i], 0x3); ret = regmap_field_write(wiz->p0_mac_src_sel[i], 0x3);
ret = regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3); ret = regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3);
ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x3); ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x3);
mode = LANE_MODE_GEN1; mode = LANE_MODE_GEN1;
} else {
continue;
} }
ret = regmap_field_write(wiz->p_standard_mode[i], mode); ret = regmap_field_write(wiz->p_standard_mode[i], mode);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment