Commit 57f728d5 authored by Randy Dunlap's avatar Randy Dunlap Committed by Yury Norov

cpumask: kernel-doc cleanups and additions

Clean up some punctutation and abbreviations.
Add kernel-doc notation for one function and function return value
for 39 functions.

cpumask.h:
Fix some punctuation (plural vs. possessive).
Fix some abbreviations (ie. -> i.e., id -> ID).

Fix 35 warnings like this:
include/linux/cpumask.h:161: warning: No description found for return value of 'cpumask_first'

cpumask.c:
Add Return: value for 4 functions.
Add kernel-doc for cpumask_any_distribute().
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarYury Norov <yury.norov@gmail.com>
parent 94f6f055
This diff is collapsed.
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
* @start: the start point of the iteration * @start: the start point of the iteration
* @wrap: assume @n crossing @start terminates the iteration * @wrap: assume @n crossing @start terminates the iteration
* *
* Returns >= nr_cpu_ids on completion * Return: >= nr_cpu_ids on completion
* *
* Note: the @wrap argument is required for the start condition when * Note: the @wrap argument is required for the start condition when
* we cannot assume @start is set in @mask. * we cannot assume @start is set in @mask.
...@@ -48,8 +48,9 @@ EXPORT_SYMBOL(cpumask_next_wrap); ...@@ -48,8 +48,9 @@ EXPORT_SYMBOL(cpumask_next_wrap);
* @node: memory node from which to allocate or %NUMA_NO_NODE * @node: memory node from which to allocate or %NUMA_NO_NODE
* *
* Only defined when CONFIG_CPUMASK_OFFSTACK=y, otherwise is * Only defined when CONFIG_CPUMASK_OFFSTACK=y, otherwise is
* a nop returning a constant 1 (in <linux/cpumask.h>) * a nop returning a constant 1 (in <linux/cpumask.h>).
* Returns TRUE if memory allocation succeeded, FALSE otherwise. *
* Return: TRUE if memory allocation succeeded, FALSE otherwise.
* *
* In addition, mask will be NULL if this fails. Note that gcc is * In addition, mask will be NULL if this fails. Note that gcc is
* usually smart enough to know that mask can never be NULL if * usually smart enough to know that mask can never be NULL if
...@@ -115,7 +116,7 @@ void __init free_bootmem_cpumask_var(cpumask_var_t mask) ...@@ -115,7 +116,7 @@ void __init free_bootmem_cpumask_var(cpumask_var_t mask)
* @i: index number * @i: index number
* @node: local numa_node * @node: local numa_node
* *
* Returns online CPU according to a numa aware policy; local cpus are returned * Return: online CPU according to a numa aware policy; local cpus are returned
* first, followed by non-local ones, then it wraps around. * first, followed by non-local ones, then it wraps around.
* *
* For those who wants to enumerate all CPUs based on their NUMA distances, * For those who wants to enumerate all CPUs based on their NUMA distances,
...@@ -165,7 +166,7 @@ static DEFINE_PER_CPU(int, distribute_cpu_mask_prev); ...@@ -165,7 +166,7 @@ static DEFINE_PER_CPU(int, distribute_cpu_mask_prev);
* Iterated calls using the same srcp1 and srcp2 will be distributed within * Iterated calls using the same srcp1 and srcp2 will be distributed within
* their intersection. * their intersection.
* *
* Returns >= nr_cpu_ids if the intersection is empty. * Return: >= nr_cpu_ids if the intersection is empty.
*/ */
unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, unsigned int cpumask_any_and_distribute(const struct cpumask *src1p,
const struct cpumask *src2p) const struct cpumask *src2p)
...@@ -184,6 +185,12 @@ unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, ...@@ -184,6 +185,12 @@ unsigned int cpumask_any_and_distribute(const struct cpumask *src1p,
} }
EXPORT_SYMBOL(cpumask_any_and_distribute); EXPORT_SYMBOL(cpumask_any_and_distribute);
/**
* cpumask_any_distribute - Return an arbitrary cpu from srcp
* @srcp: &cpumask for selection
*
* Return: >= nr_cpu_ids if the intersection is empty.
*/
unsigned int cpumask_any_distribute(const struct cpumask *srcp) unsigned int cpumask_any_distribute(const struct cpumask *srcp)
{ {
unsigned int next, prev; unsigned int next, prev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment