Commit 582cef43 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman

usg: gadget: Move validation out of lock in webusb_bcdVersion_store()

Validation has nothing to do with any protected data,
move it out of the lock and make code neater.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230127112638.84806-1-andriy.shevchenko@linux.intel.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2bf40502
......@@ -836,19 +836,15 @@ static ssize_t webusb_bcdVersion_store(struct config_item *item,
if (ret)
return ret;
mutex_lock(&gi->lock);
ret = is_valid_bcd(bcdVersion);
if (ret)
goto out;
return ret;
mutex_lock(&gi->lock);
gi->bcd_webusb_version = bcdVersion;
ret = len;
out:
mutex_unlock(&gi->lock);
return ret;
return len;
}
static ssize_t webusb_bVendorCode_show(struct config_item *item, char *page)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment