Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
linux
Commits
58609306
Commit
58609306
authored
Jul 22, 2012
by
Al Viro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
sound_firmware: don't pass crap to filp_close()
Signed-off-by:
Al Viro
<
viro@zeniv.linux.org.uk
>
parent
20818a0c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
sound/sound_firmware.c
sound/sound_firmware.c
+4
-4
No files found.
sound/sound_firmware.c
View file @
58609306
...
@@ -23,14 +23,14 @@ static int do_mod_firmware_load(const char *fn, char **fp)
...
@@ -23,14 +23,14 @@ static int do_mod_firmware_load(const char *fn, char **fp)
if
(
l
<=
0
||
l
>
131072
)
if
(
l
<=
0
||
l
>
131072
)
{
{
printk
(
KERN_INFO
"Invalid firmware '%s'
\n
"
,
fn
);
printk
(
KERN_INFO
"Invalid firmware '%s'
\n
"
,
fn
);
filp_close
(
filp
,
current
->
files
);
filp_close
(
filp
,
NULL
);
return
0
;
return
0
;
}
}
dp
=
vmalloc
(
l
);
dp
=
vmalloc
(
l
);
if
(
dp
==
NULL
)
if
(
dp
==
NULL
)
{
{
printk
(
KERN_INFO
"Out of memory loading '%s'.
\n
"
,
fn
);
printk
(
KERN_INFO
"Out of memory loading '%s'.
\n
"
,
fn
);
filp_close
(
filp
,
current
->
files
);
filp_close
(
filp
,
NULL
);
return
0
;
return
0
;
}
}
pos
=
0
;
pos
=
0
;
...
@@ -38,10 +38,10 @@ static int do_mod_firmware_load(const char *fn, char **fp)
...
@@ -38,10 +38,10 @@ static int do_mod_firmware_load(const char *fn, char **fp)
{
{
printk
(
KERN_INFO
"Failed to read '%s'.
\n
"
,
fn
);
printk
(
KERN_INFO
"Failed to read '%s'.
\n
"
,
fn
);
vfree
(
dp
);
vfree
(
dp
);
filp_close
(
filp
,
current
->
files
);
filp_close
(
filp
,
NULL
);
return
0
;
return
0
;
}
}
filp_close
(
filp
,
current
->
files
);
filp_close
(
filp
,
NULL
);
*
fp
=
dp
;
*
fp
=
dp
;
return
(
int
)
l
;
return
(
int
)
l
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment