Commit 58a74c6f authored by Bernard Zhao's avatar Bernard Zhao Committed by Daniel Vetter

drm/via: fix assignment in if condition

Fix check_patch.pl warning:
ERROR: do not use assignment in if condition
+                       if ((HALCYON_HEADER2 == (cmd = *buf)) &&

ERROR: do not use assignment in if condition
+                       if (HALCYON_HEADER2 == (cmd = *buf))
Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201118114021.105502-1-bernard@vivo.com
parent b1246bd4
...@@ -1001,8 +1001,8 @@ via_verify_command_stream(const uint32_t * buf, unsigned int size, ...@@ -1001,8 +1001,8 @@ via_verify_command_stream(const uint32_t * buf, unsigned int size,
state = via_check_vheader6(&buf, buf_end); state = via_check_vheader6(&buf, buf_end);
break; break;
case state_command: case state_command:
if ((HALCYON_HEADER2 == (cmd = *buf)) && cmd = *buf;
supported_3d) if ((cmd == HALCYON_HEADER2) && supported_3d)
state = state_header2; state = state_header2;
else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1) else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1)
state = state_header1; state = state_header1;
...@@ -1064,7 +1064,8 @@ via_parse_command_stream(struct drm_device *dev, const uint32_t *buf, ...@@ -1064,7 +1064,8 @@ via_parse_command_stream(struct drm_device *dev, const uint32_t *buf,
state = via_parse_vheader6(dev_priv, &buf, buf_end); state = via_parse_vheader6(dev_priv, &buf, buf_end);
break; break;
case state_command: case state_command:
if (HALCYON_HEADER2 == (cmd = *buf)) cmd = *buf;
if (cmd == HALCYON_HEADER2)
state = state_header2; state = state_header2;
else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1) else if ((cmd & HALCYON_HEADER1MASK) == HALCYON_HEADER1)
state = state_header1; state = state_header1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment