Commit 599d924c authored by John Harrison's avatar John Harrison Committed by Daniel Vetter

drm/i915: Update ring->sync_to() to take a request structure

Updated the ring->sync_to() implementations to take a request instead of a ring.
Also updated the tracer to include the request id.

For: VIZ-5115
Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Reviewed-by: default avatarTomas Elf <tomas.elf@intel.com>
[danvet: Rebase since I didn't merge the patch which added ->uniq.]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent be795fc1
...@@ -3139,8 +3139,8 @@ __i915_gem_object_sync(struct drm_i915_gem_object *obj, ...@@ -3139,8 +3139,8 @@ __i915_gem_object_sync(struct drm_i915_gem_object *obj,
return ret; return ret;
} }
trace_i915_gem_ring_sync_to(from, to, from_req); trace_i915_gem_ring_sync_to(*to_req, from, from_req);
ret = to->semaphore.sync_to(to, from, seqno); ret = to->semaphore.sync_to(*to_req, from, seqno);
if (ret) if (ret)
return ret; return ret;
......
...@@ -424,10 +424,10 @@ TRACE_EVENT(i915_gem_evict_vm, ...@@ -424,10 +424,10 @@ TRACE_EVENT(i915_gem_evict_vm,
); );
TRACE_EVENT(i915_gem_ring_sync_to, TRACE_EVENT(i915_gem_ring_sync_to,
TP_PROTO(struct intel_engine_cs *from, TP_PROTO(struct drm_i915_gem_request *to_req,
struct intel_engine_cs *to, struct intel_engine_cs *from,
struct drm_i915_gem_request *req), struct drm_i915_gem_request *req),
TP_ARGS(from, to, req), TP_ARGS(to_req, from, req),
TP_STRUCT__entry( TP_STRUCT__entry(
__field(u32, dev) __field(u32, dev)
...@@ -439,7 +439,7 @@ TRACE_EVENT(i915_gem_ring_sync_to, ...@@ -439,7 +439,7 @@ TRACE_EVENT(i915_gem_ring_sync_to,
TP_fast_assign( TP_fast_assign(
__entry->dev = from->dev->primary->index; __entry->dev = from->dev->primary->index;
__entry->sync_from = from->id; __entry->sync_from = from->id;
__entry->sync_to = to->id; __entry->sync_to = to_req->ring->id;
__entry->seqno = i915_gem_request_get_seqno(req); __entry->seqno = i915_gem_request_get_seqno(req);
), ),
......
...@@ -1333,10 +1333,11 @@ static inline bool i915_gem_has_seqno_wrapped(struct drm_device *dev, ...@@ -1333,10 +1333,11 @@ static inline bool i915_gem_has_seqno_wrapped(struct drm_device *dev,
*/ */
static int static int
gen8_ring_sync(struct intel_engine_cs *waiter, gen8_ring_sync(struct drm_i915_gem_request *waiter_req,
struct intel_engine_cs *signaller, struct intel_engine_cs *signaller,
u32 seqno) u32 seqno)
{ {
struct intel_engine_cs *waiter = waiter_req->ring;
struct drm_i915_private *dev_priv = waiter->dev->dev_private; struct drm_i915_private *dev_priv = waiter->dev->dev_private;
int ret; int ret;
...@@ -1358,10 +1359,11 @@ gen8_ring_sync(struct intel_engine_cs *waiter, ...@@ -1358,10 +1359,11 @@ gen8_ring_sync(struct intel_engine_cs *waiter,
} }
static int static int
gen6_ring_sync(struct intel_engine_cs *waiter, gen6_ring_sync(struct drm_i915_gem_request *waiter_req,
struct intel_engine_cs *signaller, struct intel_engine_cs *signaller,
u32 seqno) u32 seqno)
{ {
struct intel_engine_cs *waiter = waiter_req->ring;
u32 dw1 = MI_SEMAPHORE_MBOX | u32 dw1 = MI_SEMAPHORE_MBOX |
MI_SEMAPHORE_COMPARE | MI_SEMAPHORE_COMPARE |
MI_SEMAPHORE_REGISTER; MI_SEMAPHORE_REGISTER;
......
...@@ -252,8 +252,8 @@ struct intel_engine_cs { ...@@ -252,8 +252,8 @@ struct intel_engine_cs {
}; };
/* AKA wait() */ /* AKA wait() */
int (*sync_to)(struct intel_engine_cs *ring, int (*sync_to)(struct drm_i915_gem_request *to_req,
struct intel_engine_cs *to, struct intel_engine_cs *from,
u32 seqno); u32 seqno);
int (*signal)(struct intel_engine_cs *signaller, int (*signal)(struct intel_engine_cs *signaller,
/* num_dwords needed by caller */ /* num_dwords needed by caller */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment