Commit 5a3b32de authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Thadeu Lima de Souza Cascardo

Revert "bsg-lib: don't free job in bsg_prepare_job"

BugLink: http://bugs.launchpad.net/bugs/1729105

This reverts commit 668cee82 which was
commit f507b54d upstream.

Ben reports:
	That function doesn't exist here (it was introduced in 4.13).
	Instead, this backport has modified bsg_create_job(), creating a
	leak.  Please revert this on the 3.18, 4.4 and 4.9 stable
	branches.

So I'm dropping it from here.
Reported-by: default avatarBen Hutchings <ben.hutchings@codethink.co.uk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
parent 625631d9
...@@ -147,6 +147,7 @@ static int bsg_create_job(struct device *dev, struct request *req) ...@@ -147,6 +147,7 @@ static int bsg_create_job(struct device *dev, struct request *req)
failjob_rls_rqst_payload: failjob_rls_rqst_payload:
kfree(job->request_payload.sg_list); kfree(job->request_payload.sg_list);
failjob_rls_job: failjob_rls_job:
kfree(job);
return -ENOMEM; return -ENOMEM;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment