Commit 5aee52c4 authored by Tom Rix's avatar Tom Rix Committed by Martin K. Petersen

scsi: scsi_transport_spi: Fix function pointer check

clang static analysis flags several null function pointer problems.

drivers/scsi/scsi_transport_spi.c:374:1: warning: Called function pointer is null (null dereference) [core.CallAndMessage]
spi_transport_max_attr(offset, "%d\n");
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewing the store_spi_store_max macro

	if (i->f->set_##field)
		return -EINVAL;

should be

	if (!i->f->set_##field)
		return -EINVAL;

Link: https://lore.kernel.org/r/20200627133242.21618-1-trix@redhat.comReviewed-by: default avatarJames Bottomley <jejb@linux.ibm.com>
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 311950f8
...@@ -339,7 +339,7 @@ store_spi_transport_##field(struct device *dev, \ ...@@ -339,7 +339,7 @@ store_spi_transport_##field(struct device *dev, \
struct spi_transport_attrs *tp \ struct spi_transport_attrs *tp \
= (struct spi_transport_attrs *)&starget->starget_data; \ = (struct spi_transport_attrs *)&starget->starget_data; \
\ \
if (i->f->set_##field) \ if (!i->f->set_##field) \
return -EINVAL; \ return -EINVAL; \
val = simple_strtoul(buf, NULL, 0); \ val = simple_strtoul(buf, NULL, 0); \
if (val > tp->max_##field) \ if (val > tp->max_##field) \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment