Commit 5bc376ad authored by Theodore Ts'o's avatar Theodore Ts'o Committed by Kleber Sacilotto de Souza

ext4: fix online resizing for bigalloc file systems with a 1k block size

BugLink: https://bugs.launchpad.net/bugs/1798617

commit 5f8c1093 upstream.

An online resize of a file system with the bigalloc feature enabled
and a 1k block size would be refused since ext4_resize_begin() did not
understand s_first_data_block is 0 for all bigalloc file systems, even
when the block size is 1k.
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 85cdf458
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
int ext4_resize_begin(struct super_block *sb) int ext4_resize_begin(struct super_block *sb)
{ {
struct ext4_sb_info *sbi = EXT4_SB(sb);
int ret = 0; int ret = 0;
if (!ns_capable(sb->s_user_ns, CAP_SYS_RESOURCE)) if (!ns_capable(sb->s_user_ns, CAP_SYS_RESOURCE))
...@@ -28,7 +29,7 @@ int ext4_resize_begin(struct super_block *sb) ...@@ -28,7 +29,7 @@ int ext4_resize_begin(struct super_block *sb)
* because the user tools have no way of handling this. Probably a * because the user tools have no way of handling this. Probably a
* bad time to do it anyways. * bad time to do it anyways.
*/ */
if (EXT4_SB(sb)->s_sbh->b_blocknr != if (EXT4_B2C(sbi, sbi->s_sbh->b_blocknr) !=
le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) { le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block)) {
ext4_warning(sb, "won't resize using backup superblock at %llu", ext4_warning(sb, "won't resize using backup superblock at %llu",
(unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr); (unsigned long long)EXT4_SB(sb)->s_sbh->b_blocknr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment