Commit 5c0b7f26 authored by Ben Collins's avatar Ben Collins

[IEEE1394]: Fix compilation when CONFIG_COMPAT is enabled (32/64 systems).

  This was broken by the last commit for cdev stuff which removed the
  "int ret;" that these routines used.
parent 15ef5034
...@@ -1277,12 +1277,15 @@ static int __init amdtp_init_module (void) ...@@ -1277,12 +1277,15 @@ static int __init amdtp_init_module (void)
hpsb_register_highlevel(&amdtp_highlevel); hpsb_register_highlevel(&amdtp_highlevel);
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
ret = register_ioctl32_conversion(AMDTP_IOC_CHANNEL, NULL); {
ret |= register_ioctl32_conversion(AMDTP_IOC_PLUG, NULL); int ret;
ret |= register_ioctl32_conversion(AMDTP_IOC_PING, NULL); ret = register_ioctl32_conversion(AMDTP_IOC_CHANNEL, NULL);
ret |= register_ioctl32_conversion(AMDTP_IOC_ZAP, NULL); ret |= register_ioctl32_conversion(AMDTP_IOC_PLUG, NULL);
if (ret) ret |= register_ioctl32_conversion(AMDTP_IOC_PING, NULL);
HPSB_ERR("amdtp: Error registering ioctl32 translations"); ret |= register_ioctl32_conversion(AMDTP_IOC_ZAP, NULL);
if (ret)
HPSB_ERR("amdtp: Error registering ioctl32 translations");
}
#endif #endif
HPSB_INFO("Loaded AMDTP driver"); HPSB_INFO("Loaded AMDTP driver");
......
...@@ -2631,18 +2631,22 @@ static int __init dv1394_init_module(void) ...@@ -2631,18 +2631,22 @@ static int __init dv1394_init_module(void)
hpsb_register_protocol(&dv1394_driver); hpsb_register_protocol(&dv1394_driver);
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
/* First compatible ones */ {
ret = register_ioctl32_conversion(DV1394_IOC_SHUTDOWN, NULL); int ret;
ret |= register_ioctl32_conversion(DV1394_IOC_SUBMIT_FRAMES, NULL);
ret |= register_ioctl32_conversion(DV1394_IOC_WAIT_FRAMES, NULL); /* First compatible ones */
ret |= register_ioctl32_conversion(DV1394_IOC_RECEIVE_FRAMES, NULL); ret = register_ioctl32_conversion(DV1394_IOC_SHUTDOWN, NULL);
ret |= register_ioctl32_conversion(DV1394_IOC_START_RECEIVE, NULL); ret |= register_ioctl32_conversion(DV1394_IOC_SUBMIT_FRAMES, NULL);
ret |= register_ioctl32_conversion(DV1394_IOC_WAIT_FRAMES, NULL);
/* These need to be handled by translation */ ret |= register_ioctl32_conversion(DV1394_IOC_RECEIVE_FRAMES, NULL);
ret |= register_ioctl32_conversion(DV1394_IOC32_INIT, handle_dv1394_init); ret |= register_ioctl32_conversion(DV1394_IOC_START_RECEIVE, NULL);
ret |= register_ioctl32_conversion(DV1394_IOC32_GET_STATUS, handle_dv1394_get_status);
if (ret) /* These need to be handled by translation */
printk(KERN_ERR "dv1394: Error registering ioctl32 translations\n"); ret |= register_ioctl32_conversion(DV1394_IOC32_INIT, handle_dv1394_init);
ret |= register_ioctl32_conversion(DV1394_IOC32_GET_STATUS, handle_dv1394_get_status);
if (ret)
printk(KERN_ERR "dv1394: Error registering ioctl32 translations\n");
}
#endif #endif
return 0; return 0;
......
...@@ -1470,25 +1470,29 @@ static int __init video1394_init_module (void) ...@@ -1470,25 +1470,29 @@ static int __init video1394_init_module (void)
hpsb_register_protocol(&video1394_driver); hpsb_register_protocol(&video1394_driver);
#ifdef CONFIG_COMPAT #ifdef CONFIG_COMPAT
/* First the compatible ones */ {
ret = register_ioctl32_conversion(VIDEO1394_IOC_LISTEN_CHANNEL, NULL); int ret;
ret |= register_ioctl32_conversion(VIDEO1394_IOC_UNLISTEN_CHANNEL, NULL);
ret |= register_ioctl32_conversion(VIDEO1394_IOC_TALK_CHANNEL, NULL); /* First the compatible ones */
ret |= register_ioctl32_conversion(VIDEO1394_IOC_UNTALK_CHANNEL, NULL); ret = register_ioctl32_conversion(VIDEO1394_IOC_LISTEN_CHANNEL, NULL);
ret |= register_ioctl32_conversion(VIDEO1394_IOC_UNLISTEN_CHANNEL, NULL);
/* These need translation */ ret |= register_ioctl32_conversion(VIDEO1394_IOC_TALK_CHANNEL, NULL);
ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_QUEUE_BUFFER, ret |= register_ioctl32_conversion(VIDEO1394_IOC_UNTALK_CHANNEL, NULL);
video1394_w_wait32);
ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_WAIT_BUFFER, /* These need translation */
video1394_wr_wait32); ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_QUEUE_BUFFER,
ret |= register_ioctl32_conversion(VIDEO1394_IOC_TALK_QUEUE_BUFFER, video1394_w_wait32);
video1394_queue_buf32); ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_WAIT_BUFFER,
ret |= register_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER, video1394_wr_wait32);
video1394_w_wait32); ret |= register_ioctl32_conversion(VIDEO1394_IOC_TALK_QUEUE_BUFFER,
ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER, video1394_queue_buf32);
video1394_wr_wait32); ret |= register_ioctl32_conversion(VIDEO1394_IOC32_TALK_WAIT_BUFFER,
if (ret) video1394_w_wait32);
PRINT_G(KERN_INFO, "Error registering ioctl32 translations"); ret |= register_ioctl32_conversion(VIDEO1394_IOC32_LISTEN_POLL_BUFFER,
video1394_wr_wait32);
if (ret)
PRINT_G(KERN_INFO, "Error registering ioctl32 translations");
}
#endif #endif
PRINT_G(KERN_INFO, "Installed " VIDEO1394_DRIVER_NAME " module"); PRINT_G(KERN_INFO, "Installed " VIDEO1394_DRIVER_NAME " module");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment