Commit 5c57f6c4 authored by Yangtao Li's avatar Yangtao Li Committed by Ulf Hansson

mmc: pwrseq: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Link: https://lore.kernel.org/r/20230727070051.17778-55-frank.li@vivo.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 884e8696
...@@ -90,14 +90,12 @@ static int mmc_pwrseq_emmc_probe(struct platform_device *pdev) ...@@ -90,14 +90,12 @@ static int mmc_pwrseq_emmc_probe(struct platform_device *pdev)
return mmc_pwrseq_register(&pwrseq->pwrseq); return mmc_pwrseq_register(&pwrseq->pwrseq);
} }
static int mmc_pwrseq_emmc_remove(struct platform_device *pdev) static void mmc_pwrseq_emmc_remove(struct platform_device *pdev)
{ {
struct mmc_pwrseq_emmc *pwrseq = platform_get_drvdata(pdev); struct mmc_pwrseq_emmc *pwrseq = platform_get_drvdata(pdev);
unregister_restart_handler(&pwrseq->reset_nb); unregister_restart_handler(&pwrseq->reset_nb);
mmc_pwrseq_unregister(&pwrseq->pwrseq); mmc_pwrseq_unregister(&pwrseq->pwrseq);
return 0;
} }
static const struct of_device_id mmc_pwrseq_emmc_of_match[] = { static const struct of_device_id mmc_pwrseq_emmc_of_match[] = {
...@@ -109,7 +107,7 @@ MODULE_DEVICE_TABLE(of, mmc_pwrseq_emmc_of_match); ...@@ -109,7 +107,7 @@ MODULE_DEVICE_TABLE(of, mmc_pwrseq_emmc_of_match);
static struct platform_driver mmc_pwrseq_emmc_driver = { static struct platform_driver mmc_pwrseq_emmc_driver = {
.probe = mmc_pwrseq_emmc_probe, .probe = mmc_pwrseq_emmc_probe,
.remove = mmc_pwrseq_emmc_remove, .remove_new = mmc_pwrseq_emmc_remove,
.driver = { .driver = {
.name = "pwrseq_emmc", .name = "pwrseq_emmc",
.of_match_table = mmc_pwrseq_emmc_of_match, .of_match_table = mmc_pwrseq_emmc_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment