Commit 5caa8475 authored by Adrian Bunk's avatar Adrian Bunk Committed by Christoph Hellwig

[PATCH] drivers/scsi/sg.c kill local jiffies functions

[patch] kill local sg_ms_to_jif/sg_jif_to_ms functions and use
        msecs_to_jiffies/jiffies_to_msecs instead
Signed-off-by: default avatarAdrian Bunk <bunk@fs.tum.de>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent fabecf79
...@@ -205,8 +205,6 @@ static Sg_request *sg_get_rq_mark(Sg_fd * sfp, int pack_id); ...@@ -205,8 +205,6 @@ static Sg_request *sg_get_rq_mark(Sg_fd * sfp, int pack_id);
static Sg_request *sg_add_request(Sg_fd * sfp); static Sg_request *sg_add_request(Sg_fd * sfp);
static int sg_remove_request(Sg_fd * sfp, Sg_request * srp); static int sg_remove_request(Sg_fd * sfp, Sg_request * srp);
static int sg_res_in_use(Sg_fd * sfp); static int sg_res_in_use(Sg_fd * sfp);
static int sg_ms_to_jif(unsigned int msecs);
static inline unsigned sg_jif_to_ms(int jifs);
static int sg_allow_access(unsigned char opcode, char dev_type); static int sg_allow_access(unsigned char opcode, char dev_type);
static int sg_build_direct(Sg_request * srp, Sg_fd * sfp, int dxfer_len); static int sg_build_direct(Sg_request * srp, Sg_fd * sfp, int dxfer_len);
static Sg_device *sg_get_dev(int dev); static Sg_device *sg_get_dev(int dev);
...@@ -612,7 +610,7 @@ sg_new_write(Sg_fd * sfp, const char __user *buf, size_t count, ...@@ -612,7 +610,7 @@ sg_new_write(Sg_fd * sfp, const char __user *buf, size_t count,
return -EBUSY; /* reserve buffer already being used */ return -EBUSY; /* reserve buffer already being used */
} }
} }
timeout = sg_ms_to_jif(srp->header.timeout); timeout = msecs_to_jiffies(srp->header.timeout);
if ((!hp->cmdp) || (hp->cmd_len < 6) || (hp->cmd_len > sizeof (cmnd))) { if ((!hp->cmdp) || (hp->cmd_len < 6) || (hp->cmd_len > sizeof (cmnd))) {
sg_remove_request(sfp, srp); sg_remove_request(sfp, srp);
return -EMSGSIZE; return -EMSGSIZE;
...@@ -929,7 +927,7 @@ sg_ioctl(struct inode *inode, struct file *filp, ...@@ -929,7 +927,7 @@ sg_ioctl(struct inode *inode, struct file *filp,
srp->header.driver_status; srp->header.driver_status;
rinfo[val].duration = rinfo[val].duration =
srp->done ? srp->header.duration : srp->done ? srp->header.duration :
sg_jif_to_ms( jiffies_to_msecs(
jiffies - srp->header.duration); jiffies - srp->header.duration);
rinfo[val].orphan = srp->orphan; rinfo[val].orphan = srp->orphan;
rinfo[val].sg_io_owned = srp->sg_io_owned; rinfo[val].sg_io_owned = srp->sg_io_owned;
...@@ -1251,7 +1249,7 @@ sg_cmd_done(Scsi_Cmnd * SCpnt) ...@@ -1251,7 +1249,7 @@ sg_cmd_done(Scsi_Cmnd * SCpnt)
srp->header.resid = SCpnt->resid; srp->header.resid = SCpnt->resid;
/* N.B. unit of duration changes here from jiffies to millisecs */ /* N.B. unit of duration changes here from jiffies to millisecs */
srp->header.duration = srp->header.duration =
sg_jif_to_ms(jiffies - (int) srp->header.duration); jiffies_to_msecs(jiffies - srp->header.duration);
if (0 != SRpnt->sr_result) { if (0 != SRpnt->sr_result) {
memcpy(srp->sense_b, SRpnt->sr_sense_buffer, memcpy(srp->sense_b, SRpnt->sr_sense_buffer,
sizeof (srp->sense_b)); sizeof (srp->sense_b));
...@@ -2575,30 +2573,6 @@ sg_page_free(char *buff, int size) ...@@ -2575,30 +2573,6 @@ sg_page_free(char *buff, int size)
free_pages((unsigned long) buff, order); free_pages((unsigned long) buff, order);
} }
static int
sg_ms_to_jif(unsigned int msecs)
{
if ((UINT_MAX / 2U) < msecs)
return INT_MAX; /* special case, set largest possible */
else
return ((int) msecs <
(INT_MAX / 1000)) ? (((int) msecs * HZ) / 1000)
: (((int) msecs / 1000) * HZ);
}
static inline unsigned
sg_jif_to_ms(int jifs)
{
if (jifs <= 0)
return 0U;
else {
unsigned int j = (unsigned int) jifs;
return (j <
(UINT_MAX / 1000)) ? ((j * 1000) / HZ) : ((j / HZ) *
1000);
}
}
static unsigned char allow_ops[] = { TEST_UNIT_READY, REQUEST_SENSE, static unsigned char allow_ops[] = { TEST_UNIT_READY, REQUEST_SENSE,
INQUIRY, READ_CAPACITY, READ_BUFFER, READ_6, READ_10, READ_12, INQUIRY, READ_CAPACITY, READ_BUFFER, READ_6, READ_10, READ_12,
MODE_SENSE, MODE_SENSE_10, LOG_SENSE MODE_SENSE, MODE_SENSE_10, LOG_SENSE
...@@ -2961,7 +2935,7 @@ static void sg_proc_debug_helper(struct seq_file *s, Sg_device * sdp) ...@@ -2961,7 +2935,7 @@ static void sg_proc_debug_helper(struct seq_file *s, Sg_device * sdp)
for (k = 0; (fp = sg_get_nth_sfp(sdp, k)); ++k) { for (k = 0; (fp = sg_get_nth_sfp(sdp, k)); ++k) {
seq_printf(s, " FD(%d): timeout=%dms bufflen=%d " seq_printf(s, " FD(%d): timeout=%dms bufflen=%d "
"(res)sgat=%d low_dma=%d\n", k + 1, "(res)sgat=%d low_dma=%d\n", k + 1,
sg_jif_to_ms(fp->timeout), jiffies_to_msecs(fp->timeout),
fp->reserve.bufflen, fp->reserve.bufflen,
(int) fp->reserve.k_use_sg, (int) fp->reserve.k_use_sg,
(int) fp->low_dma); (int) fp->low_dma);
...@@ -2997,8 +2971,8 @@ static void sg_proc_debug_helper(struct seq_file *s, Sg_device * sdp) ...@@ -2997,8 +2971,8 @@ static void sg_proc_debug_helper(struct seq_file *s, Sg_device * sdp)
seq_printf(s, " dur=%d", hp->duration); seq_printf(s, " dur=%d", hp->duration);
else else
seq_printf(s, " t_o/elap=%d/%d", seq_printf(s, " t_o/elap=%d/%d",
new_interface ? hp->timeout : sg_jif_to_ms(fp->timeout), new_interface ? hp->timeout : jiffies_to_msecs(fp->timeout),
sg_jif_to_ms(hp->duration ? (jiffies - hp->duration) : 0)); jiffies_to_msecs(hp->duration ? (jiffies - hp->duration) : 0));
seq_printf(s, "ms sgat=%d op=0x%02x\n", usg, seq_printf(s, "ms sgat=%d op=0x%02x\n", usg,
(int) srp->data.cmd_opcode); (int) srp->data.cmd_opcode);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment