Commit 5cbe9f3a authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] ivtv: fix two smatch warnings

Smatch currently produces two warnings:
	drivers/media/pci/ivtv/ivtv-fileops.c:901 ivtv_v4l2_close() warn: suspicious bitop condition
	drivers/media/pci/ivtv/ivtv-fileops.c:1026 ivtv_open() warn: suspicious bitop condition

Those are false positives, but it is not hard to get rid of them by
using a different way to evaluate the macro, splitting the logical
boolean evaluation from the bitmap one.
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent c65171cf
...@@ -830,7 +830,8 @@ static inline int ivtv_raw_vbi(const struct ivtv *itv) ...@@ -830,7 +830,8 @@ static inline int ivtv_raw_vbi(const struct ivtv *itv)
do { \ do { \
struct v4l2_subdev *__sd; \ struct v4l2_subdev *__sd; \
__v4l2_device_call_subdevs_p(&(itv)->v4l2_dev, __sd, \ __v4l2_device_call_subdevs_p(&(itv)->v4l2_dev, __sd, \
!(hw) || (__sd->grp_id & (hw)), o, f , ##args); \ !(hw) ? true : (__sd->grp_id & (hw)), \
o, f, ##args); \
} while (0) } while (0)
#define ivtv_call_all(itv, o, f, args...) ivtv_call_hw(itv, 0, o, f , ##args) #define ivtv_call_all(itv, o, f, args...) ivtv_call_hw(itv, 0, o, f , ##args)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment