Commit 5d77b7a1 authored by Eric Dumazet's avatar Eric Dumazet Committed by Luis Henriques

flow_dissect: call init_default_flow_dissectors() earlier

BugLink: https://bugs.launchpad.net/bugs/1645278

Andre Noll reported panics after my recent fix (commit 34fad54c
"net: __skb_flow_dissect() must cap its return value")

After some more headaches, Alexander root caused the problem to
init_default_flow_dissectors() being called too late, in case
a network driver like IGB is not a module and receives DHCP message
very early.

Fix is to call init_default_flow_dissectors() much earlier,
as it is a core infrastructure and does not depend on another
kernel service.

Fixes: 06635a35 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarAndre Noll <maan@tuebingen.mpg.de>
Diagnosed-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
(cherry picked from commit c9b8af13)
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
Acked-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarStefan Bader <stefan.bader@canonical.com>
Acked-by: default avatarTim Gardner <tim.gardner@canonical.com>
parent 45a1f5da
......@@ -949,4 +949,4 @@ static int __init init_default_flow_dissectors(void)
return 0;
}
late_initcall_sync(init_default_flow_dissectors);
core_initcall(init_default_flow_dissectors);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment