Commit 5e3ea764 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Neil Armstrong

drm/bridge: thc63lvd1024: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230318190804.234610-19-u.kleine-koenig@pengutronix.de
parent ed58ee12
...@@ -230,13 +230,11 @@ static int thc63_probe(struct platform_device *pdev) ...@@ -230,13 +230,11 @@ static int thc63_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int thc63_remove(struct platform_device *pdev) static void thc63_remove(struct platform_device *pdev)
{ {
struct thc63_dev *thc63 = platform_get_drvdata(pdev); struct thc63_dev *thc63 = platform_get_drvdata(pdev);
drm_bridge_remove(&thc63->bridge); drm_bridge_remove(&thc63->bridge);
return 0;
} }
static const struct of_device_id thc63_match[] = { static const struct of_device_id thc63_match[] = {
...@@ -247,7 +245,7 @@ MODULE_DEVICE_TABLE(of, thc63_match); ...@@ -247,7 +245,7 @@ MODULE_DEVICE_TABLE(of, thc63_match);
static struct platform_driver thc63_driver = { static struct platform_driver thc63_driver = {
.probe = thc63_probe, .probe = thc63_probe,
.remove = thc63_remove, .remove_new = thc63_remove,
.driver = { .driver = {
.name = "thc63lvd1024", .name = "thc63lvd1024",
.of_match_table = thc63_match, .of_match_table = thc63_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment