Commit 5e4e1ff8 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe

ubd: move set_disk_ro to ubd_add

No need to delay this until open time.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarRichard Weinberger <richard@nod.at>
Link: https://lore.kernel.org/r/20240222072417.3773131-6-hch@lst.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 58ebe3e7
...@@ -903,6 +903,7 @@ static int ubd_add(int n, char **error_out) ...@@ -903,6 +903,7 @@ static int ubd_add(int n, char **error_out)
set_capacity(disk, ubd_dev->size / 512); set_capacity(disk, ubd_dev->size / 512);
sprintf(disk->disk_name, "ubd%c", 'a' + n); sprintf(disk->disk_name, "ubd%c", 'a' + n);
disk->private_data = ubd_dev; disk->private_data = ubd_dev;
set_disk_ro(disk, !ubd_dev->openflags.w);
ubd_dev->pdev.id = n; ubd_dev->pdev.id = n;
ubd_dev->pdev.name = DRIVER_NAME; ubd_dev->pdev.name = DRIVER_NAME;
...@@ -1159,7 +1160,6 @@ static int ubd_open(struct gendisk *disk, blk_mode_t mode) ...@@ -1159,7 +1160,6 @@ static int ubd_open(struct gendisk *disk, blk_mode_t mode)
} }
} }
ubd_dev->count++; ubd_dev->count++;
set_disk_ro(disk, !ubd_dev->openflags.w);
out: out:
mutex_unlock(&ubd_mutex); mutex_unlock(&ubd_mutex);
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment