Commit 5e9ef02e authored by Shaohua Li's avatar Shaohua Li Committed by Linus Torvalds

[PATCH] i386/x86-64 disable LAPIC completely for offline CPU

Disabling LAPIC timer isn't sufficient.  In some situations, such as we
enabled NMI watchdog, there is still unexpected interrupt (such as NMI)
invoked in offline CPU.  This also avoids offline CPU receives spurious
interrupt and anything similar.
Signed-off-by: default avatarShaohua Li <shaohua.li@intel.com>
Signed-off-by: default avatarAndi Kleen <ak@suse.de>
Acked-by: default avatar"Seth, Rohit" <rohit.seth@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 68e18891
...@@ -1338,8 +1338,7 @@ int __cpu_disable(void) ...@@ -1338,8 +1338,7 @@ int __cpu_disable(void)
if (cpu == 0) if (cpu == 0)
return -EBUSY; return -EBUSY;
/* We enable the timer again on the exit path of the death loop */ clear_local_APIC();
disable_APIC_timer();
/* Allow any queued timer interrupts to get serviced */ /* Allow any queued timer interrupts to get serviced */
local_irq_enable(); local_irq_enable();
mdelay(1); mdelay(1);
......
...@@ -1181,7 +1181,7 @@ int __cpu_disable(void) ...@@ -1181,7 +1181,7 @@ int __cpu_disable(void)
if (cpu == 0) if (cpu == 0)
return -EBUSY; return -EBUSY;
disable_APIC_timer(); clear_local_APIC();
/* /*
* HACK: * HACK:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment