Commit 5ed74b03 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller

xgene-v2: Fix a resource leak in the error handling path of 'xge_probe()'

A successful 'xge_mdio_config()' call should be balanced by a corresponding
'xge_mdio_remove()' call in the error handling path of the probe, as
already done in the remove function.

Update the error handling path accordingly.

Fixes: ea8ab16a ("drivers: net: xgene-v2: Add MDIO support")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9cf448c2
...@@ -677,11 +677,13 @@ static int xge_probe(struct platform_device *pdev) ...@@ -677,11 +677,13 @@ static int xge_probe(struct platform_device *pdev)
ret = register_netdev(ndev); ret = register_netdev(ndev);
if (ret) { if (ret) {
netdev_err(ndev, "Failed to register netdev\n"); netdev_err(ndev, "Failed to register netdev\n");
goto err; goto err_mdio_remove;
} }
return 0; return 0;
err_mdio_remove:
xge_mdio_remove(ndev);
err: err:
free_netdev(ndev); free_netdev(ndev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment