Commit 6001567c authored by Ilya Dryomov's avatar Ilya Dryomov

libceph: avoid a use-after-free during map check

Sending map check after complete_request() was called is not only
useless, but can lead to a use-after-free as req->r_kref decrement in
__complete_request() races with map check code.
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Acked-by: default avatarJeff Layton <jlayton@redhat.com>
Reviewed-by: default avatar"Yan, Zheng" <zyan@redhat.com>
parent 29e87820
...@@ -2266,7 +2266,7 @@ static void __submit_request(struct ceph_osd_request *req, bool wrlocked) ...@@ -2266,7 +2266,7 @@ static void __submit_request(struct ceph_osd_request *req, bool wrlocked)
complete_request(req, err); complete_request(req, err);
mutex_unlock(&osd->lock); mutex_unlock(&osd->lock);
if (ct_res == CALC_TARGET_POOL_DNE) if (!err && ct_res == CALC_TARGET_POOL_DNE)
send_map_check(req); send_map_check(req);
if (promoted) if (promoted)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment