Commit 611b8813 authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Mark Brown

ASoC: cs35l41: Use modern pm_ops

Make use of the recently introduced EXPORT_GPL_DEV_PM_OPS() macro, to
conditionally export the runtime/system PM functions.

Replace the old SET_{RUNTIME,SYSTEM_SLEEP,NOIRQ_SYSTEM_SLEEP}_PM_OPS()
helpers with their modern alternatives and get rid of the now
unnecessary '__maybe_unused' annotations on all PM functions.

Additionally, use the pm_ptr() macro to fix the following errors when
building with CONFIG_PM disabled:

ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-i2c.ko] undefined!
Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230907171010.1447274-9-cristian.ciocaltea@collabora.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3db52739
...@@ -80,7 +80,7 @@ MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match); ...@@ -80,7 +80,7 @@ MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
static struct i2c_driver cs35l41_i2c_driver = { static struct i2c_driver cs35l41_i2c_driver = {
.driver = { .driver = {
.name = "cs35l41", .name = "cs35l41",
.pm = &cs35l41_pm_ops, .pm = pm_ptr(&cs35l41_pm_ops),
.of_match_table = of_match_ptr(cs35l41_of_match), .of_match_table = of_match_ptr(cs35l41_of_match),
.acpi_match_table = ACPI_PTR(cs35l41_acpi_match), .acpi_match_table = ACPI_PTR(cs35l41_acpi_match),
}, },
......
...@@ -80,7 +80,7 @@ MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match); ...@@ -80,7 +80,7 @@ MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
static struct spi_driver cs35l41_spi_driver = { static struct spi_driver cs35l41_spi_driver = {
.driver = { .driver = {
.name = "cs35l41", .name = "cs35l41",
.pm = &cs35l41_pm_ops, .pm = pm_ptr(&cs35l41_pm_ops),
.of_match_table = of_match_ptr(cs35l41_of_match), .of_match_table = of_match_ptr(cs35l41_of_match),
.acpi_match_table = ACPI_PTR(cs35l41_acpi_match), .acpi_match_table = ACPI_PTR(cs35l41_acpi_match),
}, },
......
...@@ -1368,7 +1368,7 @@ void cs35l41_remove(struct cs35l41_private *cs35l41) ...@@ -1368,7 +1368,7 @@ void cs35l41_remove(struct cs35l41_private *cs35l41)
} }
EXPORT_SYMBOL_GPL(cs35l41_remove); EXPORT_SYMBOL_GPL(cs35l41_remove);
static int __maybe_unused cs35l41_runtime_suspend(struct device *dev) static int cs35l41_runtime_suspend(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
...@@ -1385,7 +1385,7 @@ static int __maybe_unused cs35l41_runtime_suspend(struct device *dev) ...@@ -1385,7 +1385,7 @@ static int __maybe_unused cs35l41_runtime_suspend(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused cs35l41_runtime_resume(struct device *dev) static int cs35l41_runtime_resume(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
int ret; int ret;
...@@ -1414,7 +1414,7 @@ static int __maybe_unused cs35l41_runtime_resume(struct device *dev) ...@@ -1414,7 +1414,7 @@ static int __maybe_unused cs35l41_runtime_resume(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused cs35l41_sys_suspend(struct device *dev) static int cs35l41_sys_suspend(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
...@@ -1424,7 +1424,7 @@ static int __maybe_unused cs35l41_sys_suspend(struct device *dev) ...@@ -1424,7 +1424,7 @@ static int __maybe_unused cs35l41_sys_suspend(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused cs35l41_sys_suspend_noirq(struct device *dev) static int cs35l41_sys_suspend_noirq(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
...@@ -1434,7 +1434,7 @@ static int __maybe_unused cs35l41_sys_suspend_noirq(struct device *dev) ...@@ -1434,7 +1434,7 @@ static int __maybe_unused cs35l41_sys_suspend_noirq(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused cs35l41_sys_resume_noirq(struct device *dev) static int cs35l41_sys_resume_noirq(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
...@@ -1444,7 +1444,7 @@ static int __maybe_unused cs35l41_sys_resume_noirq(struct device *dev) ...@@ -1444,7 +1444,7 @@ static int __maybe_unused cs35l41_sys_resume_noirq(struct device *dev)
return 0; return 0;
} }
static int __maybe_unused cs35l41_sys_resume(struct device *dev) static int cs35l41_sys_resume(struct device *dev)
{ {
struct cs35l41_private *cs35l41 = dev_get_drvdata(dev); struct cs35l41_private *cs35l41 = dev_get_drvdata(dev);
...@@ -1454,13 +1454,12 @@ static int __maybe_unused cs35l41_sys_resume(struct device *dev) ...@@ -1454,13 +1454,12 @@ static int __maybe_unused cs35l41_sys_resume(struct device *dev)
return 0; return 0;
} }
const struct dev_pm_ops cs35l41_pm_ops = { EXPORT_GPL_DEV_PM_OPS(cs35l41_pm_ops) = {
SET_RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume, NULL) RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume, NULL)
SET_SYSTEM_SLEEP_PM_OPS(cs35l41_sys_suspend, cs35l41_sys_resume) SYSTEM_SLEEP_PM_OPS(cs35l41_sys_suspend, cs35l41_sys_resume)
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(cs35l41_sys_suspend_noirq, cs35l41_sys_resume_noirq) NOIRQ_SYSTEM_SLEEP_PM_OPS(cs35l41_sys_suspend_noirq, cs35l41_sys_resume_noirq)
}; };
EXPORT_SYMBOL_GPL(cs35l41_pm_ops);
MODULE_DESCRIPTION("ASoC CS35L41 driver"); MODULE_DESCRIPTION("ASoC CS35L41 driver");
MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>"); MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment