Commit 612c6aa7 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe

block: change the hash used for looking up block devices

Adding the minor to the major creates tons of pointless conflicts. Just
use the dev_t itself, which is 32-bits and thus is guaranteed to fit
into ino_t.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent efdc41c8
...@@ -863,35 +863,12 @@ void __init bdev_cache_init(void) ...@@ -863,35 +863,12 @@ void __init bdev_cache_init(void)
blockdev_superblock = bd_mnt->mnt_sb; /* For writeback */ blockdev_superblock = bd_mnt->mnt_sb; /* For writeback */
} }
/*
* Most likely _very_ bad one - but then it's hardly critical for small
* /dev and can be fixed when somebody will need really large one.
* Keep in mind that it will be fed through icache hash function too.
*/
static inline unsigned long hash(dev_t dev)
{
return MAJOR(dev)+MINOR(dev);
}
static int bdev_test(struct inode *inode, void *data)
{
return BDEV_I(inode)->bdev.bd_dev == *(dev_t *)data;
}
static int bdev_set(struct inode *inode, void *data)
{
BDEV_I(inode)->bdev.bd_dev = *(dev_t *)data;
return 0;
}
static struct block_device *bdget(dev_t dev) static struct block_device *bdget(dev_t dev)
{ {
struct block_device *bdev; struct block_device *bdev;
struct inode *inode; struct inode *inode;
inode = iget5_locked(blockdev_superblock, hash(dev), inode = iget_locked(blockdev_superblock, dev);
bdev_test, bdev_set, &dev);
if (!inode) if (!inode)
return NULL; return NULL;
...@@ -903,6 +880,7 @@ static struct block_device *bdget(dev_t dev) ...@@ -903,6 +880,7 @@ static struct block_device *bdget(dev_t dev)
bdev->bd_super = NULL; bdev->bd_super = NULL;
bdev->bd_inode = inode; bdev->bd_inode = inode;
bdev->bd_part_count = 0; bdev->bd_part_count = 0;
bdev->bd_dev = dev;
inode->i_mode = S_IFBLK; inode->i_mode = S_IFBLK;
inode->i_rdev = dev; inode->i_rdev = dev;
inode->i_bdev = bdev; inode->i_bdev = bdev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment