Commit 61c59355 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set

_dev_ is being dereferenced before it is null checked, hence there
is a potential null pointer dereference.

Fix this by moving the pointer dereference after _dev_ has been null
checked.

Addresses-Coverity-ID: 1462020
Fixes: bb1b40c7 ("usbnet: ipheth: prevent TX queue timeouts when device not ready")
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 981542c5
...@@ -291,12 +291,15 @@ static void ipheth_sndbulk_callback(struct urb *urb) ...@@ -291,12 +291,15 @@ static void ipheth_sndbulk_callback(struct urb *urb)
static int ipheth_carrier_set(struct ipheth_device *dev) static int ipheth_carrier_set(struct ipheth_device *dev)
{ {
struct usb_device *udev = dev->udev; struct usb_device *udev;
int retval; int retval;
if (!dev) if (!dev)
return 0; return 0;
if (!dev->confirmed_pairing) if (!dev->confirmed_pairing)
return 0; return 0;
udev = dev->udev;
retval = usb_control_msg(udev, retval = usb_control_msg(udev,
usb_rcvctrlpipe(udev, IPHETH_CTRL_ENDP), usb_rcvctrlpipe(udev, IPHETH_CTRL_ENDP),
IPHETH_CMD_CARRIER_CHECK, /* request */ IPHETH_CMD_CARRIER_CHECK, /* request */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment