Commit 62ce7cd6 authored by Wei Yongjun's avatar Wei Yongjun Committed by Peter De Schrijver

clk: tegra: fix __clk_lookup() return value checks

In case of error, the function __clk_lookup() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarPeter De Schrijver <pdeschrijver@nvidia.com>
parent 8ba4b3b9
...@@ -1490,7 +1490,7 @@ struct clk *tegra_clk_register_pllxc(const char *name, const char *parent_name, ...@@ -1490,7 +1490,7 @@ struct clk *tegra_clk_register_pllxc(const char *name, const char *parent_name,
u32 val, val_iddq; u32 val, val_iddq;
parent = __clk_lookup(parent_name); parent = __clk_lookup(parent_name);
if (IS_ERR(parent)) { if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n", WARN(1, "parent clk %s of %s must be registered first\n",
name, parent_name); name, parent_name);
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
...@@ -1591,7 +1591,7 @@ struct clk *tegra_clk_register_pllm(const char *name, const char *parent_name, ...@@ -1591,7 +1591,7 @@ struct clk *tegra_clk_register_pllm(const char *name, const char *parent_name,
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
parent = __clk_lookup(parent_name); parent = __clk_lookup(parent_name);
if (IS_ERR(parent)) { if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n", WARN(1, "parent clk %s of %s must be registered first\n",
name, parent_name); name, parent_name);
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
...@@ -1632,7 +1632,7 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name, ...@@ -1632,7 +1632,7 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name,
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
parent = __clk_lookup(parent_name); parent = __clk_lookup(parent_name);
if (IS_ERR(parent)) { if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n", WARN(1, "parent clk %s of %s must be registered first\n",
name, parent_name); name, parent_name);
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
...@@ -1756,7 +1756,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name, ...@@ -1756,7 +1756,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name,
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
parent = __clk_lookup(parent_name); parent = __clk_lookup(parent_name);
if (IS_ERR(parent)) { if (!parent) {
WARN(1, "parent clk %s of %s must be registered first\n", WARN(1, "parent clk %s of %s must be registered first\n",
name, parent_name); name, parent_name);
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment