Commit 62f79f79 authored by Kim Phillips's avatar Kim Phillips Committed by Kleber Sacilotto de Souza

perf llvm-utils: Remove bashism from kernel include fetch script

BugLink: https://bugs.launchpad.net/bugs/1792377

[ Upstream commit f6432b9f ]

Like system(), popen() calls /bin/sh, which may/may not be bash.

Script when run on dash and encounters the line, yields:

 exit: Illegal number: -1

checkbashisms report on script content:

 possible bashism (exit|return with negative status code):
 exit -1

Remove the bashism and use the more portable non-zero failure
status code 1.
Signed-off-by: default avatarKim Phillips <kim.phillips@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan@linux.vnet.ibm.com>
Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20180629124652.8d0af7e2281fd3fd8262cacc@arm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 0f2e947e
...@@ -254,16 +254,16 @@ static const char *kinc_fetch_script = ...@@ -254,16 +254,16 @@ static const char *kinc_fetch_script =
"#!/usr/bin/env sh\n" "#!/usr/bin/env sh\n"
"if ! test -d \"$KBUILD_DIR\"\n" "if ! test -d \"$KBUILD_DIR\"\n"
"then\n" "then\n"
" exit -1\n" " exit 1\n"
"fi\n" "fi\n"
"if ! test -f \"$KBUILD_DIR/include/generated/autoconf.h\"\n" "if ! test -f \"$KBUILD_DIR/include/generated/autoconf.h\"\n"
"then\n" "then\n"
" exit -1\n" " exit 1\n"
"fi\n" "fi\n"
"TMPDIR=`mktemp -d`\n" "TMPDIR=`mktemp -d`\n"
"if test -z \"$TMPDIR\"\n" "if test -z \"$TMPDIR\"\n"
"then\n" "then\n"
" exit -1\n" " exit 1\n"
"fi\n" "fi\n"
"cat << EOF > $TMPDIR/Makefile\n" "cat << EOF > $TMPDIR/Makefile\n"
"obj-y := dummy.o\n" "obj-y := dummy.o\n"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment