Commit 63447646 authored by Loic Pallardy's avatar Loic Pallardy Committed by Bjorn Andersson

rpmsg: virtio_rpmsg_bus: fix channel creation

Since commit 4dffed5b ("rpmsg: Name rpmsg devices based on
channel id"), it is no more possible for a firmware to register twice
a service (on different endpoints). rpmsg_register_device function
is failing when calling device_add for the second time as second
device has the same name as first one already register.
It is because name is based only on service name and so is not more
unique. Previously name was unique thanks to the use of rpmsg_dev_index.

This patch adds destination and source endpoint numbers device name to
create an unique identifier.

Fixes: 4dffed5b ("rpmsg: Name rpmsg devices based on channel id")
Acked-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Signed-off-by: default avatarLoic Pallardy <loic.pallardy@st.com>
[bjorn: flipped name and address in device name]
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 7ce7d89f
...@@ -453,8 +453,8 @@ int rpmsg_register_device(struct rpmsg_device *rpdev) ...@@ -453,8 +453,8 @@ int rpmsg_register_device(struct rpmsg_device *rpdev)
struct device *dev = &rpdev->dev; struct device *dev = &rpdev->dev;
int ret; int ret;
dev_set_name(&rpdev->dev, "%s:%s", dev_set_name(&rpdev->dev, "%s.%s.%d.%d", dev_name(dev->parent),
dev_name(dev->parent), rpdev->id.name); rpdev->id.name, rpdev->src, rpdev->dst);
rpdev->dev.bus = &rpmsg_bus; rpdev->dev.bus = &rpmsg_bus;
rpdev->dev.release = rpmsg_release_device; rpdev->dev.release = rpmsg_release_device;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment