Commit 63b2af49 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

staging: axis-fifo: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230403154014.2564054-2-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a8a9e952
...@@ -916,15 +916,13 @@ static int axis_fifo_probe(struct platform_device *pdev) ...@@ -916,15 +916,13 @@ static int axis_fifo_probe(struct platform_device *pdev)
return rc; return rc;
} }
static int axis_fifo_remove(struct platform_device *pdev) static void axis_fifo_remove(struct platform_device *pdev)
{ {
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct axis_fifo *fifo = dev_get_drvdata(dev); struct axis_fifo *fifo = dev_get_drvdata(dev);
misc_deregister(&fifo->miscdev); misc_deregister(&fifo->miscdev);
dev_set_drvdata(dev, NULL); dev_set_drvdata(dev, NULL);
return 0;
} }
static const struct of_device_id axis_fifo_of_match[] = { static const struct of_device_id axis_fifo_of_match[] = {
...@@ -939,7 +937,7 @@ static struct platform_driver axis_fifo_driver = { ...@@ -939,7 +937,7 @@ static struct platform_driver axis_fifo_driver = {
.of_match_table = axis_fifo_of_match, .of_match_table = axis_fifo_of_match,
}, },
.probe = axis_fifo_probe, .probe = axis_fifo_probe,
.remove = axis_fifo_remove, .remove_new = axis_fifo_remove,
}; };
static int __init axis_fifo_init(void) static int __init axis_fifo_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment