Commit 64721094 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net: phy: Fix return value check in xgmiitorgmii_probe()

In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: default avatarWei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cfaace26
...@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev) ...@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
return -ENOMEM; return -ENOMEM;
phy_node = of_parse_phandle(np, "phy-handle", 0); phy_node = of_parse_phandle(np, "phy-handle", 0);
if (IS_ERR(phy_node)) { if (!phy_node) {
dev_err(dev, "Couldn't parse phy-handle\n"); dev_err(dev, "Couldn't parse phy-handle\n");
return -ENODEV; return -ENODEV;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment