Commit 64fc973d authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by David S. Miller

net: ethernet: mscc: ocelot_board: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in two places.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3cd6e20f
...@@ -291,8 +291,10 @@ static int mscc_ocelot_probe(struct platform_device *pdev) ...@@ -291,8 +291,10 @@ static int mscc_ocelot_probe(struct platform_device *pdev)
continue; continue;
err = ocelot_probe_port(ocelot, port, regs, phy); err = ocelot_probe_port(ocelot, port, regs, phy);
if (err) if (err) {
of_node_put(portnp);
return err; return err;
}
phy_mode = of_get_phy_mode(portnp); phy_mode = of_get_phy_mode(portnp);
if (phy_mode < 0) if (phy_mode < 0)
...@@ -318,6 +320,7 @@ static int mscc_ocelot_probe(struct platform_device *pdev) ...@@ -318,6 +320,7 @@ static int mscc_ocelot_probe(struct platform_device *pdev)
dev_err(ocelot->dev, dev_err(ocelot->dev,
"invalid phy mode for port%d, (Q)SGMII only\n", "invalid phy mode for port%d, (Q)SGMII only\n",
port); port);
of_node_put(portnp);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment