Commit 651e7d48 authored by Lucas De Marchi's avatar Lucas De Marchi

drm/i915: replace IS_GEN and friends with GRAPHICS_VER

This was done by the following semantic patch:

	@@ expression i915; @@
	- INTEL_GEN(i915)
	+ GRAPHICS_VER(i915)

	@@ expression i915; expression E; @@
	- INTEL_GEN(i915) >= E
	+ GRAPHICS_VER(i915) >= E

	@@ expression dev_priv; expression E; @@
	- !IS_GEN(dev_priv, E)
	+ GRAPHICS_VER(dev_priv) != E

	@@ expression dev_priv; expression E; @@
	- IS_GEN(dev_priv, E)
	+ GRAPHICS_VER(dev_priv) == E

	@@
	expression dev_priv;
	expression from, until;
	@@
	- IS_GEN_RANGE(dev_priv, from, until)
	+ IS_GRAPHICS_VER(dev_priv, from, until)

	@def@
	expression E;
	identifier id =~ "^gen$";
	@@
	- id = GRAPHICS_VER(E)
	+ ver = GRAPHICS_VER(E)

	@@
	identifier def.id;
	@@
	- id
	+ ver

It also takes care of renaming the variable we assign to GRAPHICS_VER()
so to use "ver" rather than "gen".
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210606045050.103862-2-lucas.demarchi@intel.com
parent 07960a4c
...@@ -946,8 +946,8 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine) ...@@ -946,8 +946,8 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine)
int cmd_table_count; int cmd_table_count;
int ret; int ret;
if (!IS_GEN(engine->i915, 7) && !(IS_GEN(engine->i915, 9) && if (GRAPHICS_VER(engine->i915) != 7 && !(GRAPHICS_VER(engine->i915) == 9 &&
engine->class == COPY_ENGINE_CLASS)) engine->class == COPY_ENGINE_CLASS))
return 0; return 0;
switch (engine->class) { switch (engine->class) {
...@@ -977,7 +977,7 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine) ...@@ -977,7 +977,7 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine)
break; break;
case COPY_ENGINE_CLASS: case COPY_ENGINE_CLASS:
engine->get_cmd_length_mask = gen7_blt_get_cmd_length_mask; engine->get_cmd_length_mask = gen7_blt_get_cmd_length_mask;
if (IS_GEN(engine->i915, 9)) { if (GRAPHICS_VER(engine->i915) == 9) {
cmd_tables = gen9_blt_cmd_table; cmd_tables = gen9_blt_cmd_table;
cmd_table_count = ARRAY_SIZE(gen9_blt_cmd_table); cmd_table_count = ARRAY_SIZE(gen9_blt_cmd_table);
engine->get_cmd_length_mask = engine->get_cmd_length_mask =
...@@ -993,7 +993,7 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine) ...@@ -993,7 +993,7 @@ int intel_engine_init_cmd_parser(struct intel_engine_cs *engine)
cmd_table_count = ARRAY_SIZE(gen7_blt_cmd_table); cmd_table_count = ARRAY_SIZE(gen7_blt_cmd_table);
} }
if (IS_GEN(engine->i915, 9)) { if (GRAPHICS_VER(engine->i915) == 9) {
engine->reg_tables = gen9_blt_reg_tables; engine->reg_tables = gen9_blt_reg_tables;
engine->reg_table_count = engine->reg_table_count =
ARRAY_SIZE(gen9_blt_reg_tables); ARRAY_SIZE(gen9_blt_reg_tables);
...@@ -1521,7 +1521,7 @@ int intel_engine_cmd_parser(struct intel_engine_cs *engine, ...@@ -1521,7 +1521,7 @@ int intel_engine_cmd_parser(struct intel_engine_cs *engine,
if (IS_HASWELL(engine->i915)) if (IS_HASWELL(engine->i915))
flags = MI_BATCH_NON_SECURE_HSW; flags = MI_BATCH_NON_SECURE_HSW;
GEM_BUG_ON(!IS_GEN_RANGE(engine->i915, 6, 7)); GEM_BUG_ON(!IS_GRAPHICS_VER(engine->i915, 6, 7));
__gen6_emit_bb_start(batch_end, __gen6_emit_bb_start(batch_end,
batch_addr, batch_addr,
flags); flags);
......
...@@ -361,7 +361,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -361,7 +361,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm); wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
if (IS_GEN(dev_priv, 5)) { if (GRAPHICS_VER(dev_priv) == 5) {
u16 rgvswctl = intel_uncore_read16(uncore, MEMSWCTL); u16 rgvswctl = intel_uncore_read16(uncore, MEMSWCTL);
u16 rgvstat = intel_uncore_read16(uncore, MEMSTAT_ILK); u16 rgvstat = intel_uncore_read16(uncore, MEMSTAT_ILK);
...@@ -408,7 +408,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -408,7 +408,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
seq_printf(m, seq_printf(m,
"efficient (RPe) frequency: %d MHz\n", "efficient (RPe) frequency: %d MHz\n",
intel_gpu_freq(rps, rps->efficient_freq)); intel_gpu_freq(rps, rps->efficient_freq));
} else if (INTEL_GEN(dev_priv) >= 6) { } else if (GRAPHICS_VER(dev_priv) >= 6) {
u32 rp_state_limits; u32 rp_state_limits;
u32 gt_perf_status; u32 gt_perf_status;
u32 rp_state_cap; u32 rp_state_cap;
...@@ -432,7 +432,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -432,7 +432,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
intel_uncore_forcewake_get(&dev_priv->uncore, FORCEWAKE_ALL); intel_uncore_forcewake_get(&dev_priv->uncore, FORCEWAKE_ALL);
reqf = intel_uncore_read(&dev_priv->uncore, GEN6_RPNSWREQ); reqf = intel_uncore_read(&dev_priv->uncore, GEN6_RPNSWREQ);
if (INTEL_GEN(dev_priv) >= 9) if (GRAPHICS_VER(dev_priv) >= 9)
reqf >>= 23; reqf >>= 23;
else { else {
reqf &= ~GEN6_TURBO_DISABLE; reqf &= ~GEN6_TURBO_DISABLE;
...@@ -458,7 +458,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -458,7 +458,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
intel_uncore_forcewake_put(&dev_priv->uncore, FORCEWAKE_ALL); intel_uncore_forcewake_put(&dev_priv->uncore, FORCEWAKE_ALL);
if (INTEL_GEN(dev_priv) >= 11) { if (GRAPHICS_VER(dev_priv) >= 11) {
pm_ier = intel_uncore_read(&dev_priv->uncore, GEN11_GPM_WGBOXPERF_INTR_ENABLE); pm_ier = intel_uncore_read(&dev_priv->uncore, GEN11_GPM_WGBOXPERF_INTR_ENABLE);
pm_imr = intel_uncore_read(&dev_priv->uncore, GEN11_GPM_WGBOXPERF_INTR_MASK); pm_imr = intel_uncore_read(&dev_priv->uncore, GEN11_GPM_WGBOXPERF_INTR_MASK);
/* /*
...@@ -467,7 +467,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -467,7 +467,7 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
*/ */
pm_isr = 0; pm_isr = 0;
pm_iir = 0; pm_iir = 0;
} else if (INTEL_GEN(dev_priv) >= 8) { } else if (GRAPHICS_VER(dev_priv) >= 8) {
pm_ier = intel_uncore_read(&dev_priv->uncore, GEN8_GT_IER(2)); pm_ier = intel_uncore_read(&dev_priv->uncore, GEN8_GT_IER(2));
pm_imr = intel_uncore_read(&dev_priv->uncore, GEN8_GT_IMR(2)); pm_imr = intel_uncore_read(&dev_priv->uncore, GEN8_GT_IMR(2));
pm_isr = intel_uncore_read(&dev_priv->uncore, GEN8_GT_ISR(2)); pm_isr = intel_uncore_read(&dev_priv->uncore, GEN8_GT_ISR(2));
...@@ -490,14 +490,14 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -490,14 +490,14 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
seq_printf(m, "PM IER=0x%08x IMR=0x%08x, MASK=0x%08x\n", seq_printf(m, "PM IER=0x%08x IMR=0x%08x, MASK=0x%08x\n",
pm_ier, pm_imr, pm_mask); pm_ier, pm_imr, pm_mask);
if (INTEL_GEN(dev_priv) <= 10) if (GRAPHICS_VER(dev_priv) <= 10)
seq_printf(m, "PM ISR=0x%08x IIR=0x%08x\n", seq_printf(m, "PM ISR=0x%08x IIR=0x%08x\n",
pm_isr, pm_iir); pm_isr, pm_iir);
seq_printf(m, "pm_intrmsk_mbz: 0x%08x\n", seq_printf(m, "pm_intrmsk_mbz: 0x%08x\n",
rps->pm_intrmsk_mbz); rps->pm_intrmsk_mbz);
seq_printf(m, "GT_PERF_STATUS: 0x%08x\n", gt_perf_status); seq_printf(m, "GT_PERF_STATUS: 0x%08x\n", gt_perf_status);
seq_printf(m, "Render p-state ratio: %d\n", seq_printf(m, "Render p-state ratio: %d\n",
(gt_perf_status & (INTEL_GEN(dev_priv) >= 9 ? 0x1ff00 : 0xff00)) >> 8); (gt_perf_status & (GRAPHICS_VER(dev_priv) >= 9 ? 0x1ff00 : 0xff00)) >> 8);
seq_printf(m, "Render p-state VID: %d\n", seq_printf(m, "Render p-state VID: %d\n",
gt_perf_status & 0xff); gt_perf_status & 0xff);
seq_printf(m, "Render p-state limit: %d\n", seq_printf(m, "Render p-state limit: %d\n",
...@@ -538,20 +538,20 @@ static int i915_frequency_info(struct seq_file *m, void *unused) ...@@ -538,20 +538,20 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
max_freq = (IS_GEN9_LP(dev_priv) ? rp_state_cap >> 0 : max_freq = (IS_GEN9_LP(dev_priv) ? rp_state_cap >> 0 :
rp_state_cap >> 16) & 0xff; rp_state_cap >> 16) & 0xff;
max_freq *= (IS_GEN9_BC(dev_priv) || max_freq *= (IS_GEN9_BC(dev_priv) ||
INTEL_GEN(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1); GRAPHICS_VER(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1);
seq_printf(m, "Lowest (RPN) frequency: %dMHz\n", seq_printf(m, "Lowest (RPN) frequency: %dMHz\n",
intel_gpu_freq(rps, max_freq)); intel_gpu_freq(rps, max_freq));
max_freq = (rp_state_cap & 0xff00) >> 8; max_freq = (rp_state_cap & 0xff00) >> 8;
max_freq *= (IS_GEN9_BC(dev_priv) || max_freq *= (IS_GEN9_BC(dev_priv) ||
INTEL_GEN(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1); GRAPHICS_VER(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1);
seq_printf(m, "Nominal (RP1) frequency: %dMHz\n", seq_printf(m, "Nominal (RP1) frequency: %dMHz\n",
intel_gpu_freq(rps, max_freq)); intel_gpu_freq(rps, max_freq));
max_freq = (IS_GEN9_LP(dev_priv) ? rp_state_cap >> 16 : max_freq = (IS_GEN9_LP(dev_priv) ? rp_state_cap >> 16 :
rp_state_cap >> 0) & 0xff; rp_state_cap >> 0) & 0xff;
max_freq *= (IS_GEN9_BC(dev_priv) || max_freq *= (IS_GEN9_BC(dev_priv) ||
INTEL_GEN(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1); GRAPHICS_VER(dev_priv) >= 10 ? GEN9_FREQ_SCALER : 1);
seq_printf(m, "Max non-overclocked (RP0) frequency: %dMHz\n", seq_printf(m, "Max non-overclocked (RP0) frequency: %dMHz\n",
intel_gpu_freq(rps, max_freq)); intel_gpu_freq(rps, max_freq));
seq_printf(m, "Max overclocked frequency: %dMHz\n", seq_printf(m, "Max overclocked frequency: %dMHz\n",
...@@ -622,12 +622,12 @@ static int i915_swizzle_info(struct seq_file *m, void *data) ...@@ -622,12 +622,12 @@ static int i915_swizzle_info(struct seq_file *m, void *data)
seq_puts(m, "L-shaped memory detected\n"); seq_puts(m, "L-shaped memory detected\n");
/* On BDW+, swizzling is not used. See detect_bit_6_swizzle() */ /* On BDW+, swizzling is not used. See detect_bit_6_swizzle() */
if (INTEL_GEN(dev_priv) >= 8 || IS_VALLEYVIEW(dev_priv)) if (GRAPHICS_VER(dev_priv) >= 8 || IS_VALLEYVIEW(dev_priv))
return 0; return 0;
wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm); wakeref = intel_runtime_pm_get(&dev_priv->runtime_pm);
if (IS_GEN_RANGE(dev_priv, 3, 4)) { if (IS_GRAPHICS_VER(dev_priv, 3, 4)) {
seq_printf(m, "DDC = 0x%08x\n", seq_printf(m, "DDC = 0x%08x\n",
intel_uncore_read(uncore, DCC)); intel_uncore_read(uncore, DCC));
seq_printf(m, "DDC2 = 0x%08x\n", seq_printf(m, "DDC2 = 0x%08x\n",
...@@ -645,7 +645,7 @@ static int i915_swizzle_info(struct seq_file *m, void *data) ...@@ -645,7 +645,7 @@ static int i915_swizzle_info(struct seq_file *m, void *data)
intel_uncore_read(uncore, MAD_DIMM_C2)); intel_uncore_read(uncore, MAD_DIMM_C2));
seq_printf(m, "TILECTL = 0x%08x\n", seq_printf(m, "TILECTL = 0x%08x\n",
intel_uncore_read(uncore, TILECTL)); intel_uncore_read(uncore, TILECTL));
if (INTEL_GEN(dev_priv) >= 8) if (GRAPHICS_VER(dev_priv) >= 8)
seq_printf(m, "GAMTARBMODE = 0x%08x\n", seq_printf(m, "GAMTARBMODE = 0x%08x\n",
intel_uncore_read(uncore, GAMTARBMODE)); intel_uncore_read(uncore, GAMTARBMODE));
else else
...@@ -956,7 +956,7 @@ static int i915_forcewake_open(struct inode *inode, struct file *file) ...@@ -956,7 +956,7 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
atomic_inc(&gt->user_wakeref); atomic_inc(&gt->user_wakeref);
intel_gt_pm_get(gt); intel_gt_pm_get(gt);
if (INTEL_GEN(i915) >= 6) if (GRAPHICS_VER(i915) >= 6)
intel_uncore_forcewake_user_get(gt->uncore); intel_uncore_forcewake_user_get(gt->uncore);
return 0; return 0;
...@@ -967,7 +967,7 @@ static int i915_forcewake_release(struct inode *inode, struct file *file) ...@@ -967,7 +967,7 @@ static int i915_forcewake_release(struct inode *inode, struct file *file)
struct drm_i915_private *i915 = inode->i_private; struct drm_i915_private *i915 = inode->i_private;
struct intel_gt *gt = &i915->gt; struct intel_gt *gt = &i915->gt;
if (INTEL_GEN(i915) >= 6) if (GRAPHICS_VER(i915) >= 6)
intel_uncore_forcewake_user_put(&i915->uncore); intel_uncore_forcewake_user_put(&i915->uncore);
intel_gt_pm_put(gt); intel_gt_pm_put(gt);
atomic_dec(&gt->user_wakeref); atomic_dec(&gt->user_wakeref);
......
...@@ -106,12 +106,12 @@ static int i915_get_bridge_dev(struct drm_i915_private *dev_priv) ...@@ -106,12 +106,12 @@ static int i915_get_bridge_dev(struct drm_i915_private *dev_priv)
static int static int
intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv) intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)
{ {
int reg = INTEL_GEN(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915; int reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
u32 temp_lo, temp_hi = 0; u32 temp_lo, temp_hi = 0;
u64 mchbar_addr; u64 mchbar_addr;
int ret; int ret;
if (INTEL_GEN(dev_priv) >= 4) if (GRAPHICS_VER(dev_priv) >= 4)
pci_read_config_dword(dev_priv->bridge_dev, reg + 4, &temp_hi); pci_read_config_dword(dev_priv->bridge_dev, reg + 4, &temp_hi);
pci_read_config_dword(dev_priv->bridge_dev, reg, &temp_lo); pci_read_config_dword(dev_priv->bridge_dev, reg, &temp_lo);
mchbar_addr = ((u64)temp_hi << 32) | temp_lo; mchbar_addr = ((u64)temp_hi << 32) | temp_lo;
...@@ -138,7 +138,7 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv) ...@@ -138,7 +138,7 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)
return ret; return ret;
} }
if (INTEL_GEN(dev_priv) >= 4) if (GRAPHICS_VER(dev_priv) >= 4)
pci_write_config_dword(dev_priv->bridge_dev, reg + 4, pci_write_config_dword(dev_priv->bridge_dev, reg + 4,
upper_32_bits(dev_priv->mch_res.start)); upper_32_bits(dev_priv->mch_res.start));
...@@ -151,7 +151,7 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv) ...@@ -151,7 +151,7 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)
static void static void
intel_setup_mchbar(struct drm_i915_private *dev_priv) intel_setup_mchbar(struct drm_i915_private *dev_priv)
{ {
int mchbar_reg = INTEL_GEN(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915; int mchbar_reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
u32 temp; u32 temp;
bool enabled; bool enabled;
...@@ -190,7 +190,7 @@ intel_setup_mchbar(struct drm_i915_private *dev_priv) ...@@ -190,7 +190,7 @@ intel_setup_mchbar(struct drm_i915_private *dev_priv)
static void static void
intel_teardown_mchbar(struct drm_i915_private *dev_priv) intel_teardown_mchbar(struct drm_i915_private *dev_priv)
{ {
int mchbar_reg = INTEL_GEN(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915; int mchbar_reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915;
if (dev_priv->mchbar_need_disable) { if (dev_priv->mchbar_need_disable) {
if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) { if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) {
...@@ -475,7 +475,7 @@ static int i915_set_dma_info(struct drm_i915_private *i915) ...@@ -475,7 +475,7 @@ static int i915_set_dma_info(struct drm_i915_private *i915)
goto mask_err; goto mask_err;
/* overlay on gen2 is broken and can't address above 1G */ /* overlay on gen2 is broken and can't address above 1G */
if (IS_GEN(i915, 2)) if (GRAPHICS_VER(i915) == 2)
mask_size = 30; mask_size = 30;
/* /*
...@@ -601,7 +601,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) ...@@ -601,7 +601,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)
* device. The kernel then disables that interrupt source and so * device. The kernel then disables that interrupt source and so
* prevents the other device from working properly. * prevents the other device from working properly.
*/ */
if (INTEL_GEN(dev_priv) >= 5) { if (GRAPHICS_VER(dev_priv) >= 5) {
if (pci_enable_msi(pdev) < 0) if (pci_enable_msi(pdev) < 0)
drm_dbg(&dev_priv->drm, "can't enable MSI"); drm_dbg(&dev_priv->drm, "can't enable MSI");
} }
...@@ -729,7 +729,7 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv) ...@@ -729,7 +729,7 @@ static void i915_welcome_messages(struct drm_i915_private *dev_priv)
intel_platform_name(INTEL_INFO(dev_priv)->platform), intel_platform_name(INTEL_INFO(dev_priv)->platform),
intel_subplatform(RUNTIME_INFO(dev_priv), intel_subplatform(RUNTIME_INFO(dev_priv),
INTEL_INFO(dev_priv)->platform), INTEL_INFO(dev_priv)->platform),
INTEL_GEN(dev_priv)); GRAPHICS_VER(dev_priv));
intel_device_info_print_static(INTEL_INFO(dev_priv), &p); intel_device_info_print_static(INTEL_INFO(dev_priv), &p);
intel_device_info_print_runtime(RUNTIME_INFO(dev_priv), &p); intel_device_info_print_runtime(RUNTIME_INFO(dev_priv), &p);
...@@ -803,7 +803,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -803,7 +803,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
*/ */
#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM)) { if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM)) {
if (INTEL_GEN(i915) >= 9 && i915_selftest.live < 0 && if (GRAPHICS_VER(i915) >= 9 && i915_selftest.live < 0 &&
i915->params.fake_lmem_start) { i915->params.fake_lmem_start) {
mkwrite_device_info(i915)->memory_regions = mkwrite_device_info(i915)->memory_regions =
REGION_SMEM | REGION_LMEM | REGION_STOLEN_SMEM; REGION_SMEM | REGION_LMEM | REGION_STOLEN_SMEM;
...@@ -1182,7 +1182,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation) ...@@ -1182,7 +1182,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
* Fujitsu FSC S7110 * Fujitsu FSC S7110
* Acer Aspire 1830T * Acer Aspire 1830T
*/ */
if (!(hibernation && INTEL_GEN(dev_priv) < 6)) if (!(hibernation && GRAPHICS_VER(dev_priv) < 6))
pci_set_power_state(pdev, PCI_D3hot); pci_set_power_state(pdev, PCI_D3hot);
out: out:
......
...@@ -432,7 +432,7 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data, ...@@ -432,7 +432,7 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
/* PREAD is disallowed for all platforms after TGL-LP. This also /* PREAD is disallowed for all platforms after TGL-LP. This also
* covers all platforms with local memory. * covers all platforms with local memory.
*/ */
if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915)) if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915))
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (args->size == 0) if (args->size == 0)
...@@ -712,7 +712,7 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data, ...@@ -712,7 +712,7 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
/* PWRITE is disallowed for all platforms after TGL-LP. This also /* PWRITE is disallowed for all platforms after TGL-LP. This also
* covers all platforms with local memory. * covers all platforms with local memory.
*/ */
if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915)) if (GRAPHICS_VER(i915) >= 12 && !IS_TIGERLAKE(i915))
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (args->size == 0) if (args->size == 0)
......
...@@ -435,13 +435,13 @@ static void error_print_instdone(struct drm_i915_error_state_buf *m, ...@@ -435,13 +435,13 @@ static void error_print_instdone(struct drm_i915_error_state_buf *m,
err_printf(m, " INSTDONE: 0x%08x\n", err_printf(m, " INSTDONE: 0x%08x\n",
ee->instdone.instdone); ee->instdone.instdone);
if (ee->engine->class != RENDER_CLASS || INTEL_GEN(m->i915) <= 3) if (ee->engine->class != RENDER_CLASS || GRAPHICS_VER(m->i915) <= 3)
return; return;
err_printf(m, " SC_INSTDONE: 0x%08x\n", err_printf(m, " SC_INSTDONE: 0x%08x\n",
ee->instdone.slice_common); ee->instdone.slice_common);
if (INTEL_GEN(m->i915) <= 6) if (GRAPHICS_VER(m->i915) <= 6)
return; return;
for_each_instdone_slice_subslice(m->i915, sseu, slice, subslice) for_each_instdone_slice_subslice(m->i915, sseu, slice, subslice)
...@@ -454,7 +454,7 @@ static void error_print_instdone(struct drm_i915_error_state_buf *m, ...@@ -454,7 +454,7 @@ static void error_print_instdone(struct drm_i915_error_state_buf *m,
slice, subslice, slice, subslice,
ee->instdone.row[slice][subslice]); ee->instdone.row[slice][subslice]);
if (INTEL_GEN(m->i915) < 12) if (GRAPHICS_VER(m->i915) < 12)
return; return;
err_printf(m, " SC_INSTDONE_EXTRA: 0x%08x\n", err_printf(m, " SC_INSTDONE_EXTRA: 0x%08x\n",
...@@ -543,7 +543,7 @@ static void error_print_engine(struct drm_i915_error_state_buf *m, ...@@ -543,7 +543,7 @@ static void error_print_engine(struct drm_i915_error_state_buf *m,
upper_32_bits(start), lower_32_bits(start), upper_32_bits(start), lower_32_bits(start),
upper_32_bits(end), lower_32_bits(end)); upper_32_bits(end), lower_32_bits(end));
} }
if (INTEL_GEN(m->i915) >= 4) { if (GRAPHICS_VER(m->i915) >= 4) {
err_printf(m, " BBADDR: 0x%08x_%08x\n", err_printf(m, " BBADDR: 0x%08x_%08x\n",
(u32)(ee->bbaddr>>32), (u32)ee->bbaddr); (u32)(ee->bbaddr>>32), (u32)ee->bbaddr);
err_printf(m, " BB_STATE: 0x%08x\n", ee->bbstate); err_printf(m, " BB_STATE: 0x%08x\n", ee->bbstate);
...@@ -552,14 +552,14 @@ static void error_print_engine(struct drm_i915_error_state_buf *m, ...@@ -552,14 +552,14 @@ static void error_print_engine(struct drm_i915_error_state_buf *m,
err_printf(m, " INSTPM: 0x%08x\n", ee->instpm); err_printf(m, " INSTPM: 0x%08x\n", ee->instpm);
err_printf(m, " FADDR: 0x%08x %08x\n", upper_32_bits(ee->faddr), err_printf(m, " FADDR: 0x%08x %08x\n", upper_32_bits(ee->faddr),
lower_32_bits(ee->faddr)); lower_32_bits(ee->faddr));
if (INTEL_GEN(m->i915) >= 6) { if (GRAPHICS_VER(m->i915) >= 6) {
err_printf(m, " RC PSMI: 0x%08x\n", ee->rc_psmi); err_printf(m, " RC PSMI: 0x%08x\n", ee->rc_psmi);
err_printf(m, " FAULT_REG: 0x%08x\n", ee->fault_reg); err_printf(m, " FAULT_REG: 0x%08x\n", ee->fault_reg);
} }
if (HAS_PPGTT(m->i915)) { if (HAS_PPGTT(m->i915)) {
err_printf(m, " GFX_MODE: 0x%08x\n", ee->vm_info.gfx_mode); err_printf(m, " GFX_MODE: 0x%08x\n", ee->vm_info.gfx_mode);
if (INTEL_GEN(m->i915) >= 8) { if (GRAPHICS_VER(m->i915) >= 8) {
int i; int i;
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
err_printf(m, " PDP%d: 0x%016llx\n", err_printf(m, " PDP%d: 0x%016llx\n",
...@@ -706,25 +706,25 @@ static void err_print_gt(struct drm_i915_error_state_buf *m, ...@@ -706,25 +706,25 @@ static void err_print_gt(struct drm_i915_error_state_buf *m,
for (i = 0; i < gt->nfence; i++) for (i = 0; i < gt->nfence; i++)
err_printf(m, " fence[%d] = %08llx\n", i, gt->fence[i]); err_printf(m, " fence[%d] = %08llx\n", i, gt->fence[i]);
if (IS_GEN_RANGE(m->i915, 6, 11)) { if (IS_GRAPHICS_VER(m->i915, 6, 11)) {
err_printf(m, "ERROR: 0x%08x\n", gt->error); err_printf(m, "ERROR: 0x%08x\n", gt->error);
err_printf(m, "DONE_REG: 0x%08x\n", gt->done_reg); err_printf(m, "DONE_REG: 0x%08x\n", gt->done_reg);
} }
if (INTEL_GEN(m->i915) >= 8) if (GRAPHICS_VER(m->i915) >= 8)
err_printf(m, "FAULT_TLB_DATA: 0x%08x 0x%08x\n", err_printf(m, "FAULT_TLB_DATA: 0x%08x 0x%08x\n",
gt->fault_data1, gt->fault_data0); gt->fault_data1, gt->fault_data0);
if (IS_GEN(m->i915, 7)) if (GRAPHICS_VER(m->i915) == 7)
err_printf(m, "ERR_INT: 0x%08x\n", gt->err_int); err_printf(m, "ERR_INT: 0x%08x\n", gt->err_int);
if (IS_GEN_RANGE(m->i915, 8, 11)) if (IS_GRAPHICS_VER(m->i915, 8, 11))
err_printf(m, "GTT_CACHE_EN: 0x%08x\n", gt->gtt_cache); err_printf(m, "GTT_CACHE_EN: 0x%08x\n", gt->gtt_cache);
if (IS_GEN(m->i915, 12)) if (GRAPHICS_VER(m->i915) == 12)
err_printf(m, "AUX_ERR_DBG: 0x%08x\n", gt->aux_err); err_printf(m, "AUX_ERR_DBG: 0x%08x\n", gt->aux_err);
if (INTEL_GEN(m->i915) >= 12) { if (GRAPHICS_VER(m->i915) >= 12) {
int i; int i;
for (i = 0; i < GEN12_SFC_DONE_MAX; i++) for (i = 0; i < GEN12_SFC_DONE_MAX; i++)
...@@ -1092,12 +1092,12 @@ static void gt_record_fences(struct intel_gt_coredump *gt) ...@@ -1092,12 +1092,12 @@ static void gt_record_fences(struct intel_gt_coredump *gt)
struct intel_uncore *uncore = gt->_gt->uncore; struct intel_uncore *uncore = gt->_gt->uncore;
int i; int i;
if (INTEL_GEN(uncore->i915) >= 6) { if (GRAPHICS_VER(uncore->i915) >= 6) {
for (i = 0; i < ggtt->num_fences; i++) for (i = 0; i < ggtt->num_fences; i++)
gt->fence[i] = gt->fence[i] =
intel_uncore_read64(uncore, intel_uncore_read64(uncore,
FENCE_REG_GEN6_LO(i)); FENCE_REG_GEN6_LO(i));
} else if (INTEL_GEN(uncore->i915) >= 4) { } else if (GRAPHICS_VER(uncore->i915) >= 4) {
for (i = 0; i < ggtt->num_fences; i++) for (i = 0; i < ggtt->num_fences; i++)
gt->fence[i] = gt->fence[i] =
intel_uncore_read64(uncore, intel_uncore_read64(uncore,
...@@ -1115,20 +1115,20 @@ static void engine_record_registers(struct intel_engine_coredump *ee) ...@@ -1115,20 +1115,20 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
const struct intel_engine_cs *engine = ee->engine; const struct intel_engine_cs *engine = ee->engine;
struct drm_i915_private *i915 = engine->i915; struct drm_i915_private *i915 = engine->i915;
if (INTEL_GEN(i915) >= 6) { if (GRAPHICS_VER(i915) >= 6) {
ee->rc_psmi = ENGINE_READ(engine, RING_PSMI_CTL); ee->rc_psmi = ENGINE_READ(engine, RING_PSMI_CTL);
if (INTEL_GEN(i915) >= 12) if (GRAPHICS_VER(i915) >= 12)
ee->fault_reg = intel_uncore_read(engine->uncore, ee->fault_reg = intel_uncore_read(engine->uncore,
GEN12_RING_FAULT_REG); GEN12_RING_FAULT_REG);
else if (INTEL_GEN(i915) >= 8) else if (GRAPHICS_VER(i915) >= 8)
ee->fault_reg = intel_uncore_read(engine->uncore, ee->fault_reg = intel_uncore_read(engine->uncore,
GEN8_RING_FAULT_REG); GEN8_RING_FAULT_REG);
else else
ee->fault_reg = GEN6_RING_FAULT_REG_READ(engine); ee->fault_reg = GEN6_RING_FAULT_REG_READ(engine);
} }
if (INTEL_GEN(i915) >= 4) { if (GRAPHICS_VER(i915) >= 4) {
ee->esr = ENGINE_READ(engine, RING_ESR); ee->esr = ENGINE_READ(engine, RING_ESR);
ee->faddr = ENGINE_READ(engine, RING_DMA_FADD); ee->faddr = ENGINE_READ(engine, RING_DMA_FADD);
ee->ipeir = ENGINE_READ(engine, RING_IPEIR); ee->ipeir = ENGINE_READ(engine, RING_IPEIR);
...@@ -1136,7 +1136,7 @@ static void engine_record_registers(struct intel_engine_coredump *ee) ...@@ -1136,7 +1136,7 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
ee->instps = ENGINE_READ(engine, RING_INSTPS); ee->instps = ENGINE_READ(engine, RING_INSTPS);
ee->bbaddr = ENGINE_READ(engine, RING_BBADDR); ee->bbaddr = ENGINE_READ(engine, RING_BBADDR);
ee->ccid = ENGINE_READ(engine, CCID); ee->ccid = ENGINE_READ(engine, CCID);
if (INTEL_GEN(i915) >= 8) { if (GRAPHICS_VER(i915) >= 8) {
ee->faddr |= (u64)ENGINE_READ(engine, RING_DMA_FADD_UDW) << 32; ee->faddr |= (u64)ENGINE_READ(engine, RING_DMA_FADD_UDW) << 32;
ee->bbaddr |= (u64)ENGINE_READ(engine, RING_BBADDR_UDW) << 32; ee->bbaddr |= (u64)ENGINE_READ(engine, RING_BBADDR_UDW) << 32;
} }
...@@ -1155,13 +1155,13 @@ static void engine_record_registers(struct intel_engine_coredump *ee) ...@@ -1155,13 +1155,13 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
ee->head = ENGINE_READ(engine, RING_HEAD); ee->head = ENGINE_READ(engine, RING_HEAD);
ee->tail = ENGINE_READ(engine, RING_TAIL); ee->tail = ENGINE_READ(engine, RING_TAIL);
ee->ctl = ENGINE_READ(engine, RING_CTL); ee->ctl = ENGINE_READ(engine, RING_CTL);
if (INTEL_GEN(i915) > 2) if (GRAPHICS_VER(i915) > 2)
ee->mode = ENGINE_READ(engine, RING_MI_MODE); ee->mode = ENGINE_READ(engine, RING_MI_MODE);
if (!HWS_NEEDS_PHYSICAL(i915)) { if (!HWS_NEEDS_PHYSICAL(i915)) {
i915_reg_t mmio; i915_reg_t mmio;
if (IS_GEN(i915, 7)) { if (GRAPHICS_VER(i915) == 7) {
switch (engine->id) { switch (engine->id) {
default: default:
MISSING_CASE(engine->id); MISSING_CASE(engine->id);
...@@ -1179,7 +1179,7 @@ static void engine_record_registers(struct intel_engine_coredump *ee) ...@@ -1179,7 +1179,7 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
mmio = VEBOX_HWS_PGA_GEN7; mmio = VEBOX_HWS_PGA_GEN7;
break; break;
} }
} else if (IS_GEN(engine->i915, 6)) { } else if (GRAPHICS_VER(engine->i915) == 6) {
mmio = RING_HWS_PGA_GEN6(engine->mmio_base); mmio = RING_HWS_PGA_GEN6(engine->mmio_base);
} else { } else {
/* XXX: gen8 returns to sanity */ /* XXX: gen8 returns to sanity */
...@@ -1196,13 +1196,13 @@ static void engine_record_registers(struct intel_engine_coredump *ee) ...@@ -1196,13 +1196,13 @@ static void engine_record_registers(struct intel_engine_coredump *ee)
ee->vm_info.gfx_mode = ENGINE_READ(engine, RING_MODE_GEN7); ee->vm_info.gfx_mode = ENGINE_READ(engine, RING_MODE_GEN7);
if (IS_GEN(i915, 6)) { if (GRAPHICS_VER(i915) == 6) {
ee->vm_info.pp_dir_base = ee->vm_info.pp_dir_base =
ENGINE_READ(engine, RING_PP_DIR_BASE_READ); ENGINE_READ(engine, RING_PP_DIR_BASE_READ);
} else if (IS_GEN(i915, 7)) { } else if (GRAPHICS_VER(i915) == 7) {
ee->vm_info.pp_dir_base = ee->vm_info.pp_dir_base =
ENGINE_READ(engine, RING_PP_DIR_BASE); ENGINE_READ(engine, RING_PP_DIR_BASE);
} else if (INTEL_GEN(i915) >= 8) { } else if (GRAPHICS_VER(i915) >= 8) {
u32 base = engine->mmio_base; u32 base = engine->mmio_base;
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
...@@ -1534,52 +1534,52 @@ static void gt_record_regs(struct intel_gt_coredump *gt) ...@@ -1534,52 +1534,52 @@ static void gt_record_regs(struct intel_gt_coredump *gt)
gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE_VLV); gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE_VLV);
} }
if (IS_GEN(i915, 7)) if (GRAPHICS_VER(i915) == 7)
gt->err_int = intel_uncore_read(uncore, GEN7_ERR_INT); gt->err_int = intel_uncore_read(uncore, GEN7_ERR_INT);
if (INTEL_GEN(i915) >= 12) { if (GRAPHICS_VER(i915) >= 12) {
gt->fault_data0 = intel_uncore_read(uncore, gt->fault_data0 = intel_uncore_read(uncore,
GEN12_FAULT_TLB_DATA0); GEN12_FAULT_TLB_DATA0);
gt->fault_data1 = intel_uncore_read(uncore, gt->fault_data1 = intel_uncore_read(uncore,
GEN12_FAULT_TLB_DATA1); GEN12_FAULT_TLB_DATA1);
} else if (INTEL_GEN(i915) >= 8) { } else if (GRAPHICS_VER(i915) >= 8) {
gt->fault_data0 = intel_uncore_read(uncore, gt->fault_data0 = intel_uncore_read(uncore,
GEN8_FAULT_TLB_DATA0); GEN8_FAULT_TLB_DATA0);
gt->fault_data1 = intel_uncore_read(uncore, gt->fault_data1 = intel_uncore_read(uncore,
GEN8_FAULT_TLB_DATA1); GEN8_FAULT_TLB_DATA1);
} }
if (IS_GEN(i915, 6)) { if (GRAPHICS_VER(i915) == 6) {
gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE); gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE);
gt->gab_ctl = intel_uncore_read(uncore, GAB_CTL); gt->gab_ctl = intel_uncore_read(uncore, GAB_CTL);
gt->gfx_mode = intel_uncore_read(uncore, GFX_MODE); gt->gfx_mode = intel_uncore_read(uncore, GFX_MODE);
} }
/* 2: Registers which belong to multiple generations */ /* 2: Registers which belong to multiple generations */
if (INTEL_GEN(i915) >= 7) if (GRAPHICS_VER(i915) >= 7)
gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE_MT); gt->forcewake = intel_uncore_read_fw(uncore, FORCEWAKE_MT);
if (INTEL_GEN(i915) >= 6) { if (GRAPHICS_VER(i915) >= 6) {
gt->derrmr = intel_uncore_read(uncore, DERRMR); gt->derrmr = intel_uncore_read(uncore, DERRMR);
if (INTEL_GEN(i915) < 12) { if (GRAPHICS_VER(i915) < 12) {
gt->error = intel_uncore_read(uncore, ERROR_GEN6); gt->error = intel_uncore_read(uncore, ERROR_GEN6);
gt->done_reg = intel_uncore_read(uncore, DONE_REG); gt->done_reg = intel_uncore_read(uncore, DONE_REG);
} }
} }
/* 3: Feature specific registers */ /* 3: Feature specific registers */
if (IS_GEN_RANGE(i915, 6, 7)) { if (IS_GRAPHICS_VER(i915, 6, 7)) {
gt->gam_ecochk = intel_uncore_read(uncore, GAM_ECOCHK); gt->gam_ecochk = intel_uncore_read(uncore, GAM_ECOCHK);
gt->gac_eco = intel_uncore_read(uncore, GAC_ECO_BITS); gt->gac_eco = intel_uncore_read(uncore, GAC_ECO_BITS);
} }
if (IS_GEN_RANGE(i915, 8, 11)) if (IS_GRAPHICS_VER(i915, 8, 11))
gt->gtt_cache = intel_uncore_read(uncore, HSW_GTT_CACHE_EN); gt->gtt_cache = intel_uncore_read(uncore, HSW_GTT_CACHE_EN);
if (IS_GEN(i915, 12)) if (GRAPHICS_VER(i915) == 12)
gt->aux_err = intel_uncore_read(uncore, GEN12_AUX_ERR_DBG); gt->aux_err = intel_uncore_read(uncore, GEN12_AUX_ERR_DBG);
if (INTEL_GEN(i915) >= 12) { if (GRAPHICS_VER(i915) >= 12) {
for (i = 0; i < GEN12_SFC_DONE_MAX; i++) { for (i = 0; i < GEN12_SFC_DONE_MAX; i++) {
gt->sfc_done[i] = gt->sfc_done[i] =
intel_uncore_read(uncore, GEN12_SFC_DONE(i)); intel_uncore_read(uncore, GEN12_SFC_DONE(i));
...@@ -1589,7 +1589,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt) ...@@ -1589,7 +1589,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt)
} }
/* 4: Everything else */ /* 4: Everything else */
if (INTEL_GEN(i915) >= 11) { if (GRAPHICS_VER(i915) >= 11) {
gt->ier = intel_uncore_read(uncore, GEN8_DE_MISC_IER); gt->ier = intel_uncore_read(uncore, GEN8_DE_MISC_IER);
gt->gtier[0] = gt->gtier[0] =
intel_uncore_read(uncore, intel_uncore_read(uncore,
...@@ -1608,7 +1608,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt) ...@@ -1608,7 +1608,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt)
intel_uncore_read(uncore, intel_uncore_read(uncore,
GEN11_GUNIT_CSME_INTR_ENABLE); GEN11_GUNIT_CSME_INTR_ENABLE);
gt->ngtier = 6; gt->ngtier = 6;
} else if (INTEL_GEN(i915) >= 8) { } else if (GRAPHICS_VER(i915) >= 8) {
gt->ier = intel_uncore_read(uncore, GEN8_DE_MISC_IER); gt->ier = intel_uncore_read(uncore, GEN8_DE_MISC_IER);
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
gt->gtier[i] = gt->gtier[i] =
...@@ -1618,7 +1618,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt) ...@@ -1618,7 +1618,7 @@ static void gt_record_regs(struct intel_gt_coredump *gt)
gt->ier = intel_uncore_read(uncore, DEIER); gt->ier = intel_uncore_read(uncore, DEIER);
gt->gtier[0] = intel_uncore_read(uncore, GTIER); gt->gtier[0] = intel_uncore_read(uncore, GTIER);
gt->ngtier = 1; gt->ngtier = 1;
} else if (IS_GEN(i915, 2)) { } else if (GRAPHICS_VER(i915) == 2) {
gt->ier = intel_uncore_read16(uncore, GEN2_IER); gt->ier = intel_uncore_read16(uncore, GEN2_IER);
} else if (!IS_VALLEYVIEW(i915)) { } else if (!IS_VALLEYVIEW(i915)) {
gt->ier = intel_uncore_read(uncore, GEN2_IER); gt->ier = intel_uncore_read(uncore, GEN2_IER);
...@@ -1674,7 +1674,7 @@ static const char *error_msg(struct i915_gpu_coredump *error) ...@@ -1674,7 +1674,7 @@ static const char *error_msg(struct i915_gpu_coredump *error)
len = scnprintf(error->error_msg, sizeof(error->error_msg), len = scnprintf(error->error_msg, sizeof(error->error_msg),
"GPU HANG: ecode %d:%x:%08x", "GPU HANG: ecode %d:%x:%08x",
INTEL_GEN(error->i915), hung_classes, GRAPHICS_VER(error->i915), hung_classes,
generate_ecode(first)); generate_ecode(first));
if (first && first->context.pid) { if (first && first->context.pid) {
/* Just show the first executing process, more is confusing */ /* Just show the first executing process, more is confusing */
......
...@@ -2175,7 +2175,7 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg) ...@@ -2175,7 +2175,7 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg)
gt_iir = raw_reg_read(regs, GTIIR); gt_iir = raw_reg_read(regs, GTIIR);
if (gt_iir) { if (gt_iir) {
raw_reg_write(regs, GTIIR, gt_iir); raw_reg_write(regs, GTIIR, gt_iir);
if (INTEL_GEN(i915) >= 6) if (GRAPHICS_VER(i915) >= 6)
gen6_gt_irq_handler(&i915->gt, gt_iir); gen6_gt_irq_handler(&i915->gt, gt_iir);
else else
gen5_gt_irq_handler(&i915->gt, gt_iir); gen5_gt_irq_handler(&i915->gt, gt_iir);
...@@ -2192,7 +2192,7 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg) ...@@ -2192,7 +2192,7 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg)
ret = IRQ_HANDLED; ret = IRQ_HANDLED;
} }
if (INTEL_GEN(i915) >= 6) { if (GRAPHICS_VER(i915) >= 6) {
u32 pm_iir = raw_reg_read(regs, GEN6_PMIIR); u32 pm_iir = raw_reg_read(regs, GEN6_PMIIR);
if (pm_iir) { if (pm_iir) {
raw_reg_write(regs, GEN6_PMIIR, pm_iir); raw_reg_write(regs, GEN6_PMIIR, pm_iir);
...@@ -3039,7 +3039,7 @@ static void ilk_irq_reset(struct drm_i915_private *dev_priv) ...@@ -3039,7 +3039,7 @@ static void ilk_irq_reset(struct drm_i915_private *dev_priv)
GEN3_IRQ_RESET(uncore, DE); GEN3_IRQ_RESET(uncore, DE);
dev_priv->irq_mask = ~0u; dev_priv->irq_mask = ~0u;
if (IS_GEN(dev_priv, 7)) if (GRAPHICS_VER(dev_priv) == 7)
intel_uncore_write(uncore, GEN7_ERR_INT, 0xffffffff); intel_uncore_write(uncore, GEN7_ERR_INT, 0xffffffff);
if (IS_HASWELL(dev_priv)) { if (IS_HASWELL(dev_priv)) {
...@@ -3658,7 +3658,7 @@ static void ilk_irq_postinstall(struct drm_i915_private *dev_priv) ...@@ -3658,7 +3658,7 @@ static void ilk_irq_postinstall(struct drm_i915_private *dev_priv)
struct intel_uncore *uncore = &dev_priv->uncore; struct intel_uncore *uncore = &dev_priv->uncore;
u32 display_mask, extra_mask; u32 display_mask, extra_mask;
if (INTEL_GEN(dev_priv) >= 7) { if (GRAPHICS_VER(dev_priv) >= 7) {
display_mask = (DE_MASTER_IRQ_CONTROL | DE_GSE_IVB | display_mask = (DE_MASTER_IRQ_CONTROL | DE_GSE_IVB |
DE_PCH_EVENT_IVB | DE_AUX_CHANNEL_A_IVB); DE_PCH_EVENT_IVB | DE_AUX_CHANNEL_A_IVB);
extra_mask = (DE_PIPEC_VBLANK_IVB | DE_PIPEB_VBLANK_IVB | extra_mask = (DE_PIPEC_VBLANK_IVB | DE_PIPEB_VBLANK_IVB |
...@@ -4328,7 +4328,7 @@ void intel_irq_init(struct drm_i915_private *dev_priv) ...@@ -4328,7 +4328,7 @@ void intel_irq_init(struct drm_i915_private *dev_priv)
dev_priv->l3_parity.remap_info[i] = NULL; dev_priv->l3_parity.remap_info[i] = NULL;
/* pre-gen11 the guc irqs bits are in the upper 16 bits of the pm reg */ /* pre-gen11 the guc irqs bits are in the upper 16 bits of the pm reg */
if (HAS_GT_UC(dev_priv) && INTEL_GEN(dev_priv) < 11) if (HAS_GT_UC(dev_priv) && GRAPHICS_VER(dev_priv) < 11)
dev_priv->gt.pm_guc_events = GUC_INTR_GUC2HOST << 16; dev_priv->gt.pm_guc_events = GUC_INTR_GUC2HOST << 16;
if (!HAS_DISPLAY(dev_priv)) if (!HAS_DISPLAY(dev_priv))
...@@ -4399,18 +4399,18 @@ static irq_handler_t intel_irq_handler(struct drm_i915_private *dev_priv) ...@@ -4399,18 +4399,18 @@ static irq_handler_t intel_irq_handler(struct drm_i915_private *dev_priv)
return cherryview_irq_handler; return cherryview_irq_handler;
else if (IS_VALLEYVIEW(dev_priv)) else if (IS_VALLEYVIEW(dev_priv))
return valleyview_irq_handler; return valleyview_irq_handler;
else if (IS_GEN(dev_priv, 4)) else if (GRAPHICS_VER(dev_priv) == 4)
return i965_irq_handler; return i965_irq_handler;
else if (IS_GEN(dev_priv, 3)) else if (GRAPHICS_VER(dev_priv) == 3)
return i915_irq_handler; return i915_irq_handler;
else else
return i8xx_irq_handler; return i8xx_irq_handler;
} else { } else {
if (HAS_MASTER_UNIT_IRQ(dev_priv)) if (HAS_MASTER_UNIT_IRQ(dev_priv))
return dg1_irq_handler; return dg1_irq_handler;
if (INTEL_GEN(dev_priv) >= 11) if (GRAPHICS_VER(dev_priv) >= 11)
return gen11_irq_handler; return gen11_irq_handler;
else if (INTEL_GEN(dev_priv) >= 8) else if (GRAPHICS_VER(dev_priv) >= 8)
return gen8_irq_handler; return gen8_irq_handler;
else else
return ilk_irq_handler; return ilk_irq_handler;
...@@ -4424,16 +4424,16 @@ static void intel_irq_reset(struct drm_i915_private *dev_priv) ...@@ -4424,16 +4424,16 @@ static void intel_irq_reset(struct drm_i915_private *dev_priv)
cherryview_irq_reset(dev_priv); cherryview_irq_reset(dev_priv);
else if (IS_VALLEYVIEW(dev_priv)) else if (IS_VALLEYVIEW(dev_priv))
valleyview_irq_reset(dev_priv); valleyview_irq_reset(dev_priv);
else if (IS_GEN(dev_priv, 4)) else if (GRAPHICS_VER(dev_priv) == 4)
i965_irq_reset(dev_priv); i965_irq_reset(dev_priv);
else if (IS_GEN(dev_priv, 3)) else if (GRAPHICS_VER(dev_priv) == 3)
i915_irq_reset(dev_priv); i915_irq_reset(dev_priv);
else else
i8xx_irq_reset(dev_priv); i8xx_irq_reset(dev_priv);
} else { } else {
if (INTEL_GEN(dev_priv) >= 11) if (GRAPHICS_VER(dev_priv) >= 11)
gen11_irq_reset(dev_priv); gen11_irq_reset(dev_priv);
else if (INTEL_GEN(dev_priv) >= 8) else if (GRAPHICS_VER(dev_priv) >= 8)
gen8_irq_reset(dev_priv); gen8_irq_reset(dev_priv);
else else
ilk_irq_reset(dev_priv); ilk_irq_reset(dev_priv);
...@@ -4447,16 +4447,16 @@ static void intel_irq_postinstall(struct drm_i915_private *dev_priv) ...@@ -4447,16 +4447,16 @@ static void intel_irq_postinstall(struct drm_i915_private *dev_priv)
cherryview_irq_postinstall(dev_priv); cherryview_irq_postinstall(dev_priv);
else if (IS_VALLEYVIEW(dev_priv)) else if (IS_VALLEYVIEW(dev_priv))
valleyview_irq_postinstall(dev_priv); valleyview_irq_postinstall(dev_priv);
else if (IS_GEN(dev_priv, 4)) else if (GRAPHICS_VER(dev_priv) == 4)
i965_irq_postinstall(dev_priv); i965_irq_postinstall(dev_priv);
else if (IS_GEN(dev_priv, 3)) else if (GRAPHICS_VER(dev_priv) == 3)
i915_irq_postinstall(dev_priv); i915_irq_postinstall(dev_priv);
else else
i8xx_irq_postinstall(dev_priv); i8xx_irq_postinstall(dev_priv);
} else { } else {
if (INTEL_GEN(dev_priv) >= 11) if (GRAPHICS_VER(dev_priv) >= 11)
gen11_irq_postinstall(dev_priv); gen11_irq_postinstall(dev_priv);
else if (INTEL_GEN(dev_priv) >= 8) else if (GRAPHICS_VER(dev_priv) >= 8)
gen8_irq_postinstall(dev_priv); gen8_irq_postinstall(dev_priv);
else else
ilk_irq_postinstall(dev_priv); ilk_irq_postinstall(dev_priv);
......
...@@ -719,7 +719,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream, ...@@ -719,7 +719,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
* it to userspace... * it to userspace...
*/ */
reason = ((report32[0] >> OAREPORT_REASON_SHIFT) & reason = ((report32[0] >> OAREPORT_REASON_SHIFT) &
(IS_GEN(stream->perf->i915, 12) ? (GRAPHICS_VER(stream->perf->i915) == 12 ?
OAREPORT_REASON_MASK_EXTENDED : OAREPORT_REASON_MASK_EXTENDED :
OAREPORT_REASON_MASK)); OAREPORT_REASON_MASK));
...@@ -734,7 +734,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream, ...@@ -734,7 +734,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
* understand that the ID has been squashed by the kernel. * understand that the ID has been squashed by the kernel.
*/ */
if (!(report32[0] & stream->perf->gen8_valid_ctx_bit) && if (!(report32[0] & stream->perf->gen8_valid_ctx_bit) &&
INTEL_GEN(stream->perf->i915) <= 11) GRAPHICS_VER(stream->perf->i915) <= 11)
ctx_id = report32[2] = INVALID_CTX_ID; ctx_id = report32[2] = INVALID_CTX_ID;
/* /*
...@@ -801,7 +801,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream, ...@@ -801,7 +801,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
if (start_offset != *offset) { if (start_offset != *offset) {
i915_reg_t oaheadptr; i915_reg_t oaheadptr;
oaheadptr = IS_GEN(stream->perf->i915, 12) ? oaheadptr = GRAPHICS_VER(stream->perf->i915) == 12 ?
GEN12_OAG_OAHEADPTR : GEN8_OAHEADPTR; GEN12_OAG_OAHEADPTR : GEN8_OAHEADPTR;
spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags); spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags);
...@@ -854,7 +854,7 @@ static int gen8_oa_read(struct i915_perf_stream *stream, ...@@ -854,7 +854,7 @@ static int gen8_oa_read(struct i915_perf_stream *stream,
if (drm_WARN_ON(&uncore->i915->drm, !stream->oa_buffer.vaddr)) if (drm_WARN_ON(&uncore->i915->drm, !stream->oa_buffer.vaddr))
return -EIO; return -EIO;
oastatus_reg = IS_GEN(stream->perf->i915, 12) ? oastatus_reg = GRAPHICS_VER(stream->perf->i915) == 12 ?
GEN12_OAG_OASTATUS : GEN8_OASTATUS; GEN12_OAG_OASTATUS : GEN8_OASTATUS;
oastatus = intel_uncore_read(uncore, oastatus_reg); oastatus = intel_uncore_read(uncore, oastatus_reg);
...@@ -901,7 +901,7 @@ static int gen8_oa_read(struct i915_perf_stream *stream, ...@@ -901,7 +901,7 @@ static int gen8_oa_read(struct i915_perf_stream *stream,
intel_uncore_rmw(uncore, oastatus_reg, intel_uncore_rmw(uncore, oastatus_reg,
GEN8_OASTATUS_COUNTER_OVERFLOW | GEN8_OASTATUS_COUNTER_OVERFLOW |
GEN8_OASTATUS_REPORT_LOST, GEN8_OASTATUS_REPORT_LOST,
IS_GEN_RANGE(uncore->i915, 8, 11) ? IS_GRAPHICS_VER(uncore->i915, 8, 11) ?
(GEN8_OASTATUS_HEAD_POINTER_WRAP | (GEN8_OASTATUS_HEAD_POINTER_WRAP |
GEN8_OASTATUS_TAIL_POINTER_WRAP) : 0); GEN8_OASTATUS_TAIL_POINTER_WRAP) : 0);
} }
...@@ -1243,7 +1243,7 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream) ...@@ -1243,7 +1243,7 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream)
if (IS_ERR(ce)) if (IS_ERR(ce))
return PTR_ERR(ce); return PTR_ERR(ce);
switch (INTEL_GEN(ce->engine->i915)) { switch (GRAPHICS_VER(ce->engine->i915)) {
case 7: { case 7: {
/* /*
* On Haswell we don't do any post processing of the reports * On Haswell we don't do any post processing of the reports
...@@ -1297,7 +1297,7 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream) ...@@ -1297,7 +1297,7 @@ static int oa_get_render_ctx_id(struct i915_perf_stream *stream)
} }
default: default:
MISSING_CASE(INTEL_GEN(ce->engine->i915)); MISSING_CASE(GRAPHICS_VER(ce->engine->i915));
} }
ce->tag = stream->specific_ctx_id; ce->tag = stream->specific_ctx_id;
...@@ -1602,7 +1602,7 @@ static u32 *save_restore_register(struct i915_perf_stream *stream, u32 *cs, ...@@ -1602,7 +1602,7 @@ static u32 *save_restore_register(struct i915_perf_stream *stream, u32 *cs,
cmd = save ? MI_STORE_REGISTER_MEM : MI_LOAD_REGISTER_MEM; cmd = save ? MI_STORE_REGISTER_MEM : MI_LOAD_REGISTER_MEM;
cmd |= MI_SRM_LRM_GLOBAL_GTT; cmd |= MI_SRM_LRM_GLOBAL_GTT;
if (INTEL_GEN(stream->perf->i915) >= 8) if (GRAPHICS_VER(stream->perf->i915) >= 8)
cmd++; cmd++;
for (d = 0; d < dword_count; d++) { for (d = 0; d < dword_count; d++) {
...@@ -1731,7 +1731,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream) ...@@ -1731,7 +1731,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream)
*cs++ = i915_mmio_reg_offset(MI_PREDICATE_RESULT_1); *cs++ = i915_mmio_reg_offset(MI_PREDICATE_RESULT_1);
/* Restart from the beginning if we had timestamps roll over. */ /* Restart from the beginning if we had timestamps roll over. */
*cs++ = (INTEL_GEN(i915) < 8 ? *cs++ = (GRAPHICS_VER(i915) < 8 ?
MI_BATCH_BUFFER_START : MI_BATCH_BUFFER_START :
MI_BATCH_BUFFER_START_GEN8) | MI_BATCH_BUFFER_START_GEN8) |
MI_BATCH_PREDICATE; MI_BATCH_PREDICATE;
...@@ -1768,7 +1768,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream) ...@@ -1768,7 +1768,7 @@ static int alloc_noa_wait(struct i915_perf_stream *stream)
*cs++ = i915_mmio_reg_offset(MI_PREDICATE_RESULT_1); *cs++ = i915_mmio_reg_offset(MI_PREDICATE_RESULT_1);
/* Predicate the jump. */ /* Predicate the jump. */
*cs++ = (INTEL_GEN(i915) < 8 ? *cs++ = (GRAPHICS_VER(i915) < 8 ?
MI_BATCH_BUFFER_START : MI_BATCH_BUFFER_START :
MI_BATCH_BUFFER_START_GEN8) | MI_BATCH_BUFFER_START_GEN8) |
MI_BATCH_PREDICATE; MI_BATCH_PREDICATE;
...@@ -1892,7 +1892,7 @@ alloc_oa_config_buffer(struct i915_perf_stream *stream, ...@@ -1892,7 +1892,7 @@ alloc_oa_config_buffer(struct i915_perf_stream *stream,
oa_config->flex_regs_len); oa_config->flex_regs_len);
/* Jump into the active wait. */ /* Jump into the active wait. */
*cs++ = (INTEL_GEN(stream->perf->i915) < 8 ? *cs++ = (GRAPHICS_VER(stream->perf->i915) < 8 ?
MI_BATCH_BUFFER_START : MI_BATCH_BUFFER_START :
MI_BATCH_BUFFER_START_GEN8); MI_BATCH_BUFFER_START_GEN8);
*cs++ = i915_ggtt_offset(stream->noa_wait); *cs++ = i915_ggtt_offset(stream->noa_wait);
...@@ -2492,7 +2492,7 @@ gen8_enable_metric_set(struct i915_perf_stream *stream, ...@@ -2492,7 +2492,7 @@ gen8_enable_metric_set(struct i915_perf_stream *stream,
* be read back from automatically triggered reports, as part of the * be read back from automatically triggered reports, as part of the
* RPT_ID field. * RPT_ID field.
*/ */
if (IS_GEN_RANGE(stream->perf->i915, 9, 11)) { if (IS_GRAPHICS_VER(stream->perf->i915, 9, 11)) {
intel_uncore_write(uncore, GEN8_OA_DEBUG, intel_uncore_write(uncore, GEN8_OA_DEBUG,
_MASKED_BIT_ENABLE(GEN9_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS | _MASKED_BIT_ENABLE(GEN9_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN9_OA_DEBUG_INCLUDE_CLK_RATIO)); GEN9_OA_DEBUG_INCLUDE_CLK_RATIO));
...@@ -2797,7 +2797,7 @@ get_default_sseu_config(struct intel_sseu *out_sseu, ...@@ -2797,7 +2797,7 @@ get_default_sseu_config(struct intel_sseu *out_sseu,
*out_sseu = intel_sseu_from_device_info(devinfo_sseu); *out_sseu = intel_sseu_from_device_info(devinfo_sseu);
if (IS_GEN(engine->i915, 11)) { if (GRAPHICS_VER(engine->i915) == 11) {
/* /*
* We only need subslice count so it doesn't matter which ones * We only need subslice count so it doesn't matter which ones
* we select - just turn off low bits in the amount of half of * we select - just turn off low bits in the amount of half of
...@@ -2864,7 +2864,7 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream, ...@@ -2864,7 +2864,7 @@ static int i915_oa_stream_init(struct i915_perf_stream *stream,
} }
if (!(props->sample_flags & SAMPLE_OA_REPORT) && if (!(props->sample_flags & SAMPLE_OA_REPORT) &&
(INTEL_GEN(perf->i915) < 12 || !stream->ctx)) { (GRAPHICS_VER(perf->i915) < 12 || !stream->ctx)) {
DRM_DEBUG("Only OA report sampling supported\n"); DRM_DEBUG("Only OA report sampling supported\n");
return -EINVAL; return -EINVAL;
} }
...@@ -3006,7 +3006,7 @@ void i915_oa_init_reg_state(const struct intel_context *ce, ...@@ -3006,7 +3006,7 @@ void i915_oa_init_reg_state(const struct intel_context *ce,
/* perf.exclusive_stream serialised by lrc_configure_all_contexts() */ /* perf.exclusive_stream serialised by lrc_configure_all_contexts() */
stream = READ_ONCE(engine->i915->perf.exclusive_stream); stream = READ_ONCE(engine->i915->perf.exclusive_stream);
if (stream && INTEL_GEN(stream->perf->i915) < 12) if (stream && GRAPHICS_VER(stream->perf->i915) < 12)
gen8_update_reg_state_unlocked(ce, stream); gen8_update_reg_state_unlocked(ce, stream);
} }
...@@ -3443,7 +3443,7 @@ i915_perf_open_ioctl_locked(struct i915_perf *perf, ...@@ -3443,7 +3443,7 @@ i915_perf_open_ioctl_locked(struct i915_perf *perf,
*/ */
if (IS_HASWELL(perf->i915) && specific_ctx) if (IS_HASWELL(perf->i915) && specific_ctx)
privileged_op = false; privileged_op = false;
else if (IS_GEN(perf->i915, 12) && specific_ctx && else if (GRAPHICS_VER(perf->i915) == 12 && specific_ctx &&
(props->sample_flags & SAMPLE_OA_REPORT) == 0) (props->sample_flags & SAMPLE_OA_REPORT) == 0)
privileged_op = false; privileged_op = false;
...@@ -4119,7 +4119,7 @@ int i915_perf_add_config_ioctl(struct drm_device *dev, void *data, ...@@ -4119,7 +4119,7 @@ int i915_perf_add_config_ioctl(struct drm_device *dev, void *data,
} }
oa_config->b_counter_regs = regs; oa_config->b_counter_regs = regs;
if (INTEL_GEN(perf->i915) < 8) { if (GRAPHICS_VER(perf->i915) < 8) {
if (args->n_flex_regs != 0) { if (args->n_flex_regs != 0) {
err = -EINVAL; err = -EINVAL;
goto reg_err; goto reg_err;
...@@ -4365,7 +4365,7 @@ void i915_perf_init(struct drm_i915_private *i915) ...@@ -4365,7 +4365,7 @@ void i915_perf_init(struct drm_i915_private *i915)
*/ */
perf->ops.read = gen8_oa_read; perf->ops.read = gen8_oa_read;
if (IS_GEN_RANGE(i915, 8, 9)) { if (IS_GRAPHICS_VER(i915, 8, 9)) {
perf->ops.is_valid_b_counter_reg = perf->ops.is_valid_b_counter_reg =
gen7_is_valid_b_counter_addr; gen7_is_valid_b_counter_addr;
perf->ops.is_valid_mux_reg = perf->ops.is_valid_mux_reg =
...@@ -4384,7 +4384,7 @@ void i915_perf_init(struct drm_i915_private *i915) ...@@ -4384,7 +4384,7 @@ void i915_perf_init(struct drm_i915_private *i915)
perf->ops.disable_metric_set = gen8_disable_metric_set; perf->ops.disable_metric_set = gen8_disable_metric_set;
perf->ops.oa_hw_tail_read = gen8_oa_hw_tail_read; perf->ops.oa_hw_tail_read = gen8_oa_hw_tail_read;
if (IS_GEN(i915, 8)) { if (GRAPHICS_VER(i915) == 8) {
perf->ctx_oactxctrl_offset = 0x120; perf->ctx_oactxctrl_offset = 0x120;
perf->ctx_flexeu0_offset = 0x2ce; perf->ctx_flexeu0_offset = 0x2ce;
...@@ -4395,7 +4395,7 @@ void i915_perf_init(struct drm_i915_private *i915) ...@@ -4395,7 +4395,7 @@ void i915_perf_init(struct drm_i915_private *i915)
perf->gen8_valid_ctx_bit = BIT(16); perf->gen8_valid_ctx_bit = BIT(16);
} }
} else if (IS_GEN_RANGE(i915, 10, 11)) { } else if (IS_GRAPHICS_VER(i915, 10, 11)) {
perf->ops.is_valid_b_counter_reg = perf->ops.is_valid_b_counter_reg =
gen7_is_valid_b_counter_addr; gen7_is_valid_b_counter_addr;
perf->ops.is_valid_mux_reg = perf->ops.is_valid_mux_reg =
...@@ -4409,7 +4409,7 @@ void i915_perf_init(struct drm_i915_private *i915) ...@@ -4409,7 +4409,7 @@ void i915_perf_init(struct drm_i915_private *i915)
perf->ops.disable_metric_set = gen10_disable_metric_set; perf->ops.disable_metric_set = gen10_disable_metric_set;
perf->ops.oa_hw_tail_read = gen8_oa_hw_tail_read; perf->ops.oa_hw_tail_read = gen8_oa_hw_tail_read;
if (IS_GEN(i915, 10)) { if (GRAPHICS_VER(i915) == 10) {
perf->ctx_oactxctrl_offset = 0x128; perf->ctx_oactxctrl_offset = 0x128;
perf->ctx_flexeu0_offset = 0x3de; perf->ctx_flexeu0_offset = 0x3de;
} else { } else {
...@@ -4417,7 +4417,7 @@ void i915_perf_init(struct drm_i915_private *i915) ...@@ -4417,7 +4417,7 @@ void i915_perf_init(struct drm_i915_private *i915)
perf->ctx_flexeu0_offset = 0x78e; perf->ctx_flexeu0_offset = 0x78e;
} }
perf->gen8_valid_ctx_bit = BIT(16); perf->gen8_valid_ctx_bit = BIT(16);
} else if (IS_GEN(i915, 12)) { } else if (GRAPHICS_VER(i915) == 12) {
perf->ops.is_valid_b_counter_reg = perf->ops.is_valid_b_counter_reg =
gen12_is_valid_b_counter_addr; gen12_is_valid_b_counter_addr;
perf->ops.is_valid_mux_reg = perf->ops.is_valid_mux_reg =
......
...@@ -287,7 +287,7 @@ static bool exclusive_mmio_access(const struct drm_i915_private *i915) ...@@ -287,7 +287,7 @@ static bool exclusive_mmio_access(const struct drm_i915_private *i915)
* risk a machine hang. For a fun history lesson dig out the old * risk a machine hang. For a fun history lesson dig out the old
* userspace intel_gpu_top and run it on Ivybridge or Haswell! * userspace intel_gpu_top and run it on Ivybridge or Haswell!
*/ */
return IS_GEN(i915, 7); return GRAPHICS_VER(i915) == 7;
} }
static void engine_sample(struct intel_engine_cs *engine, unsigned int period_ns) static void engine_sample(struct intel_engine_cs *engine, unsigned int period_ns)
...@@ -463,7 +463,7 @@ engine_event_status(struct intel_engine_cs *engine, ...@@ -463,7 +463,7 @@ engine_event_status(struct intel_engine_cs *engine,
case I915_SAMPLE_WAIT: case I915_SAMPLE_WAIT:
break; break;
case I915_SAMPLE_SEMA: case I915_SAMPLE_SEMA:
if (INTEL_GEN(engine->i915) < 6) if (GRAPHICS_VER(engine->i915) < 6)
return -ENODEV; return -ENODEV;
break; break;
default: default:
...@@ -483,7 +483,7 @@ config_status(struct drm_i915_private *i915, u64 config) ...@@ -483,7 +483,7 @@ config_status(struct drm_i915_private *i915, u64 config)
return -ENODEV; return -ENODEV;
fallthrough; fallthrough;
case I915_PMU_REQUESTED_FREQUENCY: case I915_PMU_REQUESTED_FREQUENCY:
if (INTEL_GEN(i915) < 6) if (GRAPHICS_VER(i915) < 6)
return -ENODEV; return -ENODEV;
break; break;
case I915_PMU_INTERRUPTS: case I915_PMU_INTERRUPTS:
...@@ -1145,7 +1145,7 @@ void i915_pmu_register(struct drm_i915_private *i915) ...@@ -1145,7 +1145,7 @@ void i915_pmu_register(struct drm_i915_private *i915)
int ret = -ENOMEM; int ret = -ENOMEM;
if (INTEL_GEN(i915) <= 2) { if (GRAPHICS_VER(i915) <= 2) {
drm_info(&i915->drm, "PMU not supported for this GPU."); drm_info(&i915->drm, "PMU not supported for this GPU.");
return; return;
} }
......
...@@ -1176,12 +1176,12 @@ __emit_semaphore_wait(struct i915_request *to, ...@@ -1176,12 +1176,12 @@ __emit_semaphore_wait(struct i915_request *to,
struct i915_request *from, struct i915_request *from,
u32 seqno) u32 seqno)
{ {
const int has_token = INTEL_GEN(to->engine->i915) >= 12; const int has_token = GRAPHICS_VER(to->engine->i915) >= 12;
u32 hwsp_offset; u32 hwsp_offset;
int len, err; int len, err;
u32 *cs; u32 *cs;
GEM_BUG_ON(INTEL_GEN(to->engine->i915) < 8); GEM_BUG_ON(GRAPHICS_VER(to->engine->i915) < 8);
GEM_BUG_ON(i915_request_has_initial_breadcrumb(to)); GEM_BUG_ON(i915_request_has_initial_breadcrumb(to));
/* We need to pin the signaler's HWSP until we are finished reading. */ /* We need to pin the signaler's HWSP until we are finished reading. */
......
...@@ -38,14 +38,14 @@ static void intel_save_swf(struct drm_i915_private *dev_priv) ...@@ -38,14 +38,14 @@ static void intel_save_swf(struct drm_i915_private *dev_priv)
int i; int i;
/* Scratch space */ /* Scratch space */
if (IS_GEN(dev_priv, 2) && IS_MOBILE(dev_priv)) { if (GRAPHICS_VER(dev_priv) == 2 && IS_MOBILE(dev_priv)) {
for (i = 0; i < 7; i++) { for (i = 0; i < 7; i++) {
dev_priv->regfile.saveSWF0[i] = intel_de_read(dev_priv, SWF0(i)); dev_priv->regfile.saveSWF0[i] = intel_de_read(dev_priv, SWF0(i));
dev_priv->regfile.saveSWF1[i] = intel_de_read(dev_priv, SWF1(i)); dev_priv->regfile.saveSWF1[i] = intel_de_read(dev_priv, SWF1(i));
} }
for (i = 0; i < 3; i++) for (i = 0; i < 3; i++)
dev_priv->regfile.saveSWF3[i] = intel_de_read(dev_priv, SWF3(i)); dev_priv->regfile.saveSWF3[i] = intel_de_read(dev_priv, SWF3(i));
} else if (IS_GEN(dev_priv, 2)) { } else if (GRAPHICS_VER(dev_priv) == 2) {
for (i = 0; i < 7; i++) for (i = 0; i < 7; i++)
dev_priv->regfile.saveSWF1[i] = intel_de_read(dev_priv, SWF1(i)); dev_priv->regfile.saveSWF1[i] = intel_de_read(dev_priv, SWF1(i));
} else if (HAS_GMCH(dev_priv)) { } else if (HAS_GMCH(dev_priv)) {
...@@ -63,14 +63,14 @@ static void intel_restore_swf(struct drm_i915_private *dev_priv) ...@@ -63,14 +63,14 @@ static void intel_restore_swf(struct drm_i915_private *dev_priv)
int i; int i;
/* Scratch space */ /* Scratch space */
if (IS_GEN(dev_priv, 2) && IS_MOBILE(dev_priv)) { if (GRAPHICS_VER(dev_priv) == 2 && IS_MOBILE(dev_priv)) {
for (i = 0; i < 7; i++) { for (i = 0; i < 7; i++) {
intel_de_write(dev_priv, SWF0(i), dev_priv->regfile.saveSWF0[i]); intel_de_write(dev_priv, SWF0(i), dev_priv->regfile.saveSWF0[i]);
intel_de_write(dev_priv, SWF1(i), dev_priv->regfile.saveSWF1[i]); intel_de_write(dev_priv, SWF1(i), dev_priv->regfile.saveSWF1[i]);
} }
for (i = 0; i < 3; i++) for (i = 0; i < 3; i++)
intel_de_write(dev_priv, SWF3(i), dev_priv->regfile.saveSWF3[i]); intel_de_write(dev_priv, SWF3(i), dev_priv->regfile.saveSWF3[i]);
} else if (IS_GEN(dev_priv, 2)) { } else if (GRAPHICS_VER(dev_priv) == 2) {
for (i = 0; i < 7; i++) for (i = 0; i < 7; i++)
intel_de_write(dev_priv, SWF1(i), dev_priv->regfile.saveSWF1[i]); intel_de_write(dev_priv, SWF1(i), dev_priv->regfile.saveSWF1[i]);
} else if (HAS_GMCH(dev_priv)) { } else if (HAS_GMCH(dev_priv)) {
...@@ -91,10 +91,10 @@ void i915_save_display(struct drm_i915_private *dev_priv) ...@@ -91,10 +91,10 @@ void i915_save_display(struct drm_i915_private *dev_priv)
return; return;
/* Display arbitration control */ /* Display arbitration control */
if (INTEL_GEN(dev_priv) <= 4) if (GRAPHICS_VER(dev_priv) <= 4)
dev_priv->regfile.saveDSPARB = intel_de_read(dev_priv, DSPARB); dev_priv->regfile.saveDSPARB = intel_de_read(dev_priv, DSPARB);
if (IS_GEN(dev_priv, 4)) if (GRAPHICS_VER(dev_priv) == 4)
pci_read_config_word(pdev, GCDGMBUS, pci_read_config_word(pdev, GCDGMBUS,
&dev_priv->regfile.saveGCDGMBUS); &dev_priv->regfile.saveGCDGMBUS);
...@@ -110,12 +110,12 @@ void i915_restore_display(struct drm_i915_private *dev_priv) ...@@ -110,12 +110,12 @@ void i915_restore_display(struct drm_i915_private *dev_priv)
intel_restore_swf(dev_priv); intel_restore_swf(dev_priv);
if (IS_GEN(dev_priv, 4)) if (GRAPHICS_VER(dev_priv) == 4)
pci_write_config_word(pdev, GCDGMBUS, pci_write_config_word(pdev, GCDGMBUS,
dev_priv->regfile.saveGCDGMBUS); dev_priv->regfile.saveGCDGMBUS);
/* Display arbitration */ /* Display arbitration */
if (INTEL_GEN(dev_priv) <= 4) if (GRAPHICS_VER(dev_priv) <= 4)
intel_de_write(dev_priv, DSPARB, dev_priv->regfile.saveDSPARB); intel_de_write(dev_priv, DSPARB, dev_priv->regfile.saveDSPARB);
/* only restore FBC info on the platform that supports FBC*/ /* only restore FBC info on the platform that supports FBC*/
......
...@@ -595,7 +595,7 @@ void i915_setup_sysfs(struct drm_i915_private *dev_priv) ...@@ -595,7 +595,7 @@ void i915_setup_sysfs(struct drm_i915_private *dev_priv)
ret = 0; ret = 0;
if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
ret = sysfs_create_files(&kdev->kobj, vlv_attrs); ret = sysfs_create_files(&kdev->kobj, vlv_attrs);
else if (INTEL_GEN(dev_priv) >= 6) else if (GRAPHICS_VER(dev_priv) >= 6)
ret = sysfs_create_files(&kdev->kobj, gen6_attrs); ret = sysfs_create_files(&kdev->kobj, gen6_attrs);
if (ret) if (ret)
drm_err(&dev_priv->drm, "RPS sysfs setup failed\n"); drm_err(&dev_priv->drm, "RPS sysfs setup failed\n");
......
...@@ -74,7 +74,7 @@ void intel_vgpu_detect(struct drm_i915_private *dev_priv) ...@@ -74,7 +74,7 @@ void intel_vgpu_detect(struct drm_i915_private *dev_priv)
* we do not support VGT on older gens, return early so we don't have * we do not support VGT on older gens, return early so we don't have
* to consider differently numbered or sized MMIO bars * to consider differently numbered or sized MMIO bars
*/ */
if (INTEL_GEN(dev_priv) < 6) if (GRAPHICS_VER(dev_priv) < 6)
return; return;
shared_area = pci_iomap_range(pdev, 0, VGT_PVINFO_PAGE, VGT_PVINFO_SIZE); shared_area = pci_iomap_range(pdev, 0, VGT_PVINFO_PAGE, VGT_PVINFO_SIZE);
......
...@@ -257,10 +257,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -257,10 +257,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (IS_ADLS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_A0)) if (IS_ADLS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_A0))
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_scalers[pipe] = 0; runtime->num_scalers[pipe] = 0;
else if (INTEL_GEN(dev_priv) >= 10) { else if (GRAPHICS_VER(dev_priv) >= 10) {
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_scalers[pipe] = 2; runtime->num_scalers[pipe] = 2;
} else if (IS_GEN(dev_priv, 9)) { } else if (GRAPHICS_VER(dev_priv) == 9) {
runtime->num_scalers[PIPE_A] = 2; runtime->num_scalers[PIPE_A] = 2;
runtime->num_scalers[PIPE_B] = 2; runtime->num_scalers[PIPE_B] = 2;
runtime->num_scalers[PIPE_C] = 1; runtime->num_scalers[PIPE_C] = 1;
...@@ -271,10 +271,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -271,10 +271,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (DISPLAY_VER(dev_priv) >= 13 || HAS_D12_PLANE_MINIMIZATION(dev_priv)) if (DISPLAY_VER(dev_priv) >= 13 || HAS_D12_PLANE_MINIMIZATION(dev_priv))
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_sprites[pipe] = 4; runtime->num_sprites[pipe] = 4;
else if (INTEL_GEN(dev_priv) >= 11) else if (GRAPHICS_VER(dev_priv) >= 11)
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_sprites[pipe] = 6; runtime->num_sprites[pipe] = 6;
else if (IS_GEN(dev_priv, 10) || IS_GEMINILAKE(dev_priv)) else if (GRAPHICS_VER(dev_priv) == 10 || IS_GEMINILAKE(dev_priv))
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_sprites[pipe] = 3; runtime->num_sprites[pipe] = 3;
else if (IS_BROXTON(dev_priv)) { else if (IS_BROXTON(dev_priv)) {
...@@ -293,12 +293,12 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -293,12 +293,12 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
} else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) { } else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_sprites[pipe] = 2; runtime->num_sprites[pipe] = 2;
} else if (INTEL_GEN(dev_priv) >= 5 || IS_G4X(dev_priv)) { } else if (GRAPHICS_VER(dev_priv) >= 5 || IS_G4X(dev_priv)) {
for_each_pipe(dev_priv, pipe) for_each_pipe(dev_priv, pipe)
runtime->num_sprites[pipe] = 1; runtime->num_sprites[pipe] = 1;
} }
if (HAS_DISPLAY(dev_priv) && IS_GEN_RANGE(dev_priv, 7, 8) && if (HAS_DISPLAY(dev_priv) && IS_GRAPHICS_VER(dev_priv, 7, 8) &&
HAS_PCH_SPLIT(dev_priv)) { HAS_PCH_SPLIT(dev_priv)) {
u32 fuse_strap = intel_de_read(dev_priv, FUSE_STRAP); u32 fuse_strap = intel_de_read(dev_priv, FUSE_STRAP);
u32 sfuse_strap = intel_de_read(dev_priv, SFUSE_STRAP); u32 sfuse_strap = intel_de_read(dev_priv, SFUSE_STRAP);
...@@ -325,7 +325,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -325,7 +325,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
info->pipe_mask &= ~BIT(PIPE_C); info->pipe_mask &= ~BIT(PIPE_C);
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C); info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
} }
} else if (HAS_DISPLAY(dev_priv) && INTEL_GEN(dev_priv) >= 9) { } else if (HAS_DISPLAY(dev_priv) && GRAPHICS_VER(dev_priv) >= 9) {
u32 dfsm = intel_de_read(dev_priv, SKL_DFSM); u32 dfsm = intel_de_read(dev_priv, SKL_DFSM);
if (dfsm & SKL_DFSM_PIPE_A_DISABLE) { if (dfsm & SKL_DFSM_PIPE_A_DISABLE) {
...@@ -340,7 +340,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -340,7 +340,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
info->pipe_mask &= ~BIT(PIPE_C); info->pipe_mask &= ~BIT(PIPE_C);
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C); info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
} }
if (INTEL_GEN(dev_priv) >= 12 && if (GRAPHICS_VER(dev_priv) >= 12 &&
(dfsm & TGL_DFSM_PIPE_D_DISABLE)) { (dfsm & TGL_DFSM_PIPE_D_DISABLE)) {
info->pipe_mask &= ~BIT(PIPE_D); info->pipe_mask &= ~BIT(PIPE_D);
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_D); info->cpu_transcoder_mask &= ~BIT(TRANSCODER_D);
...@@ -352,15 +352,15 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv) ...@@ -352,15 +352,15 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE) if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
info->display.has_fbc = 0; info->display.has_fbc = 0;
if (INTEL_GEN(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE)) if (GRAPHICS_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
info->display.has_dmc = 0; info->display.has_dmc = 0;
if (INTEL_GEN(dev_priv) >= 10 && if (GRAPHICS_VER(dev_priv) >= 10 &&
(dfsm & CNL_DFSM_DISPLAY_DSC_DISABLE)) (dfsm & CNL_DFSM_DISPLAY_DSC_DISABLE))
info->display.has_dsc = 0; info->display.has_dsc = 0;
} }
if (IS_GEN(dev_priv, 6) && intel_vtd_active()) { if (GRAPHICS_VER(dev_priv) == 6 && intel_vtd_active()) {
drm_info(&dev_priv->drm, drm_info(&dev_priv->drm,
"Disabling ppGTT for VT-d support\n"); "Disabling ppGTT for VT-d support\n");
info->ppgtt_type = INTEL_PPGTT_NONE; info->ppgtt_type = INTEL_PPGTT_NONE;
......
...@@ -121,7 +121,7 @@ skl_dram_get_dimm_info(struct drm_i915_private *i915, ...@@ -121,7 +121,7 @@ skl_dram_get_dimm_info(struct drm_i915_private *i915,
struct dram_dimm_info *dimm, struct dram_dimm_info *dimm,
int channel, char dimm_name, u16 val) int channel, char dimm_name, u16 val)
{ {
if (INTEL_GEN(i915) >= 10) { if (GRAPHICS_VER(i915) >= 10) {
dimm->size = cnl_get_dimm_size(val); dimm->size = cnl_get_dimm_size(val);
dimm->width = cnl_get_dimm_width(val); dimm->width = cnl_get_dimm_width(val);
dimm->ranks = cnl_get_dimm_ranks(val); dimm->ranks = cnl_get_dimm_ranks(val);
...@@ -422,7 +422,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv) ...@@ -422,7 +422,7 @@ static int icl_pcode_read_mem_global_info(struct drm_i915_private *dev_priv)
if (ret) if (ret)
return ret; return ret;
if (IS_GEN(dev_priv, 12)) { if (GRAPHICS_VER(dev_priv) == 12) {
switch (val & 0xf) { switch (val & 0xf) {
case 0: case 0:
dram_info->type = INTEL_DRAM_DDR4; dram_info->type = INTEL_DRAM_DDR4;
...@@ -501,12 +501,12 @@ void intel_dram_detect(struct drm_i915_private *i915) ...@@ -501,12 +501,12 @@ void intel_dram_detect(struct drm_i915_private *i915)
*/ */
dram_info->wm_lv_0_adjust_needed = !IS_GEN9_LP(i915); dram_info->wm_lv_0_adjust_needed = !IS_GEN9_LP(i915);
if (INTEL_GEN(i915) < 9 || !HAS_DISPLAY(i915)) if (GRAPHICS_VER(i915) < 9 || !HAS_DISPLAY(i915))
return; return;
if (INTEL_GEN(i915) >= 12) if (GRAPHICS_VER(i915) >= 12)
ret = gen12_get_dram_info(i915); ret = gen12_get_dram_info(i915);
else if (INTEL_GEN(i915) >= 11) else if (GRAPHICS_VER(i915) >= 11)
ret = gen11_get_dram_info(i915); ret = gen11_get_dram_info(i915);
else if (IS_GEN9_LP(i915)) else if (IS_GEN9_LP(i915))
ret = bxt_get_dram_info(i915); ret = bxt_get_dram_info(i915);
...@@ -535,7 +535,7 @@ void intel_dram_edram_detect(struct drm_i915_private *i915) ...@@ -535,7 +535,7 @@ void intel_dram_edram_detect(struct drm_i915_private *i915)
{ {
u32 edram_cap = 0; u32 edram_cap = 0;
if (!(IS_HASWELL(i915) || IS_BROADWELL(i915) || INTEL_GEN(i915) >= 9)) if (!(IS_HASWELL(i915) || IS_BROADWELL(i915) || GRAPHICS_VER(i915) >= 9))
return; return;
edram_cap = __raw_uncore_read32(&i915->uncore, HSW_EDRAM_CAP); edram_cap = __raw_uncore_read32(&i915->uncore, HSW_EDRAM_CAP);
...@@ -549,7 +549,7 @@ void intel_dram_edram_detect(struct drm_i915_private *i915) ...@@ -549,7 +549,7 @@ void intel_dram_edram_detect(struct drm_i915_private *i915)
* The needed capability bits for size calculation are not there with * The needed capability bits for size calculation are not there with
* pre gen9 so return 128MB always. * pre gen9 so return 128MB always.
*/ */
if (INTEL_GEN(i915) < 9) if (GRAPHICS_VER(i915) < 9)
i915->edram_size_mb = 128; i915->edram_size_mb = 128;
else else
i915->edram_size_mb = gen9_edram_size_mb(i915, edram_cap); i915->edram_size_mb = gen9_edram_size_mb(i915, edram_cap);
......
...@@ -13,17 +13,17 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id) ...@@ -13,17 +13,17 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
switch (id) { switch (id) {
case INTEL_PCH_IBX_DEVICE_ID_TYPE: case INTEL_PCH_IBX_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found Ibex Peak PCH\n"); drm_dbg_kms(&dev_priv->drm, "Found Ibex Peak PCH\n");
drm_WARN_ON(&dev_priv->drm, !IS_GEN(dev_priv, 5)); drm_WARN_ON(&dev_priv->drm, GRAPHICS_VER(dev_priv) != 5);
return PCH_IBX; return PCH_IBX;
case INTEL_PCH_CPT_DEVICE_ID_TYPE: case INTEL_PCH_CPT_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found CougarPoint PCH\n"); drm_dbg_kms(&dev_priv->drm, "Found CougarPoint PCH\n");
drm_WARN_ON(&dev_priv->drm, drm_WARN_ON(&dev_priv->drm,
!IS_GEN(dev_priv, 6) && !IS_IVYBRIDGE(dev_priv)); GRAPHICS_VER(dev_priv) != 6 && !IS_IVYBRIDGE(dev_priv));
return PCH_CPT; return PCH_CPT;
case INTEL_PCH_PPT_DEVICE_ID_TYPE: case INTEL_PCH_PPT_DEVICE_ID_TYPE:
drm_dbg_kms(&dev_priv->drm, "Found PantherPoint PCH\n"); drm_dbg_kms(&dev_priv->drm, "Found PantherPoint PCH\n");
drm_WARN_ON(&dev_priv->drm, drm_WARN_ON(&dev_priv->drm,
!IS_GEN(dev_priv, 6) && !IS_IVYBRIDGE(dev_priv)); GRAPHICS_VER(dev_priv) != 6 && !IS_IVYBRIDGE(dev_priv));
/* PantherPoint is CPT compatible */ /* PantherPoint is CPT compatible */
return PCH_CPT; return PCH_CPT;
case INTEL_PCH_LPT_DEVICE_ID_TYPE: case INTEL_PCH_LPT_DEVICE_ID_TYPE:
...@@ -181,9 +181,9 @@ intel_virt_detect_pch(const struct drm_i915_private *dev_priv, ...@@ -181,9 +181,9 @@ intel_virt_detect_pch(const struct drm_i915_private *dev_priv,
id = INTEL_PCH_LPT_LP_DEVICE_ID_TYPE; id = INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv)) else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
id = INTEL_PCH_LPT_DEVICE_ID_TYPE; id = INTEL_PCH_LPT_DEVICE_ID_TYPE;
else if (IS_GEN(dev_priv, 6) || IS_IVYBRIDGE(dev_priv)) else if (GRAPHICS_VER(dev_priv) == 6 || IS_IVYBRIDGE(dev_priv))
id = INTEL_PCH_CPT_DEVICE_ID_TYPE; id = INTEL_PCH_CPT_DEVICE_ID_TYPE;
else if (IS_GEN(dev_priv, 5)) else if (GRAPHICS_VER(dev_priv) == 5)
id = INTEL_PCH_IBX_DEVICE_ID_TYPE; id = INTEL_PCH_IBX_DEVICE_ID_TYPE;
if (id) if (id)
......
...@@ -7859,9 +7859,9 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv) ...@@ -7859,9 +7859,9 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.init_clock_gating = adlp_init_clock_gating; dev_priv->display.init_clock_gating = adlp_init_clock_gating;
else if (IS_DG1(dev_priv)) else if (IS_DG1(dev_priv))
dev_priv->display.init_clock_gating = dg1_init_clock_gating; dev_priv->display.init_clock_gating = dg1_init_clock_gating;
else if (IS_GEN(dev_priv, 12)) else if (GRAPHICS_VER(dev_priv) == 12)
dev_priv->display.init_clock_gating = gen12lp_init_clock_gating; dev_priv->display.init_clock_gating = gen12lp_init_clock_gating;
else if (IS_GEN(dev_priv, 11)) else if (GRAPHICS_VER(dev_priv) == 11)
dev_priv->display.init_clock_gating = icl_init_clock_gating; dev_priv->display.init_clock_gating = icl_init_clock_gating;
else if (IS_CANNONLAKE(dev_priv)) else if (IS_CANNONLAKE(dev_priv))
dev_priv->display.init_clock_gating = cnl_init_clock_gating; dev_priv->display.init_clock_gating = cnl_init_clock_gating;
...@@ -7885,9 +7885,9 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv) ...@@ -7885,9 +7885,9 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.init_clock_gating = ivb_init_clock_gating; dev_priv->display.init_clock_gating = ivb_init_clock_gating;
else if (IS_VALLEYVIEW(dev_priv)) else if (IS_VALLEYVIEW(dev_priv))
dev_priv->display.init_clock_gating = vlv_init_clock_gating; dev_priv->display.init_clock_gating = vlv_init_clock_gating;
else if (IS_GEN(dev_priv, 6)) else if (GRAPHICS_VER(dev_priv) == 6)
dev_priv->display.init_clock_gating = gen6_init_clock_gating; dev_priv->display.init_clock_gating = gen6_init_clock_gating;
else if (IS_GEN(dev_priv, 5)) else if (GRAPHICS_VER(dev_priv) == 5)
dev_priv->display.init_clock_gating = ilk_init_clock_gating; dev_priv->display.init_clock_gating = ilk_init_clock_gating;
else if (IS_G4X(dev_priv)) else if (IS_G4X(dev_priv))
dev_priv->display.init_clock_gating = g4x_init_clock_gating; dev_priv->display.init_clock_gating = g4x_init_clock_gating;
...@@ -7895,11 +7895,11 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv) ...@@ -7895,11 +7895,11 @@ void intel_init_clock_gating_hooks(struct drm_i915_private *dev_priv)
dev_priv->display.init_clock_gating = i965gm_init_clock_gating; dev_priv->display.init_clock_gating = i965gm_init_clock_gating;
else if (IS_I965G(dev_priv)) else if (IS_I965G(dev_priv))
dev_priv->display.init_clock_gating = i965g_init_clock_gating; dev_priv->display.init_clock_gating = i965g_init_clock_gating;
else if (IS_GEN(dev_priv, 3)) else if (GRAPHICS_VER(dev_priv) == 3)
dev_priv->display.init_clock_gating = gen3_init_clock_gating; dev_priv->display.init_clock_gating = gen3_init_clock_gating;
else if (IS_I85X(dev_priv) || IS_I865G(dev_priv)) else if (IS_I85X(dev_priv) || IS_I865G(dev_priv))
dev_priv->display.init_clock_gating = i85x_init_clock_gating; dev_priv->display.init_clock_gating = i85x_init_clock_gating;
else if (IS_GEN(dev_priv, 2)) else if (GRAPHICS_VER(dev_priv) == 2)
dev_priv->display.init_clock_gating = i830_init_clock_gating; dev_priv->display.init_clock_gating = i830_init_clock_gating;
else { else {
MISSING_CASE(INTEL_DEVID(dev_priv)); MISSING_CASE(INTEL_DEVID(dev_priv));
...@@ -7913,7 +7913,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv) ...@@ -7913,7 +7913,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)
/* For cxsr */ /* For cxsr */
if (IS_PINEVIEW(dev_priv)) if (IS_PINEVIEW(dev_priv))
pnv_get_mem_freq(dev_priv); pnv_get_mem_freq(dev_priv);
else if (IS_GEN(dev_priv, 5)) else if (GRAPHICS_VER(dev_priv) == 5)
ilk_get_mem_freq(dev_priv); ilk_get_mem_freq(dev_priv);
if (intel_has_sagv(dev_priv)) if (intel_has_sagv(dev_priv))
......
...@@ -430,7 +430,7 @@ static int __sandybridge_pcode_rw(struct drm_i915_private *i915, ...@@ -430,7 +430,7 @@ static int __sandybridge_pcode_rw(struct drm_i915_private *i915,
if (is_read && val1) if (is_read && val1)
*val1 = intel_uncore_read_fw(uncore, GEN6_PCODE_DATA1); *val1 = intel_uncore_read_fw(uncore, GEN6_PCODE_DATA1);
if (INTEL_GEN(i915) > 6) if (GRAPHICS_VER(i915) > 6)
return gen7_check_mailbox_status(mbox); return gen7_check_mailbox_status(mbox);
else else
return gen6_check_mailbox_status(mbox); return gen6_check_mailbox_status(mbox);
......
...@@ -1635,7 +1635,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore) ...@@ -1635,7 +1635,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore)
#define fw_domain_init(uncore__, id__, set__, ack__) \ #define fw_domain_init(uncore__, id__, set__, ack__) \
(ret ?: (ret = __fw_domain_init((uncore__), (id__), (set__), (ack__)))) (ret ?: (ret = __fw_domain_init((uncore__), (id__), (set__), (ack__))))
if (INTEL_GEN(i915) >= 11) { if (GRAPHICS_VER(i915) >= 11) {
/* we'll prune the domains of missing engines later */ /* we'll prune the domains of missing engines later */
intel_engine_mask_t emask = INTEL_INFO(i915)->platform_engine_mask; intel_engine_mask_t emask = INTEL_INFO(i915)->platform_engine_mask;
int i; int i;
...@@ -1665,7 +1665,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore) ...@@ -1665,7 +1665,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore)
FORCEWAKE_MEDIA_VEBOX_GEN11(i), FORCEWAKE_MEDIA_VEBOX_GEN11(i),
FORCEWAKE_ACK_MEDIA_VEBOX_GEN11(i)); FORCEWAKE_ACK_MEDIA_VEBOX_GEN11(i));
} }
} else if (IS_GEN_RANGE(i915, 9, 10)) { } else if (IS_GRAPHICS_VER(i915, 9, 10)) {
uncore->funcs.force_wake_get = fw_domains_get_with_fallback; uncore->funcs.force_wake_get = fw_domains_get_with_fallback;
uncore->funcs.force_wake_put = fw_domains_put; uncore->funcs.force_wake_put = fw_domains_put;
fw_domain_init(uncore, FW_DOMAIN_ID_RENDER, fw_domain_init(uncore, FW_DOMAIN_ID_RENDER,
...@@ -1733,7 +1733,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore) ...@@ -1733,7 +1733,7 @@ static int intel_uncore_fw_domains_init(struct intel_uncore *uncore)
fw_domain_init(uncore, FW_DOMAIN_ID_RENDER, fw_domain_init(uncore, FW_DOMAIN_ID_RENDER,
FORCEWAKE, FORCEWAKE_ACK); FORCEWAKE, FORCEWAKE_ACK);
} }
} else if (IS_GEN(i915, 6)) { } else if (GRAPHICS_VER(i915) == 6) {
uncore->funcs.force_wake_get = uncore->funcs.force_wake_get =
fw_domains_get_with_thread_status; fw_domains_get_with_thread_status;
uncore->funcs.force_wake_put = fw_domains_put; uncore->funcs.force_wake_put = fw_domains_put;
...@@ -1800,7 +1800,7 @@ static int uncore_mmio_setup(struct intel_uncore *uncore) ...@@ -1800,7 +1800,7 @@ static int uncore_mmio_setup(struct intel_uncore *uncore)
int mmio_bar; int mmio_bar;
int mmio_size; int mmio_size;
mmio_bar = IS_GEN(i915, 2) ? 1 : 0; mmio_bar = GRAPHICS_VER(i915) == 2 ? 1 : 0;
/* /*
* Before gen4, the registers and the GTT are behind different BARs. * Before gen4, the registers and the GTT are behind different BARs.
* However, from gen4 onwards, the registers and the GTT are shared * However, from gen4 onwards, the registers and the GTT are shared
...@@ -1810,7 +1810,7 @@ static int uncore_mmio_setup(struct intel_uncore *uncore) ...@@ -1810,7 +1810,7 @@ static int uncore_mmio_setup(struct intel_uncore *uncore)
* generations up to Ironlake. * generations up to Ironlake.
* For dgfx chips register range is expanded to 4MB. * For dgfx chips register range is expanded to 4MB.
*/ */
if (INTEL_GEN(i915) < 5) if (GRAPHICS_VER(i915) < 5)
mmio_size = 512 * 1024; mmio_size = 512 * 1024;
else if (IS_DGFX(i915)) else if (IS_DGFX(i915))
mmio_size = 4 * 1024 * 1024; mmio_size = 4 * 1024 * 1024;
...@@ -1849,7 +1849,7 @@ static void uncore_raw_init(struct intel_uncore *uncore) ...@@ -1849,7 +1849,7 @@ static void uncore_raw_init(struct intel_uncore *uncore)
if (intel_vgpu_active(uncore->i915)) { if (intel_vgpu_active(uncore->i915)) {
ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, vgpu); ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, vgpu);
ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, vgpu); ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, vgpu);
} else if (IS_GEN(uncore->i915, 5)) { } else if (GRAPHICS_VER(uncore->i915) == 5) {
ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, gen5); ASSIGN_RAW_WRITE_MMIO_VFUNCS(uncore, gen5);
ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, gen5); ASSIGN_RAW_READ_MMIO_VFUNCS(uncore, gen5);
} else { } else {
...@@ -1870,7 +1870,7 @@ static int uncore_forcewake_init(struct intel_uncore *uncore) ...@@ -1870,7 +1870,7 @@ static int uncore_forcewake_init(struct intel_uncore *uncore)
return ret; return ret;
forcewake_early_sanitize(uncore, 0); forcewake_early_sanitize(uncore, 0);
if (IS_GEN_RANGE(i915, 6, 7)) { if (IS_GRAPHICS_VER(i915, 6, 7)) {
ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen6); ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen6);
if (IS_VALLEYVIEW(i915)) { if (IS_VALLEYVIEW(i915)) {
...@@ -1879,7 +1879,7 @@ static int uncore_forcewake_init(struct intel_uncore *uncore) ...@@ -1879,7 +1879,7 @@ static int uncore_forcewake_init(struct intel_uncore *uncore)
} else { } else {
ASSIGN_READ_MMIO_VFUNCS(uncore, gen6); ASSIGN_READ_MMIO_VFUNCS(uncore, gen6);
} }
} else if (IS_GEN(i915, 8)) { } else if (GRAPHICS_VER(i915) == 8) {
if (IS_CHERRYVIEW(i915)) { if (IS_CHERRYVIEW(i915)) {
ASSIGN_FW_DOMAINS_TABLE(uncore, __chv_fw_ranges); ASSIGN_FW_DOMAINS_TABLE(uncore, __chv_fw_ranges);
ASSIGN_WRITE_MMIO_VFUNCS(uncore, fwtable); ASSIGN_WRITE_MMIO_VFUNCS(uncore, fwtable);
...@@ -1888,11 +1888,11 @@ static int uncore_forcewake_init(struct intel_uncore *uncore) ...@@ -1888,11 +1888,11 @@ static int uncore_forcewake_init(struct intel_uncore *uncore)
ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen8); ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen8);
ASSIGN_READ_MMIO_VFUNCS(uncore, gen6); ASSIGN_READ_MMIO_VFUNCS(uncore, gen6);
} }
} else if (IS_GEN_RANGE(i915, 9, 10)) { } else if (IS_GRAPHICS_VER(i915, 9, 10)) {
ASSIGN_FW_DOMAINS_TABLE(uncore, __gen9_fw_ranges); ASSIGN_FW_DOMAINS_TABLE(uncore, __gen9_fw_ranges);
ASSIGN_WRITE_MMIO_VFUNCS(uncore, fwtable); ASSIGN_WRITE_MMIO_VFUNCS(uncore, fwtable);
ASSIGN_READ_MMIO_VFUNCS(uncore, fwtable); ASSIGN_READ_MMIO_VFUNCS(uncore, fwtable);
} else if (IS_GEN(i915, 11)) { } else if (GRAPHICS_VER(i915) == 11) {
ASSIGN_FW_DOMAINS_TABLE(uncore, __gen11_fw_ranges); ASSIGN_FW_DOMAINS_TABLE(uncore, __gen11_fw_ranges);
ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen11_fwtable); ASSIGN_WRITE_MMIO_VFUNCS(uncore, gen11_fwtable);
ASSIGN_READ_MMIO_VFUNCS(uncore, gen11_fwtable); ASSIGN_READ_MMIO_VFUNCS(uncore, gen11_fwtable);
...@@ -1940,7 +1940,7 @@ int intel_uncore_init_mmio(struct intel_uncore *uncore) ...@@ -1940,7 +1940,7 @@ int intel_uncore_init_mmio(struct intel_uncore *uncore)
if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915))
uncore->flags |= UNCORE_HAS_DBG_UNCLAIMED; uncore->flags |= UNCORE_HAS_DBG_UNCLAIMED;
if (IS_GEN_RANGE(i915, 6, 7)) if (IS_GRAPHICS_VER(i915, 6, 7))
uncore->flags |= UNCORE_HAS_FIFO; uncore->flags |= UNCORE_HAS_FIFO;
/* clear out unclaimed reg detection bit */ /* clear out unclaimed reg detection bit */
...@@ -1967,7 +1967,7 @@ void intel_uncore_prune_engine_fw_domains(struct intel_uncore *uncore, ...@@ -1967,7 +1967,7 @@ void intel_uncore_prune_engine_fw_domains(struct intel_uncore *uncore,
enum forcewake_domain_id domain_id; enum forcewake_domain_id domain_id;
int i; int i;
if (!intel_uncore_has_forcewake(uncore) || INTEL_GEN(uncore->i915) < 11) if (!intel_uncore_has_forcewake(uncore) || GRAPHICS_VER(uncore->i915) < 11)
return; return;
for (i = 0; i < I915_MAX_VCS; i++) { for (i = 0; i < I915_MAX_VCS; i++) {
......
...@@ -81,7 +81,7 @@ void intel_wopcm_init_early(struct intel_wopcm *wopcm) ...@@ -81,7 +81,7 @@ void intel_wopcm_init_early(struct intel_wopcm *wopcm)
if (!HAS_GT_UC(i915)) if (!HAS_GT_UC(i915))
return; return;
if (INTEL_GEN(i915) >= 11) if (GRAPHICS_VER(i915) >= 11)
wopcm->size = GEN11_WOPCM_SIZE; wopcm->size = GEN11_WOPCM_SIZE;
else else
wopcm->size = GEN9_WOPCM_SIZE; wopcm->size = GEN9_WOPCM_SIZE;
...@@ -93,7 +93,7 @@ static u32 context_reserved_size(struct drm_i915_private *i915) ...@@ -93,7 +93,7 @@ static u32 context_reserved_size(struct drm_i915_private *i915)
{ {
if (IS_GEN9_LP(i915)) if (IS_GEN9_LP(i915))
return BXT_WOPCM_RC6_CTX_RESERVED; return BXT_WOPCM_RC6_CTX_RESERVED;
else if (INTEL_GEN(i915) >= 10) else if (GRAPHICS_VER(i915) >= 10)
return CNL_WOPCM_HW_CTX_RESERVED; return CNL_WOPCM_HW_CTX_RESERVED;
else else
return 0; return 0;
...@@ -145,11 +145,11 @@ static bool check_hw_restrictions(struct drm_i915_private *i915, ...@@ -145,11 +145,11 @@ static bool check_hw_restrictions(struct drm_i915_private *i915,
u32 guc_wopcm_base, u32 guc_wopcm_size, u32 guc_wopcm_base, u32 guc_wopcm_size,
u32 huc_fw_size) u32 huc_fw_size)
{ {
if (IS_GEN(i915, 9) && !gen9_check_dword_gap(i915, guc_wopcm_base, if (GRAPHICS_VER(i915) == 9 && !gen9_check_dword_gap(i915, guc_wopcm_base,
guc_wopcm_size)) guc_wopcm_size))
return false; return false;
if (IS_GEN(i915, 9) && if (GRAPHICS_VER(i915) == 9 &&
!gen9_check_huc_fw_fits(i915, guc_wopcm_size, huc_fw_size)) !gen9_check_huc_fw_fits(i915, guc_wopcm_size, huc_fw_size))
return false; return false;
......
...@@ -1885,9 +1885,9 @@ static int igt_cs_tlb(void *arg) ...@@ -1885,9 +1885,9 @@ static int igt_cs_tlb(void *arg)
u32 *cs = batch + i * 64 / sizeof(*cs); u32 *cs = batch + i * 64 / sizeof(*cs);
u64 addr = (vm->total - PAGE_SIZE) + i * sizeof(u32); u64 addr = (vm->total - PAGE_SIZE) + i * sizeof(u32);
GEM_BUG_ON(INTEL_GEN(i915) < 6); GEM_BUG_ON(GRAPHICS_VER(i915) < 6);
cs[0] = MI_STORE_DWORD_IMM_GEN4; cs[0] = MI_STORE_DWORD_IMM_GEN4;
if (INTEL_GEN(i915) >= 8) { if (GRAPHICS_VER(i915) >= 8) {
cs[1] = lower_32_bits(addr); cs[1] = lower_32_bits(addr);
cs[2] = upper_32_bits(addr); cs[2] = upper_32_bits(addr);
cs[3] = i; cs[3] = i;
......
...@@ -98,7 +98,7 @@ test_stream(struct i915_perf *perf) ...@@ -98,7 +98,7 @@ test_stream(struct i915_perf *perf)
I915_ENGINE_CLASS_RENDER, I915_ENGINE_CLASS_RENDER,
0), 0),
.sample_flags = SAMPLE_OA_REPORT, .sample_flags = SAMPLE_OA_REPORT,
.oa_format = IS_GEN(perf->i915, 12) ? .oa_format = GRAPHICS_VER(perf->i915) == 12 ?
I915_OA_FORMAT_A32u40_A4u32_B8_C8 : I915_OA_FORMAT_C4_B8, I915_OA_FORMAT_A32u40_A4u32_B8_C8 : I915_OA_FORMAT_C4_B8,
}; };
struct i915_perf_stream *stream; struct i915_perf_stream *stream;
...@@ -162,7 +162,7 @@ static int write_timestamp(struct i915_request *rq, int slot) ...@@ -162,7 +162,7 @@ static int write_timestamp(struct i915_request *rq, int slot)
return PTR_ERR(cs); return PTR_ERR(cs);
len = 5; len = 5;
if (INTEL_GEN(rq->engine->i915) >= 8) if (GRAPHICS_VER(rq->engine->i915) >= 8)
len++; len++;
*cs++ = GFX_OP_PIPE_CONTROL(len); *cs++ = GFX_OP_PIPE_CONTROL(len);
...@@ -363,7 +363,7 @@ static int live_noa_gpr(void *arg) ...@@ -363,7 +363,7 @@ static int live_noa_gpr(void *arg)
} }
cmd = MI_STORE_REGISTER_MEM; cmd = MI_STORE_REGISTER_MEM;
if (INTEL_GEN(i915) >= 8) if (GRAPHICS_VER(i915) >= 8)
cmd++; cmd++;
cmd |= MI_USE_GGTT; cmd |= MI_USE_GGTT;
......
...@@ -963,7 +963,7 @@ static int live_empty_request(void *arg) ...@@ -963,7 +963,7 @@ static int live_empty_request(void *arg)
static struct i915_vma *recursive_batch(struct drm_i915_private *i915) static struct i915_vma *recursive_batch(struct drm_i915_private *i915)
{ {
struct drm_i915_gem_object *obj; struct drm_i915_gem_object *obj;
const int gen = INTEL_GEN(i915); const int ver = GRAPHICS_VER(i915);
struct i915_vma *vma; struct i915_vma *vma;
u32 *cmd; u32 *cmd;
int err; int err;
...@@ -988,11 +988,11 @@ static struct i915_vma *recursive_batch(struct drm_i915_private *i915) ...@@ -988,11 +988,11 @@ static struct i915_vma *recursive_batch(struct drm_i915_private *i915)
goto err; goto err;
} }
if (gen >= 8) { if (ver >= 8) {
*cmd++ = MI_BATCH_BUFFER_START | 1 << 8 | 1; *cmd++ = MI_BATCH_BUFFER_START | 1 << 8 | 1;
*cmd++ = lower_32_bits(vma->node.start); *cmd++ = lower_32_bits(vma->node.start);
*cmd++ = upper_32_bits(vma->node.start); *cmd++ = upper_32_bits(vma->node.start);
} else if (gen >= 6) { } else if (ver >= 6) {
*cmd++ = MI_BATCH_BUFFER_START | 1 << 8; *cmd++ = MI_BATCH_BUFFER_START | 1 << 8;
*cmd++ = lower_32_bits(vma->node.start); *cmd++ = lower_32_bits(vma->node.start);
} else { } else {
...@@ -2482,7 +2482,7 @@ static int perf_request_latency(void *arg) ...@@ -2482,7 +2482,7 @@ static int perf_request_latency(void *arg)
struct pm_qos_request qos; struct pm_qos_request qos;
int err = 0; int err = 0;
if (INTEL_GEN(i915) < 8) /* per-engine CS timestamp, semaphores */ if (GRAPHICS_VER(i915) < 8) /* per-engine CS timestamp, semaphores */
return 0; return 0;
cpu_latency_qos_add_request(&qos, 0); /* disable cstates */ cpu_latency_qos_add_request(&qos, 0); /* disable cstates */
......
...@@ -174,15 +174,15 @@ igt_spinner_create_request(struct igt_spinner *spin, ...@@ -174,15 +174,15 @@ igt_spinner_create_request(struct igt_spinner *spin,
batch = spin->batch; batch = spin->batch;
if (INTEL_GEN(rq->engine->i915) >= 8) { if (GRAPHICS_VER(rq->engine->i915) >= 8) {
*batch++ = MI_STORE_DWORD_IMM_GEN4; *batch++ = MI_STORE_DWORD_IMM_GEN4;
*batch++ = lower_32_bits(hws_address(hws, rq)); *batch++ = lower_32_bits(hws_address(hws, rq));
*batch++ = upper_32_bits(hws_address(hws, rq)); *batch++ = upper_32_bits(hws_address(hws, rq));
} else if (INTEL_GEN(rq->engine->i915) >= 6) { } else if (GRAPHICS_VER(rq->engine->i915) >= 6) {
*batch++ = MI_STORE_DWORD_IMM_GEN4; *batch++ = MI_STORE_DWORD_IMM_GEN4;
*batch++ = 0; *batch++ = 0;
*batch++ = hws_address(hws, rq); *batch++ = hws_address(hws, rq);
} else if (INTEL_GEN(rq->engine->i915) >= 4) { } else if (GRAPHICS_VER(rq->engine->i915) >= 4) {
*batch++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT; *batch++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT;
*batch++ = 0; *batch++ = 0;
*batch++ = hws_address(hws, rq); *batch++ = hws_address(hws, rq);
...@@ -194,11 +194,11 @@ igt_spinner_create_request(struct igt_spinner *spin, ...@@ -194,11 +194,11 @@ igt_spinner_create_request(struct igt_spinner *spin,
*batch++ = arbitration_command; *batch++ = arbitration_command;
if (INTEL_GEN(rq->engine->i915) >= 8) if (GRAPHICS_VER(rq->engine->i915) >= 8)
*batch++ = MI_BATCH_BUFFER_START | BIT(8) | 1; *batch++ = MI_BATCH_BUFFER_START | BIT(8) | 1;
else if (IS_HASWELL(rq->engine->i915)) else if (IS_HASWELL(rq->engine->i915))
*batch++ = MI_BATCH_BUFFER_START | MI_BATCH_PPGTT_HSW; *batch++ = MI_BATCH_BUFFER_START | MI_BATCH_PPGTT_HSW;
else if (INTEL_GEN(rq->engine->i915) >= 6) else if (GRAPHICS_VER(rq->engine->i915) >= 6)
*batch++ = MI_BATCH_BUFFER_START; *batch++ = MI_BATCH_BUFFER_START;
else else
*batch++ = MI_BATCH_BUFFER_START | MI_BATCH_GTT; *batch++ = MI_BATCH_BUFFER_START | MI_BATCH_GTT;
...@@ -216,7 +216,7 @@ igt_spinner_create_request(struct igt_spinner *spin, ...@@ -216,7 +216,7 @@ igt_spinner_create_request(struct igt_spinner *spin,
} }
flags = 0; flags = 0;
if (INTEL_GEN(rq->engine->i915) <= 5) if (GRAPHICS_VER(rq->engine->i915) <= 5)
flags |= I915_DISPATCH_SECURE; flags |= I915_DISPATCH_SECURE;
err = engine->emit_bb_start(rq, vma->node.start, PAGE_SIZE, flags); err = engine->emit_bb_start(rq, vma->node.start, PAGE_SIZE, flags);
......
...@@ -321,7 +321,7 @@ static int live_fw_table(void *arg) ...@@ -321,7 +321,7 @@ static int live_fw_table(void *arg)
/* Confirm the table we load is still valid */ /* Confirm the table we load is still valid */
return intel_fw_table_check(gt->uncore->fw_domains_table, return intel_fw_table_check(gt->uncore->fw_domains_table,
gt->uncore->fw_domains_table_entries, gt->uncore->fw_domains_table_entries,
INTEL_GEN(gt->i915) >= 9); GRAPHICS_VER(gt->i915) >= 9);
} }
int intel_uncore_live_selftests(struct drm_i915_private *i915) int intel_uncore_live_selftests(struct drm_i915_private *i915)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment