Commit 656f26ad authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: 53c700: Call scsi_done() directly

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-12-bvanassche@acm.orgSigned-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9dd9b96c
...@@ -634,7 +634,7 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata, ...@@ -634,7 +634,7 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata,
SCp->host_scribble = NULL; SCp->host_scribble = NULL;
SCp->result = result; SCp->result = result;
SCp->scsi_done(SCp); scsi_done(SCp);
} else { } else {
printk(KERN_ERR "53c700: SCSI DONE HAS NULL SCp\n"); printk(KERN_ERR "53c700: SCSI DONE HAS NULL SCp\n");
} }
...@@ -1571,7 +1571,7 @@ NCR_700_intr(int irq, void *dev_id) ...@@ -1571,7 +1571,7 @@ NCR_700_intr(int irq, void *dev_id)
* deadlock on the * deadlock on the
* hostdata->state_lock */ * hostdata->state_lock */
SCp->result = DID_RESET << 16; SCp->result = DID_RESET << 16;
SCp->scsi_done(SCp); scsi_done(SCp);
} }
mdelay(25); mdelay(25);
NCR_700_chip_setup(host); NCR_700_chip_setup(host);
...@@ -1792,7 +1792,6 @@ NCR_700_queuecommand_lck(struct scsi_cmnd *SCp, void (*done)(struct scsi_cmnd *) ...@@ -1792,7 +1792,6 @@ NCR_700_queuecommand_lck(struct scsi_cmnd *SCp, void (*done)(struct scsi_cmnd *)
slot->cmnd = SCp; slot->cmnd = SCp;
SCp->scsi_done = done;
SCp->host_scribble = (unsigned char *)slot; SCp->host_scribble = (unsigned char *)slot;
SCp->SCp.ptr = NULL; SCp->SCp.ptr = NULL;
SCp->SCp.buffer = NULL; SCp->SCp.buffer = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment