Commit 65c5a055 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig

nvme: fix incorrect behavior when BLKROSET is called by the user

The offending commit breaks BLKROSET ioctl because a device
revalidation will blindly override BLKROSET setting. Hence,
we remove the disk rw setting in case NVME_NS_ATTR_RO is cleared
from by the controller.

Fixes: 1293477f ("nvme: set gendisk read only based on nsattr")
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent e1777d09
...@@ -2060,8 +2060,6 @@ static void nvme_update_disk_info(struct gendisk *disk, ...@@ -2060,8 +2060,6 @@ static void nvme_update_disk_info(struct gendisk *disk,
if (id->nsattr & NVME_NS_ATTR_RO) if (id->nsattr & NVME_NS_ATTR_RO)
set_disk_ro(disk, true); set_disk_ro(disk, true);
else
set_disk_ro(disk, false);
} }
static inline bool nvme_first_scan(struct gendisk *disk) static inline bool nvme_first_scan(struct gendisk *disk)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment