Commit 65f2b43f authored by Eric Dumazet's avatar Eric Dumazet Committed by Greg Kroah-Hartman

smsc75xx: fix smsc75xx_set_features()

[ Upstream commit 88e80c62 ]

If an attempt is made to disable RX checksums, USB adapter is changed
but netdev->features is not, because smsc75xx_set_features() returns a
non zero value.

This throws errors from netdev_rx_csum_fault() :
<devname>: hw csum failure
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 235968be
......@@ -945,10 +945,11 @@ static int smsc75xx_set_features(struct net_device *netdev,
/* it's racing here! */
ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
if (ret < 0)
if (ret < 0) {
netdev_warn(dev->net, "Error writing RFE_CTL\n");
return ret;
return ret;
}
return 0;
}
static int smsc75xx_wait_ready(struct usbnet *dev, int in_pm)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment