Commit 668128e9 authored by NeilBrown's avatar NeilBrown Committed by Linus Torvalds

autofs4: don't take spinlock when not needed in autofs4_lookup_expiring

If the expiring_list is empty, we can avoid a costly spinlock in the
rcu-walk path through autofs4_d_manage (once the rest of the path
becomes rcu-walk friendly).
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Reviewed-by: default avatarIan Kent <raven@themaw.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c312442f
...@@ -166,8 +166,10 @@ static struct dentry *autofs4_lookup_active(struct dentry *dentry) ...@@ -166,8 +166,10 @@ static struct dentry *autofs4_lookup_active(struct dentry *dentry)
const unsigned char *str = name->name; const unsigned char *str = name->name;
struct list_head *p, *head; struct list_head *p, *head;
spin_lock(&sbi->lookup_lock);
head = &sbi->active_list; head = &sbi->active_list;
if (list_empty(head))
return NULL;
spin_lock(&sbi->lookup_lock);
list_for_each(p, head) { list_for_each(p, head) {
struct autofs_info *ino; struct autofs_info *ino;
struct dentry *active; struct dentry *active;
...@@ -218,8 +220,10 @@ static struct dentry *autofs4_lookup_expiring(struct dentry *dentry) ...@@ -218,8 +220,10 @@ static struct dentry *autofs4_lookup_expiring(struct dentry *dentry)
const unsigned char *str = name->name; const unsigned char *str = name->name;
struct list_head *p, *head; struct list_head *p, *head;
spin_lock(&sbi->lookup_lock);
head = &sbi->expiring_list; head = &sbi->expiring_list;
if (list_empty(head))
return NULL;
spin_lock(&sbi->lookup_lock);
list_for_each(p, head) { list_for_each(p, head) {
struct autofs_info *ino; struct autofs_info *ino;
struct dentry *expiring; struct dentry *expiring;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment