Commit 66a0b101 authored by Daniel Lezcano's avatar Daniel Lezcano

thermal/drivers/u8500: Remove the get_trend function

The get_trend function relies on the interrupt to set the raising or
dropping trend. However the interpolated temperature is already giving
the temperature information to the thermal framework which is able to
deduce the trend.

Remove the trend code.
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20220616202537.303655-3-daniel.lezcano@linaro.orgSigned-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent afbeb99e
...@@ -53,7 +53,6 @@ static const unsigned long db8500_thermal_points[] = { ...@@ -53,7 +53,6 @@ static const unsigned long db8500_thermal_points[] = {
struct db8500_thermal_zone { struct db8500_thermal_zone {
struct thermal_zone_device *tz; struct thermal_zone_device *tz;
enum thermal_trend trend;
unsigned long interpolated_temp; unsigned long interpolated_temp;
unsigned int cur_index; unsigned int cur_index;
}; };
...@@ -73,24 +72,12 @@ static int db8500_thermal_get_temp(void *data, int *temp) ...@@ -73,24 +72,12 @@ static int db8500_thermal_get_temp(void *data, int *temp)
return 0; return 0;
} }
/* Callback to get temperature changing trend */
static int db8500_thermal_get_trend(void *data, int trip, enum thermal_trend *trend)
{
struct db8500_thermal_zone *th = data;
*trend = th->trend;
return 0;
}
static struct thermal_zone_of_device_ops thdev_ops = { static struct thermal_zone_of_device_ops thdev_ops = {
.get_temp = db8500_thermal_get_temp, .get_temp = db8500_thermal_get_temp,
.get_trend = db8500_thermal_get_trend,
}; };
static void db8500_thermal_update_config(struct db8500_thermal_zone *th, static void db8500_thermal_update_config(struct db8500_thermal_zone *th,
unsigned int idx, unsigned int idx,
enum thermal_trend trend,
unsigned long next_low, unsigned long next_low,
unsigned long next_high) unsigned long next_high)
{ {
...@@ -98,7 +85,6 @@ static void db8500_thermal_update_config(struct db8500_thermal_zone *th, ...@@ -98,7 +85,6 @@ static void db8500_thermal_update_config(struct db8500_thermal_zone *th,
th->cur_index = idx; th->cur_index = idx;
th->interpolated_temp = (next_low + next_high)/2; th->interpolated_temp = (next_low + next_high)/2;
th->trend = trend;
/* /*
* The PRCMU accept absolute temperatures in celsius so divide * The PRCMU accept absolute temperatures in celsius so divide
...@@ -127,8 +113,7 @@ static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data) ...@@ -127,8 +113,7 @@ static irqreturn_t prcmu_low_irq_handler(int irq, void *irq_data)
} }
idx -= 1; idx -= 1;
db8500_thermal_update_config(th, idx, THERMAL_TREND_DROPPING, db8500_thermal_update_config(th, idx, next_low, next_high);
next_low, next_high);
dev_dbg(&th->tz->device, dev_dbg(&th->tz->device,
"PRCMU set max %ld, min %ld\n", next_high, next_low); "PRCMU set max %ld, min %ld\n", next_high, next_low);
...@@ -149,8 +134,7 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data) ...@@ -149,8 +134,7 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
next_low = db8500_thermal_points[idx]; next_low = db8500_thermal_points[idx];
idx += 1; idx += 1;
db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING, db8500_thermal_update_config(th, idx, next_low, next_high);
next_low, next_high);
dev_dbg(&th->tz->device, dev_dbg(&th->tz->device,
"PRCMU set max %ld, min %ld\n", next_high, next_low); "PRCMU set max %ld, min %ld\n", next_high, next_low);
...@@ -210,8 +194,7 @@ static int db8500_thermal_probe(struct platform_device *pdev) ...@@ -210,8 +194,7 @@ static int db8500_thermal_probe(struct platform_device *pdev)
dev_info(dev, "thermal zone sensor registered\n"); dev_info(dev, "thermal zone sensor registered\n");
/* Start measuring at the lowest point */ /* Start measuring at the lowest point */
db8500_thermal_update_config(th, 0, THERMAL_TREND_STABLE, db8500_thermal_update_config(th, 0, PRCMU_DEFAULT_LOW_TEMP,
PRCMU_DEFAULT_LOW_TEMP,
db8500_thermal_points[0]); db8500_thermal_points[0]);
platform_set_drvdata(pdev, th); platform_set_drvdata(pdev, th);
...@@ -232,8 +215,7 @@ static int db8500_thermal_resume(struct platform_device *pdev) ...@@ -232,8 +215,7 @@ static int db8500_thermal_resume(struct platform_device *pdev)
struct db8500_thermal_zone *th = platform_get_drvdata(pdev); struct db8500_thermal_zone *th = platform_get_drvdata(pdev);
/* Resume and start measuring at the lowest point */ /* Resume and start measuring at the lowest point */
db8500_thermal_update_config(th, 0, THERMAL_TREND_STABLE, db8500_thermal_update_config(th, 0, PRCMU_DEFAULT_LOW_TEMP,
PRCMU_DEFAULT_LOW_TEMP,
db8500_thermal_points[0]); db8500_thermal_points[0]);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment