Commit 66b92988 authored by Felipe Balbi's avatar Felipe Balbi Committed by Wolfram Sang

i2c: omap: switch over to do {} while loop

this will make sure that we execute at least once.
No functional changes otherwise.
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarShubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
parent 3312d25e
...@@ -827,20 +827,28 @@ omap_i2c_isr(int this_irq, void *dev_id) ...@@ -827,20 +827,28 @@ omap_i2c_isr(int this_irq, void *dev_id)
struct omap_i2c_dev *dev = dev_id; struct omap_i2c_dev *dev = dev_id;
u16 bits; u16 bits;
u16 stat; u16 stat;
int err, count = 0; int err = 0, count = 0;
if (pm_runtime_suspended(dev->dev)) if (pm_runtime_suspended(dev->dev))
return IRQ_NONE; return IRQ_NONE;
bits = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG); do {
while ((stat = (omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG))) & bits) { bits = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
stat &= bits;
if (!stat) {
/* my work here is done */
return IRQ_HANDLED;
}
dev_dbg(dev->dev, "IRQ (ISR = 0x%04x)\n", stat); dev_dbg(dev->dev, "IRQ (ISR = 0x%04x)\n", stat);
if (count++ == 100) { if (count++ == 100) {
dev_warn(dev->dev, "Too much work in one IRQ\n"); dev_warn(dev->dev, "Too much work in one IRQ\n");
break; omap_i2c_complete_cmd(dev, err);
return IRQ_HANDLED;
} }
err = 0;
complete: complete:
/* /*
* Ack the stat in one go, but [R/X]DR and [R/X]RDY should be * Ack the stat in one go, but [R/X]DR and [R/X]RDY should be
...@@ -940,7 +948,7 @@ omap_i2c_isr(int this_irq, void *dev_id) ...@@ -940,7 +948,7 @@ omap_i2c_isr(int this_irq, void *dev_id)
dev_err(dev->dev, "Transmit underflow\n"); dev_err(dev->dev, "Transmit underflow\n");
dev->cmd_err |= OMAP_I2C_STAT_XUDF; dev->cmd_err |= OMAP_I2C_STAT_XUDF;
} }
} } while (stat);
return count ? IRQ_HANDLED : IRQ_NONE; return count ? IRQ_HANDLED : IRQ_NONE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment