Commit 68a19964 authored by Martin Kurbanov's avatar Martin Kurbanov Committed by Mark Brown

spi: amlogic-spifc-a1: implement adjust_op_size()

This enhancement eliminates the need for a loop in the
amlogic_spifc_a1_exec_op() function and allows the SPI core to
dynamically divide transactions into appropriately sized chunks.
Signed-off-by: default avatarMartin Kurbanov <mmkurbanov@sberdevices.ru>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20230706110331.19794-2-mmkurbanov@sberdevices.ruSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 06c2afb8
...@@ -72,7 +72,7 @@ ...@@ -72,7 +72,7 @@
#define SPIFC_A1_USER_DBUF_ADDR_REG 0x248 #define SPIFC_A1_USER_DBUF_ADDR_REG 0x248
#define SPIFC_A1_BUFFER_SIZE 512 #define SPIFC_A1_BUFFER_SIZE 512U
#define SPIFC_A1_MAX_HZ 200000000 #define SPIFC_A1_MAX_HZ 200000000
#define SPIFC_A1_MIN_HZ 1000000 #define SPIFC_A1_MIN_HZ 1000000
...@@ -240,61 +240,44 @@ static int amlogic_spifc_a1_exec_op(struct spi_mem *mem, ...@@ -240,61 +240,44 @@ static int amlogic_spifc_a1_exec_op(struct spi_mem *mem,
{ {
struct amlogic_spifc_a1 *spifc = struct amlogic_spifc_a1 *spifc =
spi_controller_get_devdata(mem->spi->controller); spi_controller_get_devdata(mem->spi->controller);
size_t off, nbytes = op->data.nbytes; size_t data_size = op->data.nbytes;
u32 cmd_cfg, addr_cfg, dummy_cfg, dmode;
int ret; int ret;
amlogic_spifc_a1_user_init(spifc); amlogic_spifc_a1_user_init(spifc);
amlogic_spifc_a1_set_cmd(spifc, SPIFC_A1_USER_CMD(op));
cmd_cfg = SPIFC_A1_USER_CMD(op); if (op->addr.nbytes)
amlogic_spifc_a1_set_cmd(spifc, cmd_cfg); amlogic_spifc_a1_set_addr(spifc, op->addr.val,
SPIFC_A1_USER_ADDR(op));
if (op->addr.nbytes) { if (op->dummy.nbytes)
addr_cfg = SPIFC_A1_USER_ADDR(op); amlogic_spifc_a1_set_dummy(spifc, SPIFC_A1_USER_DUMMY(op));
amlogic_spifc_a1_set_addr(spifc, op->addr.val, addr_cfg);
}
if (op->dummy.nbytes) {
dummy_cfg = SPIFC_A1_USER_DUMMY(op);
amlogic_spifc_a1_set_dummy(spifc, dummy_cfg);
}
if (!op->data.nbytes)
return amlogic_spifc_a1_request(spifc, false);
dmode = ilog2(op->data.buswidth);
off = 0;
do {
size_t block_size = min_t(size_t, nbytes, SPIFC_A1_BUFFER_SIZE);
amlogic_spifc_a1_set_cmd(spifc, cmd_cfg);
if (op->addr.nbytes) if (data_size) {
amlogic_spifc_a1_set_addr(spifc, op->addr.val + off, u32 mode = ilog2(op->data.buswidth);
addr_cfg);
if (op->dummy.nbytes)
amlogic_spifc_a1_set_dummy(spifc, dummy_cfg);
writel(0, spifc->base + SPIFC_A1_USER_DBUF_ADDR_REG); writel(0, spifc->base + SPIFC_A1_USER_DBUF_ADDR_REG);
if (op->data.dir == SPI_MEM_DATA_IN) if (op->data.dir == SPI_MEM_DATA_IN)
ret = amlogic_spifc_a1_read(spifc, ret = amlogic_spifc_a1_read(spifc, op->data.buf.in,
op->data.buf.in + off, data_size, mode);
block_size, dmode);
else else
ret = amlogic_spifc_a1_write(spifc, ret = amlogic_spifc_a1_write(spifc, op->data.buf.out,
op->data.buf.out + off, data_size, mode);
block_size, dmode); } else {
ret = amlogic_spifc_a1_request(spifc, false);
nbytes -= block_size; }
off += block_size;
} while (nbytes != 0 && !ret);
return ret; return ret;
} }
static int amlogic_spifc_a1_adjust_op_size(struct spi_mem *mem,
struct spi_mem_op *op)
{
op->data.nbytes = min(op->data.nbytes, SPIFC_A1_BUFFER_SIZE);
return 0;
}
static void amlogic_spifc_a1_hw_init(struct amlogic_spifc_a1 *spifc) static void amlogic_spifc_a1_hw_init(struct amlogic_spifc_a1 *spifc)
{ {
u32 regv; u32 regv;
...@@ -314,6 +297,7 @@ static void amlogic_spifc_a1_hw_init(struct amlogic_spifc_a1 *spifc) ...@@ -314,6 +297,7 @@ static void amlogic_spifc_a1_hw_init(struct amlogic_spifc_a1 *spifc)
static const struct spi_controller_mem_ops amlogic_spifc_a1_mem_ops = { static const struct spi_controller_mem_ops amlogic_spifc_a1_mem_ops = {
.exec_op = amlogic_spifc_a1_exec_op, .exec_op = amlogic_spifc_a1_exec_op,
.adjust_op_size = amlogic_spifc_a1_adjust_op_size,
}; };
static int amlogic_spifc_a1_probe(struct platform_device *pdev) static int amlogic_spifc_a1_probe(struct platform_device *pdev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment