Commit 68bb3c3f authored by Dan Carpenter's avatar Dan Carpenter Committed by Alex Deucher

drm/amd/powerplay: off by one bugs in smu_cmn_to_asic_specific_index()

These tables have _COUNT number of elements so the comparisons should be
>= instead of > to prevent reading one element beyond the end of the
array.

Fixes: 8264ee69 ("drm/amd/powerplay: drop unused code")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a486bc3c
...@@ -166,7 +166,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu, ...@@ -166,7 +166,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu,
switch (type) { switch (type) {
case CMN2ASIC_MAPPING_MSG: case CMN2ASIC_MAPPING_MSG:
if (index > SMU_MSG_MAX_COUNT || if (index >= SMU_MSG_MAX_COUNT ||
!smu->message_map) !smu->message_map)
return -EINVAL; return -EINVAL;
...@@ -181,7 +181,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu, ...@@ -181,7 +181,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu,
return msg_mapping.map_to; return msg_mapping.map_to;
case CMN2ASIC_MAPPING_CLK: case CMN2ASIC_MAPPING_CLK:
if (index > SMU_CLK_COUNT || if (index >= SMU_CLK_COUNT ||
!smu->clock_map) !smu->clock_map)
return -EINVAL; return -EINVAL;
...@@ -192,7 +192,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu, ...@@ -192,7 +192,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu,
return mapping.map_to; return mapping.map_to;
case CMN2ASIC_MAPPING_FEATURE: case CMN2ASIC_MAPPING_FEATURE:
if (index > SMU_FEATURE_COUNT || if (index >= SMU_FEATURE_COUNT ||
!smu->feature_map) !smu->feature_map)
return -EINVAL; return -EINVAL;
...@@ -203,7 +203,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu, ...@@ -203,7 +203,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu,
return mapping.map_to; return mapping.map_to;
case CMN2ASIC_MAPPING_TABLE: case CMN2ASIC_MAPPING_TABLE:
if (index > SMU_TABLE_COUNT || if (index >= SMU_TABLE_COUNT ||
!smu->table_map) !smu->table_map)
return -EINVAL; return -EINVAL;
...@@ -214,7 +214,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu, ...@@ -214,7 +214,7 @@ int smu_cmn_to_asic_specific_index(struct smu_context *smu,
return mapping.map_to; return mapping.map_to;
case CMN2ASIC_MAPPING_PWR: case CMN2ASIC_MAPPING_PWR:
if (index > SMU_POWER_SOURCE_COUNT || if (index >= SMU_POWER_SOURCE_COUNT ||
!smu->pwr_src_map) !smu->pwr_src_map)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment